From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-141876-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 21099 invoked by alias); 21 Sep 2017 10:00:38 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 20914 invoked by uid 89); 21 Sep 2017 10:00:29 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-0.9 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=H*M:94c4, Hx-languages-length:414
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 21 Sep 2017 10:00:28 +0000
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id A66827E45D;	Thu, 21 Sep 2017 10:00:27 +0000 (UTC)
DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com A66827E45D
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com
Authentication-Results: ext-mx03.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com
Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4])	by smtp.corp.redhat.com (Postfix) with ESMTP id C07EE5D6A3;	Thu, 21 Sep 2017 10:00:26 +0000 (UTC)
Subject: Re: [RFA 37/67] Constify some commands in record.c
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
References: <20170921051023.19023-1-tom@tromey.com> <20170921051023.19023-38-tom@tromey.com>
From: Pedro Alves <palves@redhat.com>
Message-ID: <a596e0a2-8db9-6aab-94c4-d4a93093d754@redhat.com>
Date: Thu, 21 Sep 2017 10:00:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0
MIME-Version: 1.0
In-Reply-To: <20170921051023.19023-38-tom@tromey.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
X-SW-Source: 2017-09/txt/msg00610.txt.bz2

On 09/21/2017 06:09 AM, Tom Tromey wrote:
> @@ -456,13 +458,15 @@ get_context_size (char **arg)
>    if (!isdigit (*pos))
>      error (_("Expected positive number, got: %s."), pos);
>  
> -  return strtol (pos, arg, 10);
> +   long result = strtol (pos, &end, 10);
> +   *arg = end;
> +   return result;
>  }

Indentation looks odd.  [3 spaces instead of 2?]

Thanks,
Pedro Alves