From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 27910 invoked by alias); 7 Sep 2018 22:18:32 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 27879 invoked by uid 89); 7 Sep 2018 22:18:32 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy= X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 07 Sep 2018 22:18:30 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w87MIN5l020684 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 7 Sep 2018 18:18:28 -0400 Received: by simark.ca (Postfix, from userid 112) id AA9DE1E5A4; Fri, 7 Sep 2018 18:18:23 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 5E7ED1E012; Fri, 7 Sep 2018 18:18:22 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 07 Sep 2018 22:18:00 -0000 From: Simon Marchi To: Tom Tromey Cc: Jan Vrany , gdb-patches@sourceware.org Subject: Re: [PATCH] Fix various tests to use -no-pie linker flag when needed In-Reply-To: <87lg8dvy0o.fsf@tromey.com> References: <20180828193643.15530-1-jan.vrany@fit.cvut.cz> <87lg8dvy0o.fsf@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-09/txt/msg00136.txt.bz2 On 2018-09-07 21:43, Tom Tromey wrote: >>>>>> "Jan" == Jan Vrany writes: > > Jan> Various test use test code written in i385 / x86_64 assembly that > cannot > Jan> be used to create PIE executables. Therefore compilation of test > programs > Jan> failed on systems where the compiler default is to create PIE > executable. > > Jan> To fix this, force -no-pie linker flag. > > I guess you're on an OS that enables PIE by default? I know recent-ish Ubuntus do that, I don't know if it's a patch specific to that distro or if it's the default value in gcc that changed. > These tests don't seem to be linux- or gcc-specific. > Do you know how universal -no-pie is? My worry is that this would fix > the test for some people but break it for others. > > Tom If needed, we could add a new option understood by gdb_compile that adds the right flag to achieve the result of -no-pie. Simon