From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id cPyaGxXVUmipZRMAWB0awg (envelope-from ) for ; Wed, 18 Jun 2025 11:02:45 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H0OSTCVe; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 6C8DC1E11C; Wed, 18 Jun 2025 11:02:45 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-6.8 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_SBL_CSS,RCVD_IN_VALIDITY_CERTIFIED, RCVD_IN_VALIDITY_RPBL,RCVD_IN_VALIDITY_SAFE autolearn=unavailable autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 093C91E089 for ; Wed, 18 Jun 2025 11:02:45 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 72D103886619 for ; Wed, 18 Jun 2025 15:02:44 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 72D103886619 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=H0OSTCVe Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by sourceware.org (Postfix) with ESMTP id E4E2138697D8 for ; Wed, 18 Jun 2025 15:02:02 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E4E2138697D8 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E4E2138697D8 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.133.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750258923; cv=none; b=sJ8pFy68HiAsiNnHyjOqL6F8CdHbumG41V9quthkD6x8LNrtN/CQphiNq3R5WdE3J/Y/+DsDa0hGesfz9gNYVZmIrIZX14y2MWc1Pt13KghcHNlh2lWAw+xz/pYrmPUiKqoA67t9A5qPCSWV9ZnIormuvQSzt9iCSHP2316uUsI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1750258923; c=relaxed/simple; bh=6NSIRDpvI1kYRyImbBvgmn+Zt6CFNNPWggxqjfXjJ/Y=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=NlWefppO3EefWeLhp7VQpb3cq9JIxIU70Um0aC/E275q8ifY598FTOnztrBBoK/DrDuh8qiLQLZrPsNgqZEVgCF8eahG/TkjVA516SM0bP7KhEO13uQeSbRg4aS4uHCGDtNN6N/iy8NyzKr4wK948kSNInkBH6wEMUFvOE8PGv8= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org E4E2138697D8 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1750258922; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DEzvHjIPLkE1qAg3e4RjHaZvRJ/pQz0gWuc/QiiAeDI=; b=H0OSTCVeO1GY9CFTFlAbiWRZ0f8hBPxWq7jSy3hj2XZ5koi/GM4iai/gtGQwVMFsMuwSwp RCO8/xgHfch0H6557rmnq9HZdk97QFYl6cfPl/ImKJaP8m88va8eEbtenciKsMEKZa5QDS eokZRh4iIjI5JIRmDsYEZVs0Pvq0eYs= Received: from mail-qk1-f199.google.com (mail-qk1-f199.google.com [209.85.222.199]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-592-Vp0tobvdP2elshtb1k__1g-1; Wed, 18 Jun 2025 11:02:01 -0400 X-MC-Unique: Vp0tobvdP2elshtb1k__1g-1 X-Mimecast-MFC-AGG-ID: Vp0tobvdP2elshtb1k__1g_1750258921 Received: by mail-qk1-f199.google.com with SMTP id af79cd13be357-7d099c1779dso1178573685a.0 for ; Wed, 18 Jun 2025 08:02:01 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1750258921; x=1750863721; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=DEzvHjIPLkE1qAg3e4RjHaZvRJ/pQz0gWuc/QiiAeDI=; b=EQrwVxHgkYSNRymbZ1iR1+r/njrnwFX6gXhxLEqkKiOOEoaa9hZrNjI5L17I/ZcuXc /FW/QOJBkxx8LJuCvXMJuQ4YIXD/KISoRLD7m2+HJo3nsRjMMZKNuvvgqoO9/eqe2b00 vyHPqYef4ikqY5+zgJ2Z8s0awQXqfIxG82ZhL4t5exxsdkKqM8mVPdMnkVcjqxzTJ3yk +bv2w6OXRyRr9SU6c7p3o9S4mxg8K0xyazKJsYprw+tWzGW0KEJmK86oLJWO8tC7tbIv DaRNl3TdLLeHuhw8wUjAe/RmpwCWapBs2/IRBNssmT4y4fz+ObC+tC8kUROM88MaRYLC wHXw== X-Forwarded-Encrypted: i=1; AJvYcCVTsDduQpil0fCdcuUCwfCu/TZD7UAyKcWTu/9ml0MMJUcwc/NyxiZiWgTnHmHRM1bHCHNKgqJP3aSUgQ==@sourceware.org X-Gm-Message-State: AOJu0YztJ8/vwoEIECUNa5G4G5UF4C5xlxtWKNLM3kWANcE5eGOPl2F0 R7cKFSFyMLlORpOoZn1FUVMFsk9OYN3y/BN5Ywo0FaC3fGpQXcTfKBRgFijP2UFdpBU7sgcaj2N 0hcdxPqsK5VgxcIXreayDEpzvDFDK8/+5dZ9yw8/wT1kuxR9UlnBAQT5j0bxBwPE= X-Gm-Gg: ASbGncvSjsn+oh/1w3reItRUmKK6TTYaboLLeRGUSrOmzDsNc3+5qYCxbxR6ELPWHl+ PvJerySFaQkjNVF6E4cq6uHIeggDQWBbRzsjXPHYjMDGC9QEnUOcsmnBKqNdiXZwkxY/V/Wp6fL eethPAw5lWjLAwhjbvTAPpUKMlYRfH3yg+/ozDRlLhzLTm0vThXIKlhUbtF1iZuwXZYT58YP2LS 6zhMHq2EdYIzSOzOfYrPNVEKFq1/hMKB7X6e2aaeHEL6hUj0uO/oIpvP7dUvcEU1m0iGrI7ClPl RHWhZnrp2fxO2eKZNNiIow2vy426wTzHNA== X-Received: by 2002:a05:620a:2552:b0:7c7:bb3f:fd40 with SMTP id af79cd13be357-7d3c6c0c7e5mr2803198385a.5.1750258920700; Wed, 18 Jun 2025 08:02:00 -0700 (PDT) X-Google-Smtp-Source: AGHT+IGK09h4mXszTzeEzvNFg3z+ZvBI88NSls/DFqJrhJ/EZ6a73e3cT64ljNn6DMI0PX3D/vi+6A== X-Received: by 2002:a05:620a:2552:b0:7c7:bb3f:fd40 with SMTP id af79cd13be357-7d3c6c0c7e5mr2803191985a.5.1750258920127; Wed, 18 Jun 2025 08:02:00 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:9a69::1000? ([2804:14d:8084:9a69::1000]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7d3b8eac10esm769720985a.58.2025.06.18.08.01.58 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 18 Jun 2025 08:01:59 -0700 (PDT) Message-ID: Date: Wed, 18 Jun 2025 12:01:57 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 5/6] gdb/progspace: add solib_ops pointer in program_space To: Simon Marchi , Simon Marchi , gdb-patches@sourceware.org References: <20250616193443.16703-1-simon.marchi@efficios.com> <20250616193443.16703-5-simon.marchi@efficios.com> <1085bd17-956a-449a-bb9d-eb89a90ac7fc@simark.ca> <348dddac-02ff-4750-afb6-cf87ea9aded2@redhat.com> <6031cab4-1872-4de1-8089-2e6e5d10e0e1@simark.ca> From: Guinevere Larsen In-Reply-To: <6031cab4-1872-4de1-8089-2e6e5d10e0e1@simark.ca> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: 6Wb16qmykID270FUEdq84wSYRM1UfU_zS0L2TB3q1Ao_1750258921 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 6/18/25 11:43 AM, Simon Marchi wrote: > On 6/18/25 7:51 AM, Guinevere Larsen wrote: >> On 6/17/25 5:33 PM, Simon Marchi wrote: >>>> Thanks for working on this series! I have one very minor nit in this patch, but with that fixes, you can feel free to add my review tag >>>> >>>> Reviewed-By: Guinevere Larsen >>>> >>>> Feel free to add it to patches 1-4 as well, as I looked over them and they all LGTM. I still don't feel qualified to offer it for patch 6, though. >>> Thank you! >>> >>> Given your review, I plan to push this series probably tomorrow. You >>> can start rebasing and adjusting your series on top, and then I can >>> hopefully review it this week (note that I'm off this Friday, so it >>> would have to be Thursday max). >> I'll rebase and try to get it ready to send to the list by tomorrow, but I'll also go on vacation starting friday and only return July 7th, so if that series gets approved before GDB 17 branches, I'll need someone to push it for me. > Actually, which patches of my series would be useful to you? Would it > be sufficient to merge patches 1 to 3, or 1 to 4? I think they are > relatively low-risk, compared to the last two. It feels safer to merge > the last two just after the GDB 17 branching, so that they have more > time to get tested in master. > > Simon > Unfortunately, I need patch 5, there's no way around it. Missing the branch point won't be the end of the world, it would just be good feature to send with all the other linker namespaces improvements GDB 17 will have. But there are other things planned for GDB 18, so it's not like it'll be the only thing missing. -- Cheers, Guinevere Larsen She/Her/Hers