From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 125930 invoked by alias); 11 Nov 2016 00:51:03 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 125915 invoked by uid 89); 11 Nov 2016 00:51:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=rvalue, H*M:8066, site X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 11 Nov 2016 00:51:01 +0000 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9FE6C804E0; Fri, 11 Nov 2016 00:51:00 +0000 (UTC) Received: from [127.0.0.1] (ovpn03.gateway.prod.ext.phx2.redhat.com [10.5.9.3]) by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAB0ox4V007807; Thu, 10 Nov 2016 19:50:59 -0500 Subject: Re: [RFA 02/14] Change event code to use gdbpy_reference To: Tom Tromey , gdb-patches@sourceware.org References: <1478497656-11832-1-git-send-email-tom@tromey.com> <1478497656-11832-3-git-send-email-tom@tromey.com> <9bf85362-c850-75b4-de1b-f1cdd0df9101@redhat.com> From: Pedro Alves Message-ID: Date: Fri, 11 Nov 2016 00:51:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <9bf85362-c850-75b4-de1b-f1cdd0df9101@redhat.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-11/txt/msg00279.txt.bz2 On 11/11/2016 12:09 AM, Pedro Alves wrote: > On 11/07/2016 05:47 AM, Tom Tromey wrote: >> PyObject * >> create_breakpoint_event_object (PyObject *breakpoint_list, PyObject *first_bp) >> { >> - PyObject *breakpoint_event_obj = >> - create_stop_event_object (&breakpoint_event_object_type); >> + gdbpy_reference breakpoint_event_obj >> + (create_stop_event_object (&breakpoint_event_object_type)); >> > >> - fail: >> - Py_XDECREF (breakpoint_event_obj); >> - return NULL; >> + return breakpoint_event_obj.release (); >> } > > Wouldn't it better to make these create_foo functions return a > gdbpy_reference ? Then at the call site you'd use std::move instead > of reset (when assigning to an existing lval): > > stop_event_obj = std::move (create_breakpoint_event_object (list.get (), > first_bp)); Err, not even std::move would be necessary, of course, since the function's return would be an rvalue in this context already. So you'd just do: stop_event_obj = create_breakpoint_event_object (list.get (), first_bp)); That could be done after this series lands, in any case. > The advantage of following such a principle is that it makes it impossible > for callers to forget to manage the result with a gdbpy_reference, since > assigning the return to a raw PyObject * won't compile. Thanks, Pedro Alves