From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <simark@simark.ca>
Received: from simark.ca (simark.ca [158.69.221.121])
 by sourceware.org (Postfix) with ESMTPS id 66F073857C50
 for <gdb-patches@sourceware.org>; Thu, 20 Aug 2020 22:08:59 +0000 (GMT)
DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 66F073857C50
Authentication-Results: sourceware.org;
 dmarc=none (p=none dis=none) header.from=simark.ca
Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=simark@simark.ca
Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90])
 (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)
 key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256)
 (No client certificate requested)
 by simark.ca (Postfix) with ESMTPSA id BCF911E009;
 Thu, 20 Aug 2020 18:08:58 -0400 (EDT)
Subject: Re: [PATCH 2/4] Add amd64_windows_gregset_reg_offset
To: Jon Turney <jon.turney@dronecode.org.uk>, gdb-patches@sourceware.org
References: <20200812191816.23246-1-jon.turney@dronecode.org.uk>
 <20200812191816.23246-3-jon.turney@dronecode.org.uk>
From: Simon Marchi <simark@simark.ca>
Message-ID: <a533a44a-76b6-bd40-5b7b-23f75bfd774e@simark.ca>
Date: Thu, 20 Aug 2020 18:08:58 -0400
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.11.0
MIME-Version: 1.0
In-Reply-To: <20200812191816.23246-3-jon.turney@dronecode.org.uk>
Content-Type: text/plain; charset=utf-8
Content-Language: fr
Content-Transfer-Encoding: 7bit
X-Spam-Status: No, score=-4.5 required=5.0 tests=BAYES_00, KAM_DMARC_STATUS,
 NICE_REPLY_A, SPF_HELO_PASS, SPF_PASS,
 TXREP autolearn=ham autolearn_force=no version=3.4.2
X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on
 server2.sourceware.org
X-BeenThere: gdb-patches@sourceware.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Gdb-patches mailing list <gdb-patches.sourceware.org>
List-Unsubscribe: <https://sourceware.org/mailman/options/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=unsubscribe>
List-Archive: <https://sourceware.org/pipermail/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-request@sourceware.org?subject=help>
List-Subscribe: <https://sourceware.org/mailman/listinfo/gdb-patches>,
 <mailto:gdb-patches-request@sourceware.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Aug 2020 22:09:00 -0000

On 2020-08-12 3:18 p.m., Jon Turney wrote:
> Register a gregset_reg_offset array for Cygwin x86_64 core dump parsing
> (this causes the generic i386_iterate_over_regset_sections() '.reg'
> section iterator to get installed by i386_gdbarch_init()).
> 
> gdb/ChangeLog:
> 
> 2020-07-01  Jon Turney  <jon.turney@dronecode.org.uk>
> 
> 	* amd64-windows-tdep.c(amd64_windows_gregset_reg_offset): Add.
> 	(amd64_windows_init_abi_common): ... and register.

That looks reasonable.  I think i386_iterate_over_regset_sections should
be made static, if you want to make another (obvious I would say) patch.

Simon