From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.15.15]) by sourceware.org (Postfix) with ESMTPS id 5D9EF387701E for ; Thu, 19 Mar 2020 13:37:52 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5D9EF387701E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1584625069; bh=QhoPAgdVgQqY3DeR5ft7JEdmBppkZtoE9ATvK8NhaUs=; h=X-UI-Sender-Class:Subject:To:References:From:Date:In-Reply-To; b=EB1WBTxdIgIAdmCxl9KsIHXR9nY7hVY0mSgngDuFSR2fFDGufJj5r17H7QYpWp/yp kceMeJ+1labEWIqxDfY/KUHBN62FBZERFmqqQYXZU0gZ7Kpxzd36iHnhYCp1IruO+h dLImKY4h76i50lJkWJ9FDjJUnRQfsxES2BS9qkZc= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1Mk0JW-1jhdKs0qFs-00kQOw; Thu, 19 Mar 2020 14:37:49 +0100 Subject: Re: [PATCH] Avoid get_ptrace_pid() usage on NetBSD in x86-bsd-nat.c To: Simon Marchi , gdb-patches@sourceware.org References: <20200318161328.24088-1-n54@gmx.com> <6b3250d6-027d-46c7-2884-569d9a0aaa13@simark.ca> <3048d145-21f9-161c-f6fd-7214c7b13a48@gmx.com> <5b1b7e0a-3683-5e2b-a07f-9bf89817b4a2@simark.ca> From: Kamil Rytarowski Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Thu, 19 Mar 2020 14:36:35 +0100 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <5b1b7e0a-3683-5e2b-a07f-9bf89817b4a2@simark.ca> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="a51sG8MbwquADbMuCDFrTDqyqIuy33BGu" X-Provags-ID: V03:K1:mu3CbR8WfTHEnRPMyIxi66F2FpbsV4DypVTUHXsepdXmPQdKTvW EF6T5XwHkCQ9eJukGJtU9FDCOcqE174bwciVzNt2K1y1TjmgfHl8XDTV9UMgmSwRrKR3RBf 1roUd4PV98V2+wqG5I9qsV1cl9j50B+cBFUxkJ/8R7xfaMMqCtelJ7ooe45a72J3fYSu4c/ J9JRFrTzToY3LS2yWA1fQ== X-UI-Out-Filterresults: notjunk:1;V03:K0:z0W3PCE+nTE=:erEJbVH0u3oeafPeBXTbOo c/Y5f4XGtxH6LdYWFk6Mq/pMHjcDE7uXrv3HuI5YfaeymJPJX/3HiNwEExtNyTt0mjZrG59D3 CTz25q/+tg/VL4uSxkRUoSeKiPXN0uPlsbi1FF/7ykLLNaq45Bu/j9PGQA9D/7swW+ahWAiXo DPcsHGMrmGN5fWa+oMIlsuJ/egdL4dOj6HL4XHha0TXP/aX/gZaryEjmBYjN9i3U6XWuOr8A0 rGBYPEHTVcmpbA4xFksDmYmAug0PwDt6BTJhzx2XvvSR2Lc76YljC54y5sxJNJm4mMqqURzMY DmMxitYIoMqg8dLAfrcfayG/LXkpFnzkQaAc4vpsZ1mNWg1aPSGZPomkSZsDpYDm8eebEqgWc U6uLWdkWpiBoX1HbVIR3MuFTquhFCPjKKTwdDZKYbq9NnqjDexBzdeKJt43qDJzrmNi8Dgsju 1dLgHfoyG5u72kJjPs0/raRa6RM0RZjF/KzEUGCFQsro0pjcn87wYMUNdjI6UTP6u6gjtoXv5 YP/PSQPkRv/pX+QGoOoXmlipPYZ8r30L+/RkonlictVAebKCngLn56wNb1GBYnsKDx4HKBcmg E6t52IW7jTdr6FWjzu/uF/rhiTmaaO36RGTJ3SFaC66/WIjkiaxmuzzdu1i+eY8gFNdrTor0a HgVHKCXalXaSLH7NZYgseV4hO9daK9exhTf1aPqPk34YJSnDasD4amRRWa493vRKOZwXLKMbJ QNDtMaJOaj4bOLcqU2Wti3GRu3Ydi1zRG4E0j46I7/KgSfbNYqWnfDkmCxqZvxebsXIdWWuAn wN6L0ZzKAohvlKH0p/++UOJoOgvXDkkSwOBhLA5p8GnVT8atT/mLgH9QpqyQE/+jV6WF3CCbU HjMOQDZKJ3aRPxeqCJ0xDujDQTB97gZ25oR9UTcApV5mt62CTId5Amxvh6q5N6rUiB4qBh4be MBRP9541pAw+HfgCitIQr5t5F5xeUFVf16Lky/Njww8DKNyHMhUn4DIDuqtM/5Hc6SrfA2tAn YXMehREYnIHXRCvhsOyWsWTp7muEGvh/+2QeRccJyOM9C9cezD+hZ69pIntN+sIC2XkuDjZwJ bFRxNBxRdWOJmHnXoT8lpt7eBGK1F3Xq6WTafZQ+rn/srb+Cl7ZzT6QnqCVjPW+BXhVgG9xoO CavGv/7KmXZojjdptGEyfv/6VOannPn3IPGnTdFrQQzYYXH6IHvGd/dYNKeBSq+O6xAd0= X-Spam-Status: No, score=-0.4 required=5.0 tests=DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Mar 2020 13:37:53 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --a51sG8MbwquADbMuCDFrTDqyqIuy33BGu Content-Type: multipart/mixed; boundary="TalybJASQKyq2L7lnbUOstOQJFd5ddTVp"; protected-headers="v1" From: Kamil Rytarowski To: Simon Marchi , gdb-patches@sourceware.org Message-ID: Subject: Re: [PATCH] Avoid get_ptrace_pid() usage on NetBSD in x86-bsd-nat.c References: <20200318161328.24088-1-n54@gmx.com> <6b3250d6-027d-46c7-2884-569d9a0aaa13@simark.ca> <3048d145-21f9-161c-f6fd-7214c7b13a48@gmx.com> <5b1b7e0a-3683-5e2b-a07f-9bf89817b4a2@simark.ca> In-Reply-To: <5b1b7e0a-3683-5e2b-a07f-9bf89817b4a2@simark.ca> --TalybJASQKyq2L7lnbUOstOQJFd5ddTVp Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 19.03.2020 14:22, Simon Marchi wrote: > On 2020-03-19 8:47 a.m., Kamil Rytarowski wrote: >> This is a good idea.. however it is intrusive now and requires patchin= g >> code shared with windows, linux, darwin, ... >> >> I prefer to leave it for refactoring in future. I don't have environme= nt >> to test other Operating Systems than NetBSD. >=20 > Hmm no, the callers of x86bsd_dr_set are only in this file (x86bsd_dr_s= et_control and > x86bsd_dr_set_addr). They would now look like this: >=20 > static void > x86bsd_dr_set_control (unsigned long control) > { > x86bsd_dr_set (inferior_ptid, 7, control); > } >=20 > static void > x86bsd_dr_set_addr (int regnum, CORE_ADDR addr) > { > gdb_assert (regnum >=3D 0 && regnum <=3D 4); >=20 > x86bsd_dr_set (inferior_ptid, regnum, addr); > } >=20 > Adding a ptid parameter to x86bsd_dr_set_control and x86bsd_dr_set_addr= would be the > next logical step, but that indeed would be a more intrusive change, so= I don't suggest > doing that right now. >=20 Done in v4. > Simon >=20 --TalybJASQKyq2L7lnbUOstOQJFd5ddTVp-- --a51sG8MbwquADbMuCDFrTDqyqIuy33BGu Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl5zdWMACgkQS7MI6bAu dmwl5g/+N2Fj6HJsHfhto/G4Fx2YuVS4YxAw+/RbW7OTx2AYihvB3GTcEXpPn9kp GxrBYs/SDi33unif7NDa607Ro4aSc8X3wsWhhuWSl3Kd1PyFPiS5g5TYnykGqfc3 RmysOtuStDz6T0N6BhUGVDqiuTaqvlS923kqsctsUrxtx774CmjbiCz6oMoHZEtQ XADZUznbAmpzxbbigmiVQ40jidAe0CYrB3jxKKaZkueLMDwjXQUX6l3eHE//cQT4 flwZf+JsT0uC1SjpN5X+0JpDSCuq5p24szOSMUwIfd9C1mnoggtEWqeqWEYhToET Y/WOok7sFCy6qjmOn0ZzUMUMS0mXZvLW0QF8zx6UjW6i6SpVzhrDtyVHAfwAN/mc kUaWlCiLxvKraS+OKB3CUa6yMNUyLsb92xv8Ufn9NcslRK6pYqLmRguuFh5WrJVQ gZzXROlZmMRwuV6K0pJvfUzGl+78yqYPyySkWiPYyyo8L+vECY1hdGO7XCy+yNJG qHY8gn2ofqjYp7kEvXrNCZnTq0YqwDp8nUqU64NVRyrZgxKQyf9xc/uYEN9vC2qk PbE/ZSC0WcOXo/rr4VmP4ya7gEbDFG3CVHVXkMf3mD9pWeMRo8kmyr4k5z/gfIma hu8oRhM09pYZoZhcuGA//45Bbxiilo9rg4Yz1HyAltLN5qhxRk4= =DtxV -----END PGP SIGNATURE----- --a51sG8MbwquADbMuCDFrTDqyqIuy33BGu--