From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 91777 invoked by alias); 15 Sep 2017 13:07:42 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 91059 invoked by uid 89); 15 Sep 2017 13:07:42 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.4 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=research X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 15 Sep 2017 13:07:39 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id v8FD7XXo019201 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Fri, 15 Sep 2017 09:07:38 -0400 Received: by simark.ca (Postfix, from userid 112) id 1D8D41ECF0; Fri, 15 Sep 2017 09:07:33 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id 61ADA1E5B9; Fri, 15 Sep 2017 09:07:32 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Fri, 15 Sep 2017 13:07:00 -0000 From: Simon Marchi To: Pedro Alves Cc: Simon Marchi , gdb-patches@sourceware.org Subject: Re: [PATCH 2/3] gdbserver: Remove gdb_id_to_thread_id In-Reply-To: References: <1505074275-1662-1-git-send-email-simon.marchi@ericsson.com> <1505074275-1662-3-git-send-email-simon.marchi@ericsson.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.0 X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Fri, 15 Sep 2017 13:07:33 +0000 X-IsSubscribed: yes X-SW-Source: 2017-09/txt/msg00405.txt.bz2 On 2017-09-15 12:55, Pedro Alves wrote: > On 09/10/2017 09:11 PM, Simon Marchi wrote: >> From what I understand, this function is not doing anything useful as >> of >> today. >> >> Here's the result of my archeological research: >> > > *nod* > >> --- a/gdb/gdbserver/server.c >> +++ b/gdb/gdbserver/server.c >> @@ -4011,7 +4011,6 @@ process_serial_event (void) >> unsigned int len; >> int res; >> CORE_ADDR mem_addr; >> - int pid; >> unsigned char sig; >> int packet_len; >> int new_packet_len = -1; >> @@ -4039,92 +4038,96 @@ process_serial_event (void) >> handle_general_set (own_buf); >> break; >> case 'D': >> - require_running (own_buf); >> + { >> + require_running (own_buf); >> > > The reindentation makes it hard to see the actual > change. Is it just moving the int pid variable, or something else? > IMO, it'd be nicer to move the whole case 'D' body to a > handle_detach function. Agreed, I'll do a preparatory patch that does that, and then a second version of this one (also taking into account all your other comments). Thanks, Simon