From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id ZtDhHFpG6mjpdCkAWB0awg (envelope-from ) for ; Sat, 11 Oct 2025 07:58:18 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XB86+h+W; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 695C41E047; Sat, 11 Oct 2025 07:58:18 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id F1C291E047 for ; Sat, 11 Oct 2025 07:58:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8063C3857B9E for ; Sat, 11 Oct 2025 11:58:17 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 8063C3857B9E Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20230601 header.b=XB86+h+W Received: from mail-wm1-x333.google.com (mail-wm1-x333.google.com [IPv6:2a00:1450:4864:20::333]) by sourceware.org (Postfix) with ESMTPS id 94894385843F for ; Sat, 11 Oct 2025 11:57:34 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 94894385843F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 94894385843F Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::333 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760183854; cv=none; b=RmPFVCiWorUwlb46Y8aaeuVZCPhmxDyJnc/7UdLiXv0VcLIMWjyGZCgN4tvbXMPRmhXaXkgkqtA0O1Z6Ayv95IEbZvUb+WH3TDuwFXyMQgOwjgTtEyiOHfcJB9MKHh5WUDf+E6MF55Xm+2ywBXwYlxW8sUV4RDi+qj42GCXfNWk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1760183854; c=relaxed/simple; bh=tKgP8KIEOQeYurm/1YTrQtgP6UmG1DEwuOP9mGBtTfw=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Rq4TgFk4W8g9jasd/2Jeb291s7y3tYvQzAEeLKSUFVmYEsDHb+u3wabbhs52z57PCbZNfPknQWd+6eprBfMXnmHRT832Dbzg6k4kHPqWuQuElZF9W21wturY93TQ9Y008XHHO4Z4r0o1r79xP0osXWWvpCrnaMJ0t5883JI6W7A= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 94894385843F Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-46b303f7469so17563845e9.1 for ; Sat, 11 Oct 2025 04:57:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1760183853; x=1760788653; darn=sourceware.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=xlInt5/59tzeRsnqkcLEimzTofp5TY+hhcx89NgDXI0=; b=XB86+h+WLxqd47mc23YbUgP79i50ynauGOYf7b/GDnMbDm6U1M5G9ZdWlG92lwRVs3 zsOhXJM76BWwh3xhGsj7eRKOON0m82s436s7yMz1aI6c+zmLvpLxWQ1ivIuAbVoqOVd1 kiRHiZ84B2Z7bqaljtIarrXwfmXmWmiHarJ6Tv2rsIbxkTY9uzW/vC90zx8FREgJcGCB jD3hd/XdiQVyUqFM445BsrVeCAygNt+kHrDHVkxEExA0PfqnWoIL2xOPNmbwheg1Sbmr 3OyiTRtPzVp7Plw7dKQKLuXefET+RcZkUOH3BCRDz7Txos1L7yCmurjWGUc1rADdBgKo vKIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1760183853; x=1760788653; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xlInt5/59tzeRsnqkcLEimzTofp5TY+hhcx89NgDXI0=; b=Oamd/0GMEA/IR1ue66r86JE9W+YK7b/VUzgSAmDgBjs520d7J8hv8nCN8AX1hT2cBl L8Xy/tOrD+CZONfnzdrFGwMdsk/F73roxpHQeBS8dnpGajNcuEXtVbW3AxGQGDV9jtM8 jeSqQ9+MExJWFqPO5n4uYAuynharDo2UAsu5z8Bc9Aq1/RRT/2GMah2uEr/fPbkuy5vk 6DC09UrMGEaLKJr0yxbActZILBS1cs/cBUTfdLDC+d8CHCNUi+z6wtBDpNwqLIwipNqd e71N97QSvu5wVdoC63f1PVnY4Yk1kmVZofmlArUUunt+c4zVaHNi33pO4nwgQD9MtsJa GPJA== X-Forwarded-Encrypted: i=1; AJvYcCXnlu5Y4/aHpq1lJE6Y83j9w+IlzCmOUN8WXXRe7Qh6YuWd951BPNzhW49nH1UD6f1Ge09b+Y1MTCFoDg==@sourceware.org X-Gm-Message-State: AOJu0YwNRtdCXZQTPtE42u4sGhqQPn2cZ1tqgEtD2yNpevomsdmgtSSk j+aqxkdgQSC06oB4cGmGCtkQVMJacrAuWsfLsNEiZ825XAOJI7dOepTu7QyEsw== X-Gm-Gg: ASbGncuamH85gJFYucT6OrjgySQsYBLz9TXs9NZp8FPLRag1qHIw2I5BYQu1KWJLd0K uOSDoAg1pjUWqH5QqAjekiuc2/n0SrUGVSjekdtwqKTLOjMZ5yJjhdad6F4C+wHGHd2c2cSNGmM 3RNf4xImr+zntSwH8LfSavd1mjMk51T/1sPk13yFaKvvAd00oflSTHUyhHy+febw1JXUlZk+LCJ tBzPuiQLrdcUzJID0le+NYRW4n8lPglbc3TgtMsE+HCKmstbWvc+ZX3/L1xanRBsGAemZAxmxQA ztfCQu5+1JlrC4qySsVLF7fUPPQjqPmLGgUNeS+jkmdcB0KQpwM9FIrKeb/X41Kt3X4a9cZy6pu PacI04+mJgc/du6WohGECyZGG9vSavvAv6Tu2uYpsR6ogWu2X9b/g5goEZodIhZZp X-Google-Smtp-Source: AGHT+IFAZKsk/S6/HEJtmlBItRGIiJWIuF1K/TzM3tFL8ho+RhQw7Mz0119rKCZyBkY3Ab+7Dtu+uQ== X-Received: by 2002:a05:600c:4687:b0:45d:e5ff:e38c with SMTP id 5b1f17b1804b1-46fa9b02000mr112742265e9.32.1760183853164; Sat, 11 Oct 2025 04:57:33 -0700 (PDT) Received: from [192.168.0.38] ([86.12.216.189]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-426ce5e0987sm8576284f8f.38.2025.10.11.04.57.32 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 11 Oct 2025 04:57:32 -0700 (PDT) Message-ID: Date: Sat, 11 Oct 2025 12:57:31 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 3/5] gdb/aarch64: signal frame support for fpmr Content-Language: en-US To: Ezra.Sitorus@arm.com, gdb-patches@sourceware.org Cc: thiago.bauermann@linaro.org References: <20251007123132.26769-1-Ezra.Sitorus@arm.com> <20251007123132.26769-4-Ezra.Sitorus@arm.com> From: Luis In-Reply-To: <20251007123132.26769-4-Ezra.Sitorus@arm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 07/10/2025 13:31, Ezra.Sitorus@arm.com wrote: > From: Ezra Sitorus > > Add support for FPMR in signal frames and restore contents of FPMR. > --- > Changes from v1->v2: > * Addressed comments/whitespace/formatting issues > > Ezra > > gdb/aarch64-linux-tdep.c | 34 ++++++++++++++++++++++++++++++++++ > 1 file changed, 34 insertions(+) > > diff --git a/gdb/aarch64-linux-tdep.c b/gdb/aarch64-linux-tdep.c > index 10b44d978af..e905be40a8d 100644 > --- a/gdb/aarch64-linux-tdep.c > +++ b/gdb/aarch64-linux-tdep.c > @@ -167,6 +167,7 @@ > #define AARCH64_TPIDR2_MAGIC 0x54504902 > #define AARCH64_ZT_MAGIC 0x5a544e01 > #define AARCH64_GCS_MAGIC 0x47435300 > +#define AARCH64_FPMR_MAGIC 0x46504d52 > > /* Defines for the extra_context that follows an AARCH64_EXTRA_MAGIC. */ > #define AARCH64_EXTRA_DATAP_OFFSET 8 > @@ -213,6 +214,9 @@ > /* features_enabled value offset in the GCS signal frame context. */ > #define AARCH64_GCS_CONTEXT_FEATURES_ENABLED_OFFSET 16 > > +/* FPMR constants. */ Formatting. Two spaces after period. > +#define AARCH64_FPMR_OFFSET 8 > + > /* Holds information about the signal frame. */ > struct aarch64_linux_sigframe > { > @@ -260,6 +264,12 @@ struct aarch64_linux_sigframe > uint64_t gcspr; > /* Flags indicating which GCS features are enabled for the thread. */ > uint64_t gcs_features_enabled; > + > + /* True if we have an FPMR entry in the signal context, false otherwise. */ > + bool fpmr_available = false; > + /* The Floating Point Mode Register. */ > + CORE_ADDR fpmr = 0; > + > }; > > /* Read an aarch64_ctx, returning the magic value, and setting *SIZE to the > @@ -576,6 +586,22 @@ aarch64_linux_read_signal_frame_info (const frame_info_ptr &this_frame, > section += size; > break; > } > + case AARCH64_FPMR_MAGIC: > + { > + gdb_byte buf[8]; > + if (target_read_memory (section + AARCH64_FPMR_OFFSET, > + buf, 8) != 0) > + { > + warning (_("Failed to read the FPMR section address from the" > + " signal frame context.")); > + section += size; > + break; > + } > + signal_frame.fpmr = extract_unsigned_integer (buf, 8, byte_order); > + signal_frame.fpmr_available = true; > + section += size; > + break; > + } > case AARCH64_EXTRA_MAGIC: > { > /* Extra is always the last valid section in reserved and points to > @@ -739,6 +765,13 @@ aarch64_linux_sigframe_init (const struct tramp_frame *self, > } > } > > + /* Handle FPMR. */ > + if (tdep->has_fpmr () && signal_frame.fpmr_available != 0) > + { > + trad_frame_set_reg_value (this_cache, tdep->fpmr_regnum, > + signal_frame.fpmr); > + } > + > /* Restore the tpidr2 register, if the target supports it and if there is > an entry for it. */ > if (signal_frame.tpidr2_section != 0 && tdep->has_tls () > @@ -791,6 +824,7 @@ aarch64_linux_sigframe_prev_arch (const frame_info_ptr &this_frame, > aarch64_features features = aarch64_features_from_target_desc (tdesc); > features.vq = sve_vq_from_vl (signal_frame.vl); > features.svq = (uint8_t) sve_vq_from_vl (signal_frame.svl); > + features.fpmr = signal_frame.fpmr_available; > > struct gdbarch_info info; > info.bfd_arch_info = bfd_lookup_arch (bfd_arch_aarch64, bfd_mach_aarch64); Otherwise looks good to me with the nit fixed. Approved-By: Luis Machado