Re: Propose we release GDB 9.1 next weekend (Feb 01-02)

Joel Brobecker
2020-02-01T13:06:41Z

> > I haven't reviewed the patch super carefully, but I like the idea!
> >
> > For the release, it's indeed a bit on the fence. Given the nature of
> > the patch, With a bit of careful review, we should be able to convince
> > ourselves that this patch is sufficiently safe, particularly for a .1.
> > On the other hand, I think the patch that triggered the regression is
> > a fairly minor enhancement (name of the file printed by annotations).
> > So perhaps the best way forward is to revert the triggering patch
> > from the gdb-9-branch.
> >
> > I've added Tom to way in on this...
>
> Tom If you decide to revert (which would be my preference) I will
> happily work with you to get this back in. I previously wrote a
> testcase for the simple case that did already get fixed, I can work on
> a testcase for the new case too for the suite if it helps.
> https://sourceware.org/ml/gdb-patches/2019-08/msg00421.html

FWIW, in terms of reverting, I was only thinking of reverting
in the gdb-9-branch. It's possible we might decide to revert
in master as well, but, at the moment, it's looking like we have
a decent chance of fixing the issue in master withing a reasonable
time frame. So I'm not advocating for a revert in master just yet.
Open to people's thoughts, though, as always!

--
Joel