From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6IVVDvnVwGqgFy8AWB0awg (envelope-from ) for ; Sat, 03 Oct 2026 06:16:25 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=bM4xD87n; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 153CF1E050; Sat, 03 Oct 2026 06:16:25 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C94471E04E for ; Sat, 03 Oct 2026 06:16:22 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 2BA744BA902B for ; Sat, 3 Oct 2026 10:16:22 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2BA744BA902B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=bM4xD87n Received: from mail-wr1-x434.google.com (mail-wr1-x434.google.com [IPv6:2a00:1450:4864:20::434]) by sourceware.org (Postfix) with ESMTPS id 7998C4BA79A9 for ; Sat, 3 Oct 2026 10:15:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7998C4BA79A9 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7998C4BA79A9 Authentication-Results: sourceware.org; arc=none smtp.remote-ip=2a00:1450:4864:20::434 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791022556; cv=none; b=pfVJIt+lDdEASrLd4I/8XVTagcxmMEIbm1nu1fOGKFcXryOwClDR0XXlf3MOomYQ9tEnFlSfIZzqFyYbEjJ/ofxwSqi3Z/rfyYAicIZiaepoqRDAReWNktG56/KCP6tZvOMIB5ApU8H97i4kyU/1HC36RoeLWFlm3QEc4+xAvXE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1791022556; c=relaxed/simple; bh=i0SDUeKBkTNrWTTXAVLpkNw5lSPijR8zdR+8+6UaK/4=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=TgrXFNVoCjNxXjuMyohZ9vYdnWJvikvr1MKYNfTycRG1eki32bsVSB2eA3NGLTiPPOF3b34si+ZhH+y8ITeSuG82/fqFNitc5tAwGbWZ/OkVuSKHz2kWFHSls57lMnyyzFm+ay9lfX/gfFesy0/R7XE+SjZJ5nn6y1BBwNf1z/0= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=bM4xD87n DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7998C4BA79A9 Received: by mail-wr1-x434.google.com with SMTP id ffacd0b85a97d-48afcfc4bf5so210687f8f.1 for ; Sat, 03 Oct 2026 03:15:56 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1791022555; x=1791627355; darn=sourceware.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=PCuo7xdsyhyAOGMYPgwVENM4sgRmukBmhyKUiTttRtw=; b=bM4xD87nsAvqsKpiUdDoQeqaQ/dlazvYU3X+YQRTGHr2rRFdNsrqeN3dInIedDg5it dC/yD5X3PZKO8BU10vZXr4R1n/8U49W7Ed7UtZvu6WclfnTSsutuKaKC2Bx6vzB6LUQj ooW4qIWhreXqs0ePcLRZxukal7Y78h7Qq5s8KYDy4h8uR478XnuE+tPRmU09jV96ickJ 8gncOzvrBWWQWAl9ppbh/QCUwn0GX+UEo2qfLBcmpuVK8Ac3JHD6G8+yKDZMAHs40bpt L1h6u5/XBdgDGwZg6vdIRtYtr0D6Ke44fKAljoV+0f7PRGheKHYsQEAX5X65xJ49732h Sv2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1791022555; x=1791627355; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=PCuo7xdsyhyAOGMYPgwVENM4sgRmukBmhyKUiTttRtw=; b=OAVIGB6PwMWCLj7YL6zXtVQlrAF7UgCBi3hZaoz5K1F++H4vPncBZaoixGok9ohbWc YDrOVJbVyxRIFRJdPxpCKzbz1LOzIvWoWmx7+B7uozBEwqH6j9R619PWW60Go+SLYkQ/ h6YZ5FyvD5ryKvrKgBKo2htL4KCpRD9gaWsuS1FLAb1y6eicgfuKyC4vPsq5CB9Rsk9o gzmozAZT+iV8KQmrVEloeKGEKzDR+NL9w+CQ/PwwMMJGw7bAukqspiZw45+JbxtntM5M SR3QanJmUNteJn0WTyL3BE2fSCEIH1cz4YtNlNWruyC/LAaOR7SCOJ4xZ1koFyeR57Rs 2FNg== X-Forwarded-Encrypted: i=1; AKwUvByEd7K9hurxsdeLGVEr/hM7s8+CavU2i+t6pPot7WrPGs0PLmCYoToshBNQbxYdQk9u3OVcQIikDAlK/g==@sourceware.org X-Gm-Message-State: AFq9FYJb/rN4qN5I/pTOJvRxHyqwe8rEmYjUH+LNmwRhc53AQF2HV3jb xhiuABcQJM2b8Ut3LQyYix1/Zc2aGSIYuF/gAqBFFug2Uo7EMhOtccPl X-Gm-Gg: AYBFou3t9HKC9X9Sod/mUrfUbUCta7pN23AiUgvCoVwrwZvWymnc7zsuNw8VehMMXIm GfqhzfEP0621ZdJ3p7A0yj8K2/+RQSeJ7PfauP4syNXFOuU8qUKBS2A8IECNGcR/2LtCCw4YdHd GeJaKc7TiKYYraXplJPLqFwe1r6lSKSfhZ09enN+xVt8wixbsvXFBP7+VFsx98fp7X2WVH5a0Mv xguo8ojm1UpXuf8NevKhJPA+lZguIneQqPxCBfKnsz1eY37z21/GSsu5FJqbUtet/2vA58a8U3M AdUaQALBEgmcm8iWSCDbjwvFuqhDo4wGzqpaYMi193oYtF7lNjVeafL/Pi2cz2DPs5rVHNgQdjs zONAZkcMeiRzjo6VT1IW9Zo0sXdgH55Kf+NjgS5tCKa0h0ezboUMyroMf0UKSq78QV+ioXumMzt 3Pk4HFgE1TuWONv5Ydh2b3hFH99/dqjOCZeEKxuTkjON97zF8hfilHf4iF5ifW3MO9kXL6cJB2P wu2i15EuQ== X-Received: by 2002:a05:6000:381:b0:487:c99:9020 with SMTP id ffacd0b85a97d-48c47c8dc17mr3070991f8f.2.1791022555112; Sat, 03 Oct 2026 03:15:55 -0700 (PDT) Received: from [192.168.0.39] ([86.12.57.161]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-48b380f0613sm12894252f8f.13.2026.10.03.03.15.54 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 03 Oct 2026 03:15:54 -0700 (PDT) Message-ID: Date: Sat, 3 Oct 2026 11:15:53 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v5 1/5] gdb/aarch64: Add POR_EL0 register support for FEAT_S1POE To: Srinath Parvathaneni , Thiago Jung Bauermann , "gdb-patches@sourceware.org" , Eli Zaretskii Cc: Ezra Sitorus , Matthieu Longo , "peter.maydell@linaro.org" References: <20260916091803.110110-1-srinath.parvathaneni@arm.com> <20260916091803.110110-2-srinath.parvathaneni@arm.com> <87ik43qib4.fsf@linaro.org> Content-Language: en-US From: Luis In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 22/09/2026 18:31, Srinath Parvathaneni wrote: > Ping !! > ------------------------------------------------------------------------ > *From:* Srinath Parvathaneni > *Sent:* 18 September 2026 17:47 > *To:* Thiago Jung Bauermann ; gdb- > patches@sourceware.org ; Eli Zaretskii > > *Cc:* simark@simark.ca ; luis.machado.foss@gmail.com > ; guinevere@redhat.com > ; Ezra Sitorus ; Matthieu > Longo ; peter.maydell@linaro.org > > *Subject:* Re: [PATCH v5 1/5] gdb/aarch64: Add POR_EL0 register support > for FEAT_S1POE > Hi, > >_______________________________________ > >From: Thiago Jung Bauermann > >Sent: 18 September 2026 05:45 > >To: Srinath Parvathaneni > >Cc: gdb-patches@sourceware.org ; > simark@simark.ca ; luis.machado.foss@gmail.com > ; guinevere@redhat.com > ; Ezra Sitorus ; Matthieu > Longo ; peter.maydell@linaro.org > > >Subject: Re: [PATCH v5 1/5] gdb/aarch64: Add POR_EL0 register support > for FEAT_S1POE > > > >Hello Srinath, > > > > writes: > > > >> From: Srinath Parvathaneni > >> > >> Add support for the FEAT_S1POE POR_EL0 register on AArch64. > >> > >> This patch adds POR_EL0 to the AArch64 register set and reads/writes it > >> using the NT_ARM_POE ptrace regset. > ... > >>  gdb/features/Makefile        |   1 + > >>  gdb/features/aarch64-poe.c   |  14 ++ > >>  gdb/features/aarch64-poe.xml |  11 ++ > >>  gdb/nat/aarch64-poe-linux.h  |  30 ++++ > >>  11 files changed, 450 insertions(+), 1 deletion(-) > >>  create mode 100644 gdb/features/aarch64-poe.c > >>  create mode 100644 gdb/features/aarch64-poe.xml > >>  create mode 100644 gdb/nat/aarch64-poe-linux.h > > > >Thank you for addressing the review comments and adding the > >documentation section. > > > >There are just a few nits below, but with them fixed: > > > >Approved-by: Thiago Jung Bauermann > > > >Except for the gdb.texinfo part, which needs to be approved by Eli. > > Thanks Thiago, for the reviews and approval. > > Hi Eli, could you please review the documentation for this patch series, > thanks. > > Regards, > Srinath Here's some feedback on the docs: 1. Typo: "feild" should be "field". 2. The patch hunk ends with the context line "For more information about @acronym{FPMR}...". That sentence belongs to the FPMR section. Your new @subsubsection sits above it, so the FPMR reference would now land at the end of the POE section. Check that the new section goes after that paragraph, not before it. 3. Wording of the first paragraph: - "debugging the AArch64 architecture" reads oddly. "debugging an AArch64 target" is more usual. - Drop the "then" in "is available, then @value{GDBN} will". - "when displayed using" is a dangling modifier. Try "interprets the permissions of each field in @code{por_el0} when displaying it with the @code{info registers} command." 4. Examples: - Column alignment is inconsistent. por_el0 0x00...07 [ P0=rwx ] uses single spaces, while por_p1 0x7 rwx is padded like real info registers output. Use the same style in both. - The last @smallexample shows info registers por with no output. Either show the output, or fold the command into the prose and drop the block. 5. Markup: - Use @samp{por} or @code{por} when you name the group, so it's clear it's a literal group name. - You could also write @code{set $por_p1 = 0x7} inline in the prose, but the examples are fine as they are. With those fixed, this is OK. Approved-By: Luis Machado