From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 101326 invoked by alias); 16 Oct 2017 15:03:41 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 101006 invoked by uid 89); 16 Oct 2017 15:03:40 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.8 required=5.0 tests=AWL,BAYES_00,SPF_PASS autolearn=ham version=3.3.2 spammy=Awesome, curiosity, hacked X-HELO: sesbmg22.ericsson.net Received: from sesbmg22.ericsson.net (HELO sesbmg22.ericsson.net) (193.180.251.48) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 16 Oct 2017 15:03:34 +0000 Received: from ESESSHC023.ericsson.se (Unknown_Domain [153.88.183.87]) by sesbmg22.ericsson.net (Symantec Mail Security) with SMTP id AA.B6.07039.34AC4E95; Mon, 16 Oct 2017 17:03:31 +0200 (CEST) Received: from EUR02-AM5-obe.outbound.protection.outlook.com (153.88.183.145) by oa.msg.ericsson.com (153.88.183.87) with Microsoft SMTP Server (TLS) id 14.3.352.0; Mon, 16 Oct 2017 17:03:30 +0200 Received: from [142.133.49.59] (192.75.88.130) by DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.77.5; Mon, 16 Oct 2017 15:03:29 +0000 Subject: Re: [PATCH 1/2] Fix "list ambiguous_variable" To: Pedro Alves , Keith Seitz , References: <1504550858-27936-1-git-send-email-palves@redhat.com> <1504550858-27936-2-git-send-email-palves@redhat.com> <49a8a021-3d9f-c5f1-9cc4-dae1f32c7d01@redhat.com> From: Simon Marchi Message-ID: Date: Mon, 16 Oct 2017 15:03:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <49a8a021-3d9f-c5f1-9cc4-dae1f32c7d01@redhat.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-ClientProxiedBy: DM5PR19CA0009.namprd19.prod.outlook.com (2603:10b6:3:151::19) To DB4PR07MB313.eurprd07.prod.outlook.com (2a01:111:e400:982f::13) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: a8c30653-c2c9-4e8d-989b-08d514a70fcb X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001)(2017030254152)(2017052603219)(201703131423075)(201703031133081)(201702281549075);SRVR:DB4PR07MB313; X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;3:cPlhV0l0nQ44DzJ3FdwdZitQPMuJ0s4KS/Zvpj48aJ5JIDH1nFXkSH/sDhWLOOFhe86UrM73iOp4uY73UX0Inr7Uzs+nzoQ863Iv1F0i+RTclF1hqSXRPaCyJTjCL835/7tA44PQ3YpAHgDszAIGfPVjMQSpfH7rsYpJ0nh1uwFht+ZlkwXK3IlOdJpqiFAuf2yghm0O1bHTRQfjSzKkPseGcnsa7Aeoy2lQeKjTR60ITm3cFGqctdYZ5PQej84G;25:R+bKLPyDW5H3/lKijzQSxbxWiYAeE3IX8LQNcYJeC7M6kc25jSuLL73i9+2fBmjLZJ+/M3smAt1guDp0cFp37oPYB7cKJdhfsXW2fUBym23LpKGNoQTa3kn/Mv1ZzbkJnWwNNknX8+HmImaHNKbfmcDmDmW2tOnWYqy3Et94gOA+I8eFxFX+sABU17TzgJv8yDPNCiBN7HQN9tTpHGGv3oRezKNQe5dyIfnYL55Gf6L92kfshrUY1AeHr1aQbylSjfxY6zegeg+YLC8PVllc/d5VZtr/1YnsT9IhnpjquU8J+iFRFk7rE7iJoE0sdiJKfuQ1iKLHrK4V5SyixwEiTA==;31:cXxvQeJPXTy+yQeQTjJbgg4/NmZ5Sy6yPZj+auDPnVSJUYSfXFkEEjQ7T6dcbUMBZRwOYyG+1OZO8sqyK/27zadSpmxCcaEUd0AsKXOmgcTI3xMwUg2TGg7rTrIym3Q5aNiTHvfIYb9kFH+aSGrs4VqpE+sisggRhBwPwOmgcPsp3rvyTz20vkMP6FIN0tT+Q72curZDlqC+byaD7vMG5/pwIjX0WhVPkvHQTjH4Kqo= X-MS-TrafficTypeDiagnostic: DB4PR07MB313: X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;20:HfYoWzQXhxuW4WoLcLVi82upxju/QvOKK+wpor8LpKchX/kxlq97saBSfcn3JQRv8GZZ+yqptzDdV6ZKD4M5R0tAVP+JNfNGIXSTl28X1luCMe59wtErxyyNahcA1+ImIH5YzFJSVe8iXqCr/su4yZN6cb7sm8UUx4DbckeEEzj3x7pOnJ6djveOgCkYYDOpf6zigz+c0ygcYXpP+lurAoKFFudePawUkGo2lnCD2UGf8C21JzmUaUCNRJKL2dsyufD/X4RjBnntNzRReWq6jEdHLdYlDx1lhPEV8jyznxAwjZ8FcQpDBsoYbpflw61U3aVO0D01FRFZaMrwnB94tPM0q0X6T0FZoAd3ueNtr0KmTCWd7kJ+L5Ej2lWnjfevUiRpEGfKiPpHfix3C+MXJG9Xn/3tyBzNzuHrBT3c9DZrh6oZ7VBi1C0Ty3rLb4I/50+DRxZxugCcdTP0rR6/3kLPB5+JMLSEHHVsOkggLt7VqVhaSEqhKmqksg+t4FEE;4:ha1akuPCvIJfPpwa7zZVBqYP+hMreEa5J43amVNXMSUKmcnuP6BLDHJdxFtkf3WRKwCUEKMdsr8WNotKTYTmp2RQ0Kj50I1LkRI7yMQ7nm/A61vgP7opWfeUACdXTpRatGFbXS9LMJ/zEd3okR89DyKiFjPVcVZyK6VLVccxzUGb9851tZi6VRC0CLB+2cZCgN/yxy9eTpmVV36Dw2jh/INCFnlESiPi+XtgdCG0ALmHiKwSLWFzxqprPD3CU0tA X-Exchange-Antispam-Report-Test: UriScan:; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(100000700101)(100105000095)(100000701101)(100105300095)(100000702101)(100105100095)(6040450)(2401047)(8121501046)(5005006)(93006095)(93001095)(10201501046)(100000703101)(100105400095)(3002001)(6041248)(20161123564025)(20161123558100)(20161123555025)(20161123562025)(20161123560025)(201703131423075)(201702281528075)(201703061421075)(201703061406153)(6072148)(201708071742011)(100000704101)(100105200095)(100000705101)(100105500095);SRVR:DB4PR07MB313;BCL:0;PCL:0;RULEID:(100000800101)(100110000095)(100000801101)(100110300095)(100000802101)(100110100095)(100000803101)(100110400095)(100000804101)(100110200095)(100000805101)(100110500095);SRVR:DB4PR07MB313; X-Forefront-PRVS: 0462918D61 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(39860400002)(346002)(376002)(377454003)(189002)(51914003)(24454002)(199003)(377424004)(101416001)(54356999)(76176999)(50986999)(53546010)(53936002)(65826007)(36756003)(47776003)(5660300001)(65806001)(8676002)(65956001)(478600001)(66066001)(305945005)(7736002)(86362001)(31686004)(16576012)(49976008)(110136005)(31696002)(3846002)(6116002)(6666003)(316002)(97736004)(58126008)(6246003)(8936002)(83506001)(2950100002)(50466002)(106356001)(230700001)(2906002)(23676002)(105586002)(93886005)(68736007)(229853002)(16526018)(6486002)(189998001)(33646002)(81166006)(81156014)(25786009)(64126003)(78286006);DIR:OUT;SFP:1101;SCL:1;SRVR:DB4PR07MB313;H:[142.133.49.59];FPR:;SPF:None;PTR:InfoNoRecords;MX:1;A:1;LANG:en; Received-SPF: None (protection.outlook.com: ericsson.com does not designate permitted sender hosts) Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=simon.marchi@ericsson.com; X-Microsoft-Exchange-Diagnostics: =?utf-8?B?MTtEQjRQUjA3TUIzMTM7MjM6UDJLZUVhekw4Z05TUlNYaEZCTnlaaUFFSXg4?= =?utf-8?B?aktqanluc2h6NDNkWWRWelNlU1lCMDEzeDRqeDlhdnFwOUNTdXR6MlpTQUtm?= =?utf-8?B?Qy9wOFhTVjM2SmNFVWNZUXJQRUlrYUtkQWRmWWNXTVladTFHNlIzOXlpQWow?= =?utf-8?B?QU1pYmtVS2lUdFJXZEtwRmNLKzVNZHRNNFhiVkF5WkcvQmFxYXE0R01DMXUw?= =?utf-8?B?UUhJTm03WjNGVU9NSGQ0N0x4MkQ1dFZibFZ6WXRJOUNEM3E5amMzNkpzQ2oz?= =?utf-8?B?VlFHM3VSNjFkNDNjczd2YVhkMEJlN0lZWnlrNTRIaHhGZEI0eGxNWmtoL0dD?= =?utf-8?B?OVplVElBNXVmdXUvUTZiL1NHN05ncEZsQkh2dEwvVGtBalYzZ0lBK09LWFRs?= =?utf-8?B?eXh4Y1hWMzZDNEpoaFgrdDFEeXErTVd1UDdPbmV0eE1BdnpRMUFpYjk1d24r?= =?utf-8?B?eWwxVVhvbm1zOFVZQU1raStrRDVPNVYzMTNWUEowd3V3ZG13L2dXbmlsNWxS?= =?utf-8?B?b0xnRUdEZDZWSEptc0xrUkhLUHpXTldvSFpiVjNVU0V0NmNYY25GMkVLaWhi?= =?utf-8?B?WTlEZ3RzV000UXRvSFFRc2N0SmlHYWljNTFSWXk5VVFia2x6aThVWjdKSG5B?= =?utf-8?B?aDNRaFZBMFpDZCtEY3FIWjdkbmEvOEhraklGTEltK1ZXVnFqdDg4WEh0Um5I?= =?utf-8?B?Um8wQ0ZEcHNua2NKU092MkY0Ykh0N2NrWFpMMStjODdROW9idTM2Y0NoQ0F1?= =?utf-8?B?QVlWUkNmRWk3SzhpVlJZMmRYcXZHUXM5SUVZVmJRTHNRQjAxcWRMNzBuT0lC?= =?utf-8?B?aWNyNmlsUmtyYVord0R4T210R01waEcyOG5BZEJ3UjAzTmZ3eC9wSnppTTQ0?= =?utf-8?B?VkFyelRvNTFDWGNCZkVvN3dRZzc5NVk4MEJhd1lyaGMxaGpuR1U3c21ZWE50?= =?utf-8?B?ZXJTREtaNk5oUVRhTThZVHlwaXgwSVRHOTV6ZHdDK21VU1FDOGRuNmhLWDhm?= =?utf-8?B?OTFoZWFTZFc5MklNVVJkZWlZVHZlOWZLVHZZVU43dDBEUHVVSE8xYVVoNHIw?= =?utf-8?B?RVQ3U25jSE9uMlBsNjJoT2hiM2pxSW5qcndQYm10Q1FDVXpBcm12UmszeHJa?= =?utf-8?B?ZWZuL2lWZWRpN3ZmVzU5Qm8xR2NSdUNEY25EWUFMUlZrbFMzb0VNdm4xdzRQ?= =?utf-8?B?VlpTQjc1aCtZU0tZcWYwUWRucmw0bGJ1WEV3bDJLTXl2WEF1Vm5VWUZWRTJm?= =?utf-8?B?RmxvQ0dMZUNwR3VtWFNhdUhvenM1L3VNK2dVWU9GNlp5ZW9LWTFXVkhPWXQz?= =?utf-8?B?djA3R1BackpUT29WSEJJajkyV2RtNDJWUEMyakZtY1lrNE45NkZBZTc1dSti?= =?utf-8?B?S0JISmdoSE8wUU5vLzlISjYyejY2Qmg0ZEQzSjNJQjdpMUI0clUvNG1jRXpp?= =?utf-8?B?YWpYSW9Nb1E2dXZLSHlLU29GcHZHZHIwNUVoRnhJeUJnVGl6eVNDTlBMOXhX?= =?utf-8?B?WFZhbmpaNXR0aWxzRDUvV1V3ZGNoVzk4TC93VVRodUt0cm81YjBtN1MvZktX?= =?utf-8?B?ZGtNY0twQ2ZrODlZS0lETHdrV2VUdHZhTkRaOFFWM0wrK0UxVy9aVXRLTnBy?= =?utf-8?B?eWZHMW5DL2NwOHRiaFZacGZWak0xMzZRQWdELzdBaHRsdnBEaUZ1VkMwcWlT?= =?utf-8?B?THVXS1BVK3hGK0dBT3pBNTNBQXhCWm11VXhaZjRFQ3QxVVJWUDJhQ04wcW1D?= =?utf-8?B?emc1QTFmUWpZWTBJalN2QlZBcnp6amtjMi9oR3NyN29jTCtWcDRGblRBeWl3?= =?utf-8?B?REVjKytEM25nTmhzQjd0bkJWcjFRRnA4RW9pcnBtM29RczgxMXU1WjBjd1lF?= =?utf-8?B?NUN5cC94RWZWZk44RlJuWUhKTGJOdEVoUFFzYVpUY2hsMmdqNnRxUHB2d0t1?= =?utf-8?Q?XAzpG9GLBzJQY/6Z11HclHZQsUvWY=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB4PR07MB313;6:TQ5tTO3MNO0hf9E8GwDtmvJM1U9ILJ/D72CmYP9D08V6EgX5C+GpZKgve9oEpMYr7O7AJqXVg5/f35gbL/IIS07QLUtWhkXibKeMIcmLc0eGq4FwjtKy7u5GzmjcwB2d3PHLbWV/ASJdah7midVcR7L17zC/07Erc0ZDWbxCU3bSOXm9MOpBcu8W58qsgIxyvxNx/uzoyZsir1gl2lKRPf76BtILR7ZRs8o3cqEqb+GjZnWIHizX3KVOkT9IT5IGrXMO1R56U/ZkxleFx/pI7caHWxTa5aR8EtJt2+fH1bSZ1aoeWhCbm6VoXNiCS22DcjhWdfHfprW2N6W+uJ4DYA==;5:zgLh5sv6vylX0bNg1qqoCa1GTeT0+bLRUQ8McAopUwGIJ2VK4bd8wvXMfZUBa/6C6xobpYAui91nWv44md1U+04n+EwOhQvkMGPHRjdJEjQXWlVpboBM9Or+yvHC39lzKhPPdlAo8i3WO/Y9Usz7ew==;24:5w/l662PFKgVbyCmtIrKTUaIcIeK4hkRGMIzIs4QbMBx6lYBAx4LZgcORW/UP9F+qubluRGHlquEHDIjuUWWV1l0e8mjLKGDJ1NRbJk4Ksg=;7:snFgJVRLY2WizeH4rrPzCvmioUfxvEIzbk/mFqtR5Mi6B+4vk9XHZRoTDxmYPl6PVCUK2p9TESlK7KX6d5ygjFfQZXdSjR5Y+xd1qiRyTnQcEP/YlZ9rsYs1STEOfKOvOqjeE7fOpksleXYfXsu58RkZoj0Hk2XTbZUjoAnixQNhlC++FqEEPGeTY1d/TAIjpxRTt9wJV0Q2CWUwD+1p+bx5uwdOEALbXCNEe1kXZHM= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Oct 2017 15:03:29.2700 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 92e84ceb-fbfd-47ab-be52-080c6b87953f X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB4PR07MB313 X-OriginatorOrg: ericsson.com X-IsSubscribed: yes X-SW-Source: 2017-10/txt/msg00444.txt.bz2 On 2017-09-20 11:25 AM, Pedro Alves wrote: > On 09/06/2017 07:41 PM, Keith Seitz wrote: >> On 09/04/2017 11:47 AM, Pedro Alves wrote: >>> The "list" command allows specifying the name of variables as >>> argument, not just functions, so that users can type "list >>> a_global_variable". >>> >>> That support is a broken when it comes to ambiguous locations though. >> >> Very nice! >> >> FWIW, I have only one trivial nit (below). >> >> Keith >> >> PS. Out of curiosity, I hacked up a test program with multiple symbols named "ambiguous," both functions and variables. Well done! > > Awesome. :-) > >> >> (gdb) set listsize 3 >> (gdb) list ambiguous >> file: "amb1.c", line number: 5, symbol: "ambiguous" >> 4 >> 5 static int ambiguous = 0; >> 6 >> file: "amb2.c", line number: 3, symbol: "ambiguous" >> 2 ambiguous (void) >> 3 { >> 4 return 0; >> file: "amb3.c", line number: 3, symbol: "ambiguous" >> 2 ambiguous (void) >> 3 { >> 4 return 0; >> file: "amb4.c", line number: 1, symbol: "ambiguous" >> 1 static int ambiguous = 0; >> 2 >> 3 int >> > >>> - /* The minimal symbol might point to a function descriptor; >>> - resolve it to the actual code address instead. */ >>> - pc = gdbarch_convert_from_func_ptr_addr (gdbarch, sal.pc, ¤t_target); >>> - if (pc != sal.pc) >>> - sal = find_pc_sect_line (pc, NULL, 0); >>> + /* The minimal symbol might point to a function descriptor; >>> + resolve it to the actual code address instead. */ >>> + pc = gdbarch_convert_from_func_ptr_addr (gdbarch, sal.pc, ¤t_target); >> >> This line exceeds the 80-char line length limit. > > Indeed it does. Fixed before pushing (both patches). > > Thanks for the review! > Hi Pedro, The buildbot shows some failures on ppc64be: PASS -> FAIL: gdb.base/dbx.exp: whereis my_list PASS -> FAIL: gdb.mi/gdb669.exp: -thread-list-ids PASS -> FAIL: gdb.mi/gdb669.exp: finding MI result string PASS -> FAIL: gdb.mi/gdb669.exp: finding number of threads in MI output I tested on gcc110, and bisect points to this patch here (for both tests). A symptom of the problem is that "break main" generates two locations. Before (at e5f25bc5^): (gdb) b main Breakpoint 1 at 0x10000560: file test.c, line 3. (gdb) info breakpoints Num Type Disp Enb Address What 1 breakpoint keep y 0x0000000010000560 in main at test.c:3 After (at e5f25bc5) (gdb) b main Breakpoint 1 at 0x10000560: main. (2 locations) (gdb) info breakpoints Num Type Disp Enb Address What 1 breakpoint keep y 1.1 y 0x0000000010000560 in main at test.c:3 1.2 y 0x0000000010020078
Simon