From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id +gBKLrwxWWnFMigAWB0awg (envelope-from ) for ; Sat, 03 Jan 2026 10:11:56 -0500 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wXxFDLgG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+A/NQsCo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AuAN7Xjr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E109HhSK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AC7841E0B6; Sat, 03 Jan 2026 10:11:56 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0255C1E08D for ; Sat, 03 Jan 2026 10:11:55 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 701484BA2E21 for ; Sat, 3 Jan 2026 15:11:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 701484BA2E21 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=wXxFDLgG; dkim=pass header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=+A/NQsCo; dkim=pass (1024-bit key) header.d=suse.de header.i=@suse.de header.a=rsa-sha256 header.s=susede2_rsa header.b=AuAN7Xjr; dkim=neutral header.d=suse.de header.i=@suse.de header.a=ed25519-sha256 header.s=susede2_ed25519 header.b=E109HhSK Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by sourceware.org (Postfix) with ESMTPS id 7DE6A4BA2E04 for ; Sat, 3 Jan 2026 15:11:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 7DE6A4BA2E04 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=suse.de Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=suse.de ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 7DE6A4BA2E04 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=195.135.223.131 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767453088; cv=none; b=bqFbnUttuxvsZHnTA2HdYBxNeFhQJooUTubRqCe07n4NfMEYTSUPVPFX5j0j2kdKJpQniJp2ehr2ac1gVfRcGtKXGQAPY8wCapkBJGxdR542/slUElrkL3e0K1v9CdgqY3l//dQ2t8aP8VmnK4WLJ1Y4vCkbHJkEmKuz43VhRA4= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1767453088; c=relaxed/simple; bh=nTOSo3mq9bkETgR9BtqJ0VdEISaDr95RjE7eUWDlUW8=; h=DKIM-Signature:DKIM-Signature:DKIM-Signature:DKIM-Signature: Message-ID:Date:MIME-Version:Subject:From:To; b=Xwibb1ucOfOefGtfuem4vRVuUIP+yMTCqdjYYjrSjTpxEcoRiHCpOjIxlC5voSVFA8u4GUvwNshEveXbDk7S9G0likq+o60DoEShSr04/6JIc0KynjVFpy5/HzNC+JifSh0DfdQ2ZxT4ZLnHksQGX1wDh+AdMHos9UvdwG7H0Pg= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7DE6A4BA2E04 Received: from imap1.dmz-prg2.suse.org (unknown [10.150.64.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 617485BCC2 for ; Sat, 3 Jan 2026 15:11:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1767453087; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=daeS8jKEvWhhawL8vy3rj7jWn0kPJaLDEuUgaLPDuDw=; b=wXxFDLgGz3GXzFNALDilJLQX+8V0Oc+vIH3N4zrNiptfqJYoqPdFUOBgWPGX7J9+rY/uA8 gh8ljLBSe7v2tyG1kCR3bH1XYwTVW9qBKFyWr5jg4vQiTQ8d9VwEiXxo/19gJyLBjRKhK7 lf2sel0ohyhmynGzJA6DpcBViV9E0cg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1767453087; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=daeS8jKEvWhhawL8vy3rj7jWn0kPJaLDEuUgaLPDuDw=; b=+A/NQsCokET3gTj9K3Yg9qT0v3LI3CBMaDBfKv3PZ9qJW76LCfDuJ8tAFlIKwW1I157Zow AzlsVw7mF1MT/FAw== Authentication-Results: smtp-out2.suse.de; none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1767453086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=daeS8jKEvWhhawL8vy3rj7jWn0kPJaLDEuUgaLPDuDw=; b=AuAN7XjrFU4U6UR6HhS5nlBS7QRLo84bp8+Ij6DYMR3bNwSOgyLzXvpaD3gdN9eFaraHfa oW1VRP+YPBmWWQfr3WTILvf12vj6HgXnw16BuhvNADFatmvtgPEafafxkfQ+CPPxXJmS9o QKloNeGldBPJVIdt+9TNtEYTu/RP5Ks= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1767453086; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc: mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=daeS8jKEvWhhawL8vy3rj7jWn0kPJaLDEuUgaLPDuDw=; b=E109HhSKej42ziEK4mr6ohv1iKNKrZJJHTtW8W0IoRHC0R8nu9xxw9LT8yEdjhh9zLKhi1 VPfb01+k1XvdE2BA== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 4E7C73EA63 for ; Sat, 3 Jan 2026 15:11:26 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZSlJEZ4xWWk8fAAAD6G6ig (envelope-from ) for ; Sat, 03 Jan 2026 15:11:26 +0000 Message-ID: Date: Sat, 3 Jan 2026 16:11:25 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] [gdb/testsuite] Fix gdb.base/local-env.exp on remote host From: Tom de Vries To: gdb-patches@sourceware.org References: <20251211154211.1086859-1-tdevries@suse.de> Content-Language: en-US In-Reply-To: <20251211154211.1086859-1-tdevries@suse.de> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spamd-Result: default: False [-2.23 / 50.00]; BAYES_HAM(-3.00)[100.00%]; NEURAL_SPAM_SHORT(1.87)[0.623]; NEURAL_HAM_LONG(-1.00)[-1.000]; MIME_GOOD(-0.10)[text/plain]; FUZZY_RATELIMITED(0.00)[rspamd.com]; RCVD_VIA_SMTP_AUTH(0.00)[]; ARC_NA(0.00)[]; MID_RHS_MATCH_FROM(0.00)[]; RCPT_COUNT_ONE(0.00)[1]; MIME_TRACE(0.00)[0:+]; RCVD_TLS_ALL(0.00)[]; PREVIOUSLY_DELIVERED(0.00)[gdb-patches@sourceware.org]; FROM_EQ_ENVFROM(0.00)[]; FROM_HAS_DN(0.00)[]; DKIM_SIGNED(0.00)[suse.de:s=susede2_rsa,suse.de:s=susede2_ed25519]; RCVD_COUNT_TWO(0.00)[2]; TO_MATCH_ENVRCPT_ALL(0.00)[]; TO_DN_NONE(0.00)[]; DBL_BLOCKED_OPENRESOLVER(0.00)[gdb.base:url, make-check-all.sh:url, suse.de:mid, imap1.dmz-prg2.suse.org:helo] X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 12/11/25 4:42 PM, Tom de Vries wrote: > With host/target board local-remote-host-native.exp and other remote host > configurations, and test-case gdb.base/local-env.exp I get: > ... > (gdb) show environment^M > ... > (gdb) FAIL: $exp: show environment displayed variable > ... > > The test attempt to detect variable GDB_TEST_ENV_VAR in the environment, which > has been set with setenv. > > This doesn't work with remote host, so declare the test unsupported. Likewise > in gdb.base/environ.exp. > I've pushed this. Thanks, - Tom > Tested on x86_64-linux with make-check-all.sh. > --- > gdb/testsuite/gdb.base/environ.exp | 7 ++++++- > gdb/testsuite/gdb.base/local-env.exp | 7 ++++++- > 2 files changed, 12 insertions(+), 2 deletions(-) > > diff --git a/gdb/testsuite/gdb.base/environ.exp b/gdb/testsuite/gdb.base/environ.exp > index 091010acfda..d95a6f7d03c 100644 > --- a/gdb/testsuite/gdb.base/environ.exp > +++ b/gdb/testsuite/gdb.base/environ.exp > @@ -46,7 +46,12 @@ gdb_test_multiple "show environment" "show environment works" -lbl { > } > } > > -gdb_assert {$saw_env == 1} "show environment displayed variable" > +set test "show environment displayed variable" > +if {[is_remote host]} { > + unsupported $test > +} else { > + gdb_assert {$saw_env == 1} $test > +} > > # Verify that we can unset a specific environment variable. > gdb_test_no_output "unset environment EDITOR" "unset environment variable" > diff --git a/gdb/testsuite/gdb.base/local-env.exp b/gdb/testsuite/gdb.base/local-env.exp > index c62ea746635..394504cd79b 100644 > --- a/gdb/testsuite/gdb.base/local-env.exp > +++ b/gdb/testsuite/gdb.base/local-env.exp > @@ -48,7 +48,12 @@ gdb_test_multiple "show environment" "show environment works" -lbl { > } > } > > -gdb_assert {$saw_env == 1} "show environment displayed variable" > +set test "show environment displayed variable" > +if {[is_remote host]} { > + unsupported $test > +} else { > + gdb_assert {$saw_env == 1} $test > +} > > # Verify that we can unset a specific environment variable. > gdb_test_no_output "unset local-environment EDITOR" \ > > base-commit: 4f9b9eaa24383d920f37fbeb0592113252e37bbc