From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yYPLECfMsmkODyYAWB0awg (envelope-from ) for ; Thu, 12 Mar 2026 10:22:31 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Xh4WX2wu; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 3F8301E0DD; Thu, 12 Mar 2026 10:22:31 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_MSPIKE_H2,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C718B1E08D for ; Thu, 12 Mar 2026 10:22:30 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 57C8A4BBCDA0 for ; Thu, 12 Mar 2026 14:22:30 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 57C8A4BBCDA0 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=Xh4WX2wu Received: from YT5PR01CU002.outbound.protection.outlook.com (mail-canadacentralazlp170110005.outbound.protection.outlook.com [IPv6:2a01:111:f403:c103::5]) by sourceware.org (Postfix) with ESMTPS id C79734BBC0FA for ; Thu, 12 Mar 2026 14:21:50 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org C79734BBC0FA Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org C79734BBC0FA Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c103::5 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773325310; cv=pass; b=NYq9/nUcWDUbJhzXD9IDOsm9ECMeglGvTLU7ZWsSedeHgDA3BH/03WHb55+nk55pPepfuwv2Aak2XyAb6f6V/+5xzeuHsbPANKKlRlBd4n5tzcwAT40/HH4KkEi65GxzmWlIwMbye9QoSp58TpLdcGYu9VAgdfOijBrQ6nREGxQ= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773325310; c=relaxed/simple; bh=Gl/LKoFb5XKSr6ibzzWE7f9gEetvF2G8JzKbaAqOU3M=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=A2IV6YohEeGSkVKYKMHhcxohk9V2Rzuo760MwzSxgM2xN3tJlM3d4o59keP8d56Enx3fhf4vptu5dbfCZ/Q8rdId9FbE5yOD9TXRmB7JbfDvYFjn1ySEABxyNjvlbOluO/cz12eQJGtT0jJNyXkthjrWDLKiWTZJbZxx2p2RCo4= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org C79734BBC0FA ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=EjfnY8Jr2kUXp3GiQtyU1aSwWGQ8Q7pQCrZyKPXDT4MJdSb4XkyDiN0s/XN1AQ+Z8qzHx7UTB2rFo/snxqAs943409M7nRDIHQOBHe4qOzdduO6xEri7nksALkGKZYmzfogh/adlJJ7pPgGv+JseRuMUOtZxJ5/seBXeJbcegxO0IVdx/9OoY07lwO/esVbvp6CV/0U+zVWVxeS7a8FD8BCnJXGCLI5PMkqGq+MqgrGmwvaTJRn52xMwovM0hL0idLxiYAQPcXe3K5Ljou9ZMxzNCypsxA17RPDaewLDAgfOEAjoZNbs+oIArcjgGwhaVVFGlUiWCgWPHrZZeunPmw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=9btTkbszCESUYt2Pky5tBhxGvHKYfdkHPOZYNd2T/yQ=; b=VXNjeGHMHiIa9cCOXYb3sUmxTbCfQbHsZm7iMkTFsCt+y/qLtH+byQsjb18WTD8iUVRZye5wHRShqCcAXs1oXcZxBYUjadb9geSuKCxZ/PaP3G4y7zp+bTfahvTxBostEQLP9h+By3aI2o+57Jzhng2Q+NWdxvc6XV8vT0Y3jAD4Lqxs6jwKTDMxPDHaatx7mUdnPPsTgFI9Tk1D4Kq409TrOR4zDE8nEPox/jjfg2aWQ3LGozPAvpBFOKqLOTFS1CQs9tnkYS3MKlsXYX4D0kowkIRdmEwrGvARrUlOeLVuI8CVTFgwwnHyafB3XXeWmQizy6OO90GCPmV/ZiWXRg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=9btTkbszCESUYt2Pky5tBhxGvHKYfdkHPOZYNd2T/yQ=; b=Xh4WX2wug2hV2LbMDBc/TfJxTuWUfaWQAS7Y12lJiubY0olIQ2d8cEBrm3z8n+uwBy0pDSxge2GBQMPUoatwN8BEHP85JgcbKKTnao6R0Fwg43tK4iqdmQvXuOTwvpxjhPq4qtFEyo3qsk+GMAb8sVfHScWU3HukerYoUwBCLS1Pn5S3Oi90gYHoKOtphNjGnGAD+eWIqZniTbIO4qCbhmGB0BqyaMnj4119Moe38ag34C9eJsgwqd4JeKpd3o1+c6L1nR3cmClWshYVIIPZwi3cqSeehCIlEoKfSEDpjJVBhtlI3ReINdsRGes30O2mwAzREadj1l7N/73na+/Lmg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YT4PR01MB11468.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:158::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9700.15; Thu, 12 Mar 2026 14:21:43 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9700.013; Thu, 12 Mar 2026 14:21:43 +0000 Message-ID: Date: Thu, 12 Mar 2026 10:21:47 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 10/23] gdb/dwarf: change dwarf2_ranges_read to return bool To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260311180825.720803-1-simon.marchi@efficios.com> <20260311180825.720803-11-simon.marchi@efficios.com> <877brhtdxl.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <877brhtdxl.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQBPR01CA0112.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:1::12) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YT4PR01MB11468:EE_ X-MS-Office365-Filtering-Correlation-Id: b3b9c789-871d-4135-0ceb-08de8042af65 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; ARA:13230040|366016|376014|1800799024|22082099003|18002099003|56012099003; X-Microsoft-Antispam-Message-Info: sV0GG9iAd3mqIbq6OZ5DTGTucyZdg0swp5Dg1BMCJVVcfE0ssu4yz4iKct26uLjhCVcv+zsLbiVHMyJVhKN9xnWvQl60FN5pGCo3D0VPu/NmV74/Ho7KMCFbb/rK0FKfMy4qnzRnkW/6Dj8i7bP9wYTTM1VUxlGn78l+fzD6Q7uK/uKM3XJJhoN2hdl5plI3yTMh6ka+aEQmFuffwziRmaCOQf/lvTuKCef2iakav1q83HKcMCzloUxz3UXeb4z6WkGuz+Vl3KBRxI7WsHfOzityjRnLxqPbRjfWoyjWzWVlC53J+W0cNCTaz2Hk6ULvL4xjY+laetw+Tn5c9G5mhe3jLcXZytNzS/WxU1Amkswq/W2VC+c8ihRaHD+20S5MqqcXDzCxs+k6D1Vczg52vT2/JWiKa6PePvQ7hQyFG2XZtdsbjeh1dc+VYMHuL5DgtEqNewuNuuAE7ZBhqiV14toLSbvN223Pbln8geZqSfj8N1CBKpTeVFf6K2wUa5I0qB1NCUrfQfJBOYYiJBSnKEyLtr70iALWkUngkN7o5aWwvGZklcRcJvqUQsZ8TFj16XuiLVpa7Ur5yjddzKgVcISBHyvFiJaRtzvDTMxgQStuj6rVL1z7ZUgSArN6Fy6OTyQLLeji0DA3xa8wrABvozpf+1xcDLtfjvSNahvYtdqKbnuGHvRTGUhUtjr2dknHw3c3BEAvz9VBYZPXr1q1+9dY8nTxJ8WvlY/QKkSzvgY= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024)(22082099003)(18002099003)(56012099003); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UWttdmRtam5FSUQraFhPRmlXVmJ6c1lzOVRYQ0xaYkU2VnUvS0M2MkwvZ0li?= =?utf-8?B?WlBCV0lIYjltOWQyekxoQVpOOHFFSEt0dFVmdkFOdnNUc2JoM0NuZGlNbU9m?= =?utf-8?B?N0cwYmNWcnovVDdkeVV2WUhmaTRUY1NDTzlSMTcwbDM3eXpBK3JlWmYvckRo?= =?utf-8?B?aEhOVnY1NVRabHBHR0svMVptbGxqdUxUVDFienhERUpONnVvdUhMRDZiYkgw?= =?utf-8?B?RzF3S0QyejVQNGtiYjBSdmFBQUxSZ0pwQjRjSnYwYjdON2hCcTFLZFFsbkVP?= =?utf-8?B?QkRZZldGUXd3N3RnODRFTksrZ2E0b3BIQ0huY0trR1lCN2NFbGRnTUFISzBD?= =?utf-8?B?dEpqNE96aXAxWGgzK0lraVRkZGdxM2dMYVE1RnpNOHFLU1ZYZGNkVkdhc05u?= =?utf-8?B?TlVCWVM0Mm9oTElpMmlnS1YwWnhtazdGMGowczdlUG5Ma1JhbWt6aHBxUS9z?= =?utf-8?B?UGdpakxDRzF6VW0xdEowVURmT0JQS2lGZXJ3alhQMkE4TE9FZDY4bUFRTkFS?= =?utf-8?B?Wklqc3FPeForODJDQkRxN3VsOFQrRHN0cjBiRTRRY1JpcmRKU2t6d1FzMjdp?= =?utf-8?B?c2JqNVEyZVNpelRrbkhINWV1ZzF5OXptT0pwZkw1OURSN0o5cWliczhaYVov?= =?utf-8?B?c3lMZWo3dmNITExZYkQ1a3hobnlZeWpnSDVybGdoblM3T3VjeUVuRWpEaGNY?= =?utf-8?B?cjlQc25zajBmTnhvT3B1Q3NzV3JQb3A4VEtHcjdxMk9sRytaSDcyZmJTQ1Fy?= =?utf-8?B?UDNtNkNUaGE2Y3Q2VXlBT0xWNUFJYUdTUU03Y2JjZ1ZUWjlRZFFKd0xtRzR5?= =?utf-8?B?dDk3RlpHRFJERTVkM0JEeXBHZGxaTHhYcjRmUmJ4VFM5YnZzOHpoUTZnWkVZ?= =?utf-8?B?M3R1ajBzZnVaNzQ2d0l0OHd4Q0l2eXRhYmFucU9pQXhPcWxlSkdWY0hKUk1H?= =?utf-8?B?Y0UwSE82MHl6OEc2dmFHQXBMZ2trUks3QmN3OVZqSVlUVk1uQ0l0OE9JdVdK?= =?utf-8?B?bldFYTJLNkdiK1J2RGczTEtsZ0owaDhweU1OODJuTzhXTEp1QTRHeFAyUVN0?= =?utf-8?B?cHFnRjNKTzdnUmZBZzIyVlc4RERCTkYzSlZaV1BCdW13YUhaYWJkcTVyYUdp?= =?utf-8?B?YlJHZVE2RXFjZWJHR0REd1hveWlrOXlnbFNkT1Y4eUNUcFlJVXkwNzczMmtp?= =?utf-8?B?b2cxUkFJTTczQ25JT3ZjUWhpZjgrM2hJVDFPdFlYa3hNQ3N3NXlIbVByZXBw?= =?utf-8?B?ajUyb1FMeEMzek95RVBjd2lReGViOG9PTFNvQ0dNK01YQm9zdWdMalplQ09Z?= =?utf-8?B?aHJwOTZLMFVDUTNTTUd2a3ZxQVo1L3RhQ3JNdGF2K3J6ejdrdklvQXFvQi9q?= =?utf-8?B?cFBXL081R1JWZDRxY05QRzJkM1ZWdjBkZWFmVm02bVdSbmxYdVdCQzhjQkpO?= =?utf-8?B?ZS9SWFVFRWtkWnljUmozVzVxdlNVSmsxdXFtVkNFLzYvSHJiVlBEUC9OTlZC?= =?utf-8?B?a29Qc21xSnY2R3g2OWphQms2ZzR5RFJqRU9xZ24yM0ZQYThXSi80Z0FZYkpo?= =?utf-8?B?aXN4c2NqRGpVa1hoSDRHUEFSWjNxOW5CdUVxcUx2S3YvSi9uMlhmNEVLOTlr?= =?utf-8?B?TDNqUnNwR1FxM1I0d2hGVEhkcG9hMDA0RnoyeGlzT0hZSDdtZVZmTWZ0aDA5?= =?utf-8?B?cDhwQzRYMHQrN2xDMjkveFdMYXhYQjUwNzJRajMxQVJkMHpvZy9pbFlpMDh3?= =?utf-8?B?Q2VUNVdkNWFGYzVsMHhVTGJkRTJGb0N0US9hNUpVdUJreEJvazhkd0U1eEE2?= =?utf-8?B?U3pmU0FRNExsREs3a0xrT0tRUmlYN1FmQmlRUWRGZ1NUSnlsYkl3V09zR3Jz?= =?utf-8?B?YjJ1VmduRVlEMFo4ekJWK0tnUW1FcmJ3NmVOSUkyU3BhQUlkSVpBKzdJTWxP?= =?utf-8?B?Z1gvakgrbUJPS2N4dHpMRG5ZYjhJUk1id2F3M0UzNGpoUDNkMStjVHFETXVJ?= =?utf-8?B?UFhBcUZSOUFqbEQ2OWRyVzE5eGJtY0tIa2pFL3o4WFRLUk1EZEFrendHUGZP?= =?utf-8?B?bXFuUzdkSEFETXF2bXZoSENCNVE5alMwbldOYzNhVVN2KzlmdzlueE9PNmtU?= =?utf-8?B?OXRMc2pqaU5NQ1pPT1ltTUtTTXRtSklBWnYyLy9KZjVqZllqU01mOE9oZmhX?= =?utf-8?B?MDdqRDV0R1BnYjhabzFuajBSTFRmNTZ6WmdjWFFzcnA4NzNxb05kcHkwQjlI?= =?utf-8?B?dHA1LzEvRlpNTEFXMTVHeGpJV1BxemFOa1dIcW5zL3FpZHUyQkYwTml4OXUw?= =?utf-8?B?L05KaEtOQndtV1dZRm5GNEtNRFA0UmJWK1doUHVqRGZLeVdDTjU3QT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: b3b9c789-871d-4135-0ceb-08de8042af65 X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2026 14:21:43.3528 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: PJkHQ7DsySdGDQ4ikw6jp5pc5B+KEW6XOnmpgCHiqjgKNNltv/Ijcxm5nMzRdKovznHBPBz9wgvdWVWaOuvSSQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YT4PR01MB11468 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-03-12 08:44, Tom Tromey wrote: >>>>>> "Simon" == Simon Marchi writes: > > Simon> -int > Simon> +bool > Simon> dwarf2_ranges_read (unsigned offset, unrelocated_addr *low_return, > Simon> unrelocated_addr *high_return, struct dwarf2_cu *cu, > Simon> addrmap_mutable *map, void *datum, dwarf_tag tag) > Simon> { > Simon> - int low_set = 0; > Simon> + bool low_set = false; > Simon> unrelocated_addr low = {}; > Simon> unrelocated_addr high = {}; > > I was going to suggest std::optional here, but it seems "low_set" is > misnamed and it really tracks whether both values have been set. > > Tom I'll see if I can improve things there. Simon