From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id A3NVF8c2bWNvmhYAWB0awg (envelope-from ) for ; Thu, 10 Nov 2022 12:37:11 -0500 Received: by simark.ca (Postfix, from userid 112) id 514721E124; Thu, 10 Nov 2022 12:37:11 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=s7eSHFAQ; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0AE091E0D3 for ; Thu, 10 Nov 2022 12:37:11 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66AC2385840A for ; Thu, 10 Nov 2022 17:37:10 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 66AC2385840A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668101830; bh=C4MkoJxBXSYTXylVUhYfP91lK+IXnSWfcSgJt2g4AYg=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=s7eSHFAQYiwrqIsAn31R5WHClrIoWXa/H59LMpn/jej+s/9n28o/BNOW8s6vatf7W NMwODswzlUuTPpTj/1gAwdiPpw/oy72+KucRqWZ3LbE0RrCYnvROmGLtdnq2+ygEV/ PLXMdymsYbYpe4Ne6CrEC0FfQBxzDoCi6GH8WHCo= Received: from simark.ca (simark.ca [158.69.221.121]) by sourceware.org (Postfix) with ESMTPS id 697A83858D20 for ; Thu, 10 Nov 2022 17:36:36 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 697A83858D20 Received: from [10.0.0.11] (unknown [217.28.27.60]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id CA5AD1E0D3; Thu, 10 Nov 2022 12:36:35 -0500 (EST) Message-ID: Date: Thu, 10 Nov 2022 12:36:35 -0500 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v2] gdb: make "start" breakpoint inferior-specific Content-Language: en-US To: Pedro Alves , Simon Marchi , gdb-patches@sourceware.org References: <691c5a58-68ae-5fe9-2f3d-34fb7af69ad0@palves.net> <20221108212008.1792090-1-simon.marchi@efficios.com> <47b696c4-6584-8165-0799-5d742132361a@palves.net> <0ebeeb02-db83-53ac-2bcb-05dc92b96316@simark.ca> In-Reply-To: <0ebeeb02-db83-53ac-2bcb-05dc92b96316@simark.ca> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" >> Even though this does work, it still sets the breakpoint on all the pspaces >> unnecessarily. It would be nice if the breakpoint was pspace specific, in >> addition to inferior specific like you have (or some other way). But, what you >> have is fine with me as is, as it is better than what we have today. >> Maybe just add a little comment suggesting that it would be even better >> to make the breakpoint apply to the current pspace only? > > Will do. FWIW, here's what I'm adding /* To avoid other inferiors hitting this breakpoint, make it inferior-specific using a condition. A better solution would be to have proper inferior-specific breakpoint support, in the breakpoint machinery. We could then avoid inserting a breakpoint in the program spaces unrelated to this inferior. */ Simon