From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 81648 invoked by alias); 29 Aug 2018 15:50:56 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 81634 invoked by uid 89); 29 Aug 2018 15:50:55 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-2.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2850 X-HELO: smtp.polymtl.ca Received: from smtp.polymtl.ca (HELO smtp.polymtl.ca) (132.207.4.11) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 29 Aug 2018 15:50:54 +0000 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id w7TFojxK022128 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT) for ; Wed, 29 Aug 2018 11:50:49 -0400 Received: by simark.ca (Postfix, from userid 112) id 2F55E1E4A5; Wed, 29 Aug 2018 11:50:45 -0400 (EDT) Received: from simark.ca (localhost [127.0.0.1]) by simark.ca (Postfix) with ESMTP id B4A501E186; Wed, 29 Aug 2018 11:50:43 -0400 (EDT) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Date: Wed, 29 Aug 2018 15:50:00 -0000 From: Simon Marchi To: SiZiOUS Cc: Eli Zaretskii , Pedro Alves , gdb-patches@sourceware.org Subject: Re: [PATCH][PR build/23568] Fix gdb-7.12.1 MinGW/MSYS build issue In-Reply-To: <56153263-c5e6-45ce-8629-c5a77cf17f5b@gmail.com> References: <56c5911c-e0ba-5a17-64bb-3634af60a07d@gmail.com> <18eaf339-ca0a-061c-4a17-b837e6ef81a2@redhat.com> <83wosa2yos.fsf@gnu.org> <56153263-c5e6-45ce-8629-c5a77cf17f5b@gmail.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.3.6 X-IsSubscribed: yes X-SW-Source: 2018-08/txt/msg00740.txt.bz2 On 2018-08-28 18:19, SiZiOUS wrote: > Please note, I'm using the original MinGW/MSYS environment, not the > newer MinGW-w64/MSYS2 environment which is a completely new project, > with no links from the original one. > The problem for me with MinGW-w64/MSYS2 is they dropped Windows XP > support (and I understand that) but for my purpose I need XP support, > as I targetting an old exotic platform (Sega Dreamcast if you're > wondering), so I'm targetting GDB with sh-elf (fyi it's a Hitachi SH-4 > CPU). That sounds awesome :). You are working with real hardware? You need Windows XP because that's what the original tools for that platform support? > ser-mingw.c: In function 'int ser_windows_read_prim(serial*, size_t)': > ser-mingw.c:346:30: error: 'ERROR_IO_PENDING' was not declared in this > scope >        if (GetLastError () != ERROR_IO_PENDING >                               ^~~~~~~~~~~~~~~~ > ser-mingw.c: In function 'int ser_windows_write_prim(serial*, const > void*, size_t)': > ser-mingw.c:368:30: error: 'ERROR_IO_PENDING' was not declared in this > scope >        if (GetLastError () != ERROR_IO_PENDING >                               ^~~~~~~~~~~~~~~~ > make[2]: *** [ser-mingw.o] Error 1 If this constant is supposed to be defined in the win32 API but is missing with mingw, could it be that it's more of a mingw bug, and it should be fixed there? > I tried the latest 8.0 build but it doesn't compile too. > Anyway I'm sticking to the 7.x branch as the GDB 7.x is confirmed to > work with the Sega Dreamcast platform. Just wondering, which 7.x version is confirmed to work with that platform? Functionality-wise, there's no more difference between the 7.12 and 8.0 releases, for example, than there are between 7.11 and 7.12. The numbers are pretty much arbitrary. So let's say GDB 7.6 was known to work, there's no reason to use 7.12 over what is the latest released GDB at the moment (unless you actually have a problem with the latest release, in which case we want to know!). > And I know, the MinGW/MSYS original project is maintained but almost > deprecated in favour of MinGW-w64/MSYS2 project. But I really need XP > support for my needs. > I proposed this patch because it's really simple and not intrusive, > but you're right, how many people uses that old MinGW/MSYS project? If the missing definition is indeed a mingw bug, but there is really no way of getting a new mingw release with that fixed because the project is unmaintained (but still useful to some people), I would not be against a patch like what you proposed. I would however add a clear comment for why this is needed, so that if some day we officially decide not to support this mingw, we can remove it. Simon