From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id CObuKFDs4GmjLRwAWB0awg (envelope-from ) for ; Thu, 16 Apr 2026 10:04:00 -0400 Authentication-Results: simark.ca; dkim=pass (1024-bit key; unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ju0etuJK; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 821001E0C3; Thu, 16 Apr 2026 10:04:00 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-3.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIMWL_WL_HIGH,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 291901E0B1 for ; Thu, 16 Apr 2026 10:03:55 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 2362D4B9DB48 for ; Thu, 16 Apr 2026 14:03:54 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 2362D4B9DB48 Authentication-Results: sourceware.org; dkim=pass (1024-bit key, unprotected) header.d=redhat.com header.i=@redhat.com header.a=rsa-sha256 header.s=mimecast20190719 header.b=Ju0etuJK Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by sourceware.org (Postfix) with ESMTP id ED9944B9DB48 for ; Thu, 16 Apr 2026 14:03:28 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org ED9944B9DB48 Authentication-Results: sourceware.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=redhat.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org ED9944B9DB48 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=170.10.129.124 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776348209; cv=none; b=pXAZ3EP1vkefTJ2yp7IF+ehwWJqhxh5UTtsor/axN3rpKwpBEUAXwuG1fd73e+MCPIT018dBSc9FvXXtglTZKDEwlWk1Pep6HigCO1I0yhWtA+aLl3STqsA9lEa9RHIlO9QNYQADvfeX1h5BoiXGIbBn+g6ucLO5UTj4TWTPGOU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1776348209; c=relaxed/simple; bh=DKy9CT6LP8EohHpTUMNTXHh47ZcQgN7vshad64b4Tko=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=Z+62sJpAR+YtOTksDh5922QBbXvp4eCbEYqaXfg6DcQVD74b8lzbIKthFoqyDF0O5cqHXcZoEpKdvgaw0IPIB23fkawrfX8j0U3b/SJjL4nIMAYPF5ES21fODZ0R2zo9yhoByZ4DnW9QIsRpIoylS5Z00tdeavXTcvoSKb4Psac= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org ED9944B9DB48 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1776348208; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tekQXeMDy27EA4XRIszmdTfrGobuEeiGg+B8Lxu0xqQ=; b=Ju0etuJKU4M1yHmPjSmOLv7NIhk5jQi6g/NZlImxOQDF1TJmtw7SCoYeghtS6qaMFpqSrr ttbSBPCiriu7ccmFGNUaToyLdtsRlMaaHh4vgpexjWLezcQE0QRfOMa24tqy17Ok6roEYD HL3PHgp7/tZDhsTO3zAFpf+WKhJY3Vw= Received: from mail-ua1-f70.google.com (mail-ua1-f70.google.com [209.85.222.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-621-6Xzhg1rBMAK26-bxr54K2w-1; Thu, 16 Apr 2026 10:03:27 -0400 X-MC-Unique: 6Xzhg1rBMAK26-bxr54K2w-1 X-Mimecast-MFC-AGG-ID: 6Xzhg1rBMAK26-bxr54K2w_1776348207 Received: by mail-ua1-f70.google.com with SMTP id a1e0cc1a2514c-9539bc7e2d0so681891241.1 for ; Thu, 16 Apr 2026 07:03:27 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1776348204; x=1776953004; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=tekQXeMDy27EA4XRIszmdTfrGobuEeiGg+B8Lxu0xqQ=; b=sI7C7UxnDwtDWE6bZ7LE/bwzCUVeagHyXlDuKUBZJCKaI/n57Dr2FEAFm5anbnYOQ4 1jF6xwws8nkBi7TLzSJ0LfyM07v6/ga44ejtol5nGCtCjDHoVcR6wwGxmwPADRWi7t9r 7ZTNTu0kZ1DJr0sjxFaGwtPiQXqpRudbX6MIRUBVQxa51xADy9YDTJ0U3muKEWvkdY0S zCYD1dzThOqveznYVEpb1mhjhSZNpPnLVH8j+gZ9AJFEsDo8k0TnQ+0sXuCmzGm8dkuh GduiG15AfkTRE0FPatfGvkhh5Io0KWqxctWkY5bYYdTobVFxqMwY3bgsNQoDrorCSPRv fSZQ== X-Gm-Message-State: AOJu0YxmQxz7RwQXr4kvADQ2zOAQJsxNY8VWep+HpoO+ivZC4FEPuxaE zOWXdZrNj7c1F5HF3aPvu8fDCjMOd5n2nkgZUHNKFOhlE3AzOBKpuYn+YzfojG26TtDDg4pDNsv cUIltrv3y6w76Rrm9jCJJMKJBipgKbYdcRRU7V4HiO2Eg4RESV70Tem5tIPlTHGrObm8BMxk= X-Gm-Gg: AeBDiesB4UKwfgMUf7lGjvEN9Vhv8X1e2bhqZkj7OPIHYVUO2DnV9lBpLTXkDwXSf4o 7tNNqKKZ4mFyzJdREb4AchzpLBx+SqWmofUeZFwbQiIrz1SiWB9wJZOcJp8UyXrQWCMXZq9MMTf ru8zfuvBl02r/3m2fEFSUWh9AaVH/xt8AGI1DB4nxQn9M2Nmv8MKowYs+Q3d+QY6qpG0ldEwspe a/2K4G0EXg49hhsjYoQAo6hWI9wTVaZp5WdmySeWmJ7bdByJ8VIBXo1YdwwNjvVrADMUtrYcHzN CTwHJSeLCPEAAll7tS2iOqhmzRxeUN+Zz2xkRUXQDAPSoum//Tq6Ofr3KQDI2KEVB52fiNHmIZV wZEzNSmEb7HnTCf4wivfbo6EamqXvdEo= X-Received: by 2002:a67:e709:0:b0:612:db83:aa8 with SMTP id ada2fe7eead31-6146cb4932bmr548431137.6.1776348204197; Thu, 16 Apr 2026 07:03:24 -0700 (PDT) X-Received: by 2002:a67:e709:0:b0:612:db83:aa8 with SMTP id ada2fe7eead31-6146cb4932bmr548376137.6.1776348203700; Thu, 16 Apr 2026 07:03:23 -0700 (PDT) Received: from ?IPV6:2804:14d:8084:993e::75d? ([2804:14d:8084:993e::75d]) by smtp.gmail.com with ESMTPSA id ada2fe7eead31-612ccb251e1sm2445171137.3.2026.04.16.07.03.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 16 Apr 2026 07:03:21 -0700 (PDT) Message-ID: Date: Thu, 16 Apr 2026 11:03:16 -0300 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 6/6] gdb/record: Define new version of the record-save section To: Eli Zaretskii Cc: gdb-patches@sourceware.org References: <20260415185836.2732968-1-guinevere@redhat.com> <20260415185836.2732968-7-guinevere@redhat.com> <86pl3zla0b.fsf@gnu.org> <5de0615d-c637-4025-9bd5-c2cc8063f1e5@redhat.com> <86bjfjkoi5.fsf@gnu.org> From: Guinevere Larsen In-Reply-To: <86bjfjkoi5.fsf@gnu.org> X-Mimecast-Spam-Score: 0 X-Mimecast-MFC-PROC-ID: -O8-d-UZAHaGkPbMYtuFnZbswrSf-YKtIJHsExAc9PI_1776348207 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 4/16/26 10:45 AM, Eli Zaretskii wrote: >> Date: Thu, 16 Apr 2026 09:41:56 -0300 >> Cc: gdb-patches@sourceware.org >> From: Guinevere Larsen >> >>> Reviewed-By: Eli Zaretskii >>> >> This is confusing to me. You're supposed to add the review tag when >> you're satisfied with the patch and approving it to go through. > That's not my understanding, since I'm reviewing only part of the > patch. What I usually do is say when I'm satisfied is "this part is > OK" or "the documentation parts are approved". The point of the review tag is specifically to remove the ambiguity of needing to look for ambiguous language like "this part is ok". As the MAINTAINERS file explains - Reviewed-By:   Used when a contributor has looked at the code and agrees with   the changes, but either doesn't have the authority or doesn't   feel comfortable approving the patch. If you would like further changes, you  don't agree with them just yet, therefore you shouldn't be using the tag. It is here to create a very obvious "no further discussion is required" demarcation on the list, which your usage does not follow > >> So, do you think the explanation I gave is enough, or do you want me >> to explain it more on the news file? > I'd prefer that you at least mention the command(s) which produce and > read these execution records, so that people know what is affected. Ok will do. > > Thanks. > -- Cheers, Guinevere Larsen It/she