Re: [PATCH] Restore the order of file lists in features/Makefile

Pedro Alves
2016-11-08T14:55:11Z

On 11/08/2016 02:48 PM, Pedro Alves wrote:
> On 10/28/2016 03:52 PM, Maciej W. Rozycki wrote:
>> # Record which registers should be sent to GDB by default after stop.
>> aarch64-expedite = x29,sp,pc
>> +amd64-expedite = rbp,rsp,rip
>> arm-expedite = r11,sp,pc
>> i386-expedite = ebp,esp,eip
>> -amd64-expedite = rbp,rsp,rip
>> -x32-expedite = rbp,rsp,rip
>> -mips-expedite = r29,pc
>
> ...
>
>> +tic6x-c64x-linux-expedite = A15,PC
>> +tic6x-c64xp-expedite = A15,PC
>> +tic6x-c64xp-linux-expedite = A15,PC
>> +x32-expedite = rbp,rsp,rip
>>
>
> It's a bit of a shame that amd64, i386 and x32 get split up.
> And they'll get further and further away as we add more entries.
>
> How bad would it look if we said it's "mostly" sorted? E.g.,
>
> # Record which registers should be sent to GDB by default after
> # stop. Mostly alpha-sorted, except when it makes sense to group
> # architectures.
>
> amd64-expedite = rbp,rsp,rip
> i386-expedite = ebp,esp,eip
> x32-expedite = rbp,rsp,rip
>
> aarch64-expedite = x29,sp,pc
> arm-expedite = r11,sp,pc
> ...

Hmmm, the rs6000/ entries have an explicit dir name:

rs6000/powerpc-cell32l-expedite = r1,pc,r0,orig_r3,r4
rs6000/powerpc-cell64l-expedite = r1,pc,r0,orig_r3,r4

Maybe all we need is to prefix the x86 ones with i386/ ?

i386/amd64-expedite = rbp,rsp,rip
i386/i386-expedite = ebp,esp,eip
i386/x32-expedite = rbp,rsp,rip

I don't know if that works. I see that that prefix was actually
there recently, and it was removed by 414c838a722e recently.

Thanks,
Pedro Alves