From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mout.gmx.net (mout.gmx.net [212.227.17.22]) by sourceware.org (Postfix) with ESMTPS id 63B3738930D0 for ; Fri, 24 Apr 2020 09:16:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 63B3738930D0 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=gmx.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=n54@gmx.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1587719799; bh=EXLJEOR3nB/SVDfD2g7PLAyNzIHl2GYK98L2wgePX7g=; h=X-UI-Sender-Class:Subject:From:To:Cc:References:Date:In-Reply-To; b=OIPTBAMHUFmqr7B5q1JXlf5HekWe/xk6njx6sD8ObXlqw10OHh7Ju6ekWlp0Ge+BJ fX5QPuoigIVRyGNjZCjtL124Bevhov8H0E0C6kMDxVhCPnBYlXKaEQaFYI2FQVF/BF Ofk4NNDstESNMr4Ds76LtnjvIitIDw/3ANp9OH/o= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.0.241] ([89.79.191.25]) by mail.gmx.com (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1M1ps8-1jU6JC3KaO-002FMs; Fri, 24 Apr 2020 11:16:38 +0200 Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> Autocrypt: addr=n54@gmx.com; prefer-encrypt=mutual; keydata= mQINBFVwUF8BEADHmOg7PFLIcSDdMx5HNDYr8MY2ExGfUTrKwPndbt3peaa5lHsK+UGoPG48 KiWkhEaMmjaXHFa7XgVpJHhFmNoJXfPgjI/sOKTMCPQ5DEHEHTibC4mta7IBAk+rmnaOF0k8 bxHfP8Qbls66wvicrAfTRXn/1ReeNc3NP4Sq39PoVHkfQTlnQiD4eAqBdq61B7DhzjhbKAZ4 RsNtLfB6eOv9qvmblUzs50ChYewM9hvn+c7MdDH+x2UXoSDhkBDkKcJGkX91evos8s9AuoEd D32X5e+bmdUGe8Cr3cAZJ8IEXR6F9828/kxzPliMsCWVRx1Fr28baCJOUGgFPNr3ips78m9+ Iw8PdQ101jU0dvucDFxw/1SCGYEZzV+O/237oRPuLCiDX5nhQoxf6dn9ukQleLBMNy2BLI4H g342NhF21HLA+KlyLOHaMKQCKzlal+zVNZTRTCh/ikMhsxWQjBfnqTDbMj85DnWwtump27SI qhPjUnS0a6MKoS/A+hbi64k5zztkvloELfCSrX7NyBTT0jgF2IGFIxZMrKCtQ9StcGMCV9MX tjcBy6fj7QMontEaIDRJEMjg8UIGw1B687OhalOv1ISia4xOWvpYAM6ipgqh6tBQmFzasL9P h1RtcVdFpFbhwVlr1Bly8c25gBNQHL5GUjLMn45LlQz50OzrkwARAQABtCdLYW1pbCBSeXRh cm93c2tpIChOZXRCU0QpIDxuNTRAZ214LmNvbT6JAjwEEwEIACYCGyMHCwkIBwMCAQYVCAIJ CgsEFgIDAQIeAQIXgAUCVbKGFwIZAQAKCRBLswjpsC52bIVpD/9i8npieI91xMIVvAHIUMeo cQO0IrNb+b/PuTj2qNemdwU7dhVJ7tVU5O1H2hI2M4rHGzjzDTxYzdxka0+A8CVEuvFdf6sF lXlXF0wM7rC6MoaB0QLAKxkZB5OtCILxLx7Bl2Y4cTPMU9v+qSL6yrdmhxogkufa4d6O9Zl/ FCWO2kH/BphKOiDtbyvdo2WULSLWP2IXN+0rCpNL4wbTfYLgV9JtMf8f0naGsdy7BFuDWsIE vtHh8dkQZP7dz6Qy67kx8negZaehSEgXwiae0HwQIn3xTQrFmBDALDsCgXuLWPTvglSkqTak uG+8X5fyTy0cU10TNKsU+rFBO+/xsUoIQOGrARwfWOIfJNPelzh/qigSnyNQNH8u5vFRPg9n fqB/AcvvAvtOYOo8EN9Ofx11gNj397NXc5HBQTrX6k5GNAeBWE3Ng1uO6scIwAS7qGnqGezU ABmQKLN37gmJiiGwhQAnSE6HILLBC5Z2b0S2rQsPKg8WgUmPa1YIcDkDtNB/LJcDsdU4Fm+r U2ksKU7tGD2ZfBt8H2nqfPKKeB+Uv/TBigjRvx/m70vjhqVxwCZA9Fqr9vkQkZroNfqP+3dp Z5V5fjmxO5abE2+IikSvFagwMtgx56i8Yrr2BzE8P5/S4cKq1kgyQoF+lVGDKRkUKCv1i4Fo aftnSxN8jTFZDbkCDQRVcFBfARAAutbzb8wAHGL5FPPWKErQ3Bsrp9RDTVqRzp7kBMOtd/14 MrOsWWyiml4XnvBYsJuhZWomFoeulcOXAPoTJ2vTw6erWYtdOiZymfQ3GMWpxzgkOVeNjsFF 9AQ38FCMKmIDs9dgn+KXSIXlZA34khKLd163SN5U/KHfYlnnocec31u+7rVa1hlF5DBSSpoi s8cs41foBYC5NsB/i+yqGIlfzHy7pC2u5kyQCuJotLH4y0rT5X+YBC7z7cqKChtILNDGw0ht qps29fwOGBE/FWmu8CbpSHj8pvg7uUyQcKbZbNChBfWtOJKdjnNs5VHf2ec95SwYmWl6Xz66 G892HY4ODtvl05/kh0qtdJd2oI4gJBsBx/N1585/3JYN4k78GIHTnML3xJydRRs9wwM3AXf/ iDGrMyY7qHQVXJLdO5nPe7LHg48vryCMkBnTMw5iNFPVCu5w1BaZyHxuS2HvpsgUtQoBa2QE P1jYNI+2qgoiIG4VQDhYtrD0WJaYdi/C2UVDxRy07dt73SV3RQ7ijOiUrz4g3/deFKY16/1k sE+N5Sc5Tjt84ChjO3nJRbHrQxd6dCOElR70e3R2yAuSB4m7LJpO20IB9CtWhlF/0AtfL91W O8GGGqLWB0Z04hmwRs/l8T4WWIlykLshbunWN6jsP1Y27FeilTZ+Pc9mYOEUFfEAEQEAAYkC HwQYAQgACQUCVXBQXwIbDAAKCRBLswjpsC52bPayD/9jE8mdNudrudSxbDB2vf8pU8r5flCq vIkfOdpZGV/Wx/Zx+HFHHp+b2aNBGSNyFTnph1Ku9bvg06vD0o+b7SdA1vrBgRG41t0OCIyf vejz65Xpin2EtCllcBM8zUCxHo43blON8fNw70P1Ec0loBp4TAal1MiXbB8kxRTRcEPVO9YF 9NPsFxycoWl0ZSvu4ESrQlrjRbVv+W0Fy/XqcQwEtDziFQHQXNRbTy8INPD49CsB7BkKRK+f 1vMmw7SxfsyEhyCgo9ZWfHb/+w9T5h+UhF87L/m287z7W+s4aCAPBzjbIWhtngGJJwIgiWdI I9J6YJLcHLvVZLw7xzA/flcjc0VfzOgJOJw3hBukHnEz7/CKgnABwyNu52P+PQbxVTiTjMKm 06eV732u9ZLD9ZgEazfmyGDHzsuzoXwsRnmcnbwYYAiynS+vfGl5oMtMa5qzsPhlzuvRlXHm zr8VjF8c9RThvyZyyHtWYAqNmBecMvM0whigjMeoAMJ5LtpyZgxjbHj1XnVdNBZgfJkOzsc/ twffi7RYphRx0d9z5UZ1Yl5Rvl05vTaJ7YhhNC7xuE8yGOQmDUsPDwWqO/eXUDErJjCOBR5b 0yILqRPYNT0Fj/th9gtEbZy1Gp0TVBkZM3tfjDRu43Pn6iSKObO/j0rNuq1LwN/EMxDifeZO 4XSbcg== Message-ID: Date: Fri, 24 Apr 2020 11:15:15 +0200 User-Agent: Mozilla/5.0 (X11; NetBSD amd64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1 MIME-Version: 1.0 In-Reply-To: <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="sezUzAWvbR2Yi5FLiNnGUVILWj31Gb46K" X-Provags-ID: V03:K1:NLY7ubXwr5jJaFhtstS2PViCexWCWlnnaZ55V82WofS2Zmwswrm 8feMweYmkdsyzeqh1hq9PlAoOLhEmtHN8ewOJrV8KHXmBD3HLTpob5vsin5jRmL+ZyFjtn4 pnB4wDhmZe/LV8E2OuF/GV4w9gDqJPAhuX2oFodgBYu8N93LCE1a6b3yobo0MU4HrGyXJfS 2iH6ZPQmm/FDzdxmExpuA== X-UI-Out-Filterresults: notjunk:1;V03:K0:8Xhqf3/I8Z8=:AMi4TH7Vm0M4SyN8tD1YGJ 2eIyggUMrCBLW+PqsYqcIkQb0fLlh7rBLoIWTjr/72r7ZzSq7qwQWRO2b1lmr24AVAa5GU5ld OnxYOFUjant9R7X/dcJhNwCkh1C6EapARwoWX84+DXXxcAQMcc1khD6/4J9y9gcXlIdFoRvmF GPoxqwWKcXc4DnUEMvCeBjApLG5umZj39wvHxkiiQO/HvwNfrfQxZTT4mo4ZZpTDF8yOBiJtU y5XuLBh2/3kpg8TIsvT4eNqDZTjJumL3lBdpaj118eWgPAdyUFvQLGG38MChaQYEtnn3E+Tbq j81695yVTs/pF6W47a4+Cn33bF4nyR1+4WMkN0vLM8Yya5O3JQnKxeAplr1F/mgE+SBICU+Gs hNSOXtsPm6ZIMfHT8Kjth2CrgZI48PGo9G8d66SHnDLNZnrZD6jwyJGRrjZs0Cl+mm1/3jFyG p68VABmDI2szUVbEUg0KYyKLxG7h2RDYFcmYa6LlacUeE6XZeIlH+VmrS8tW7IOsGxD/VVkrX t1QVc0VylIPAE4PUlsB/AuLAVrzkOdSnQ9D505yPpwq72JzqjlT7XOeqz0MtRdP1iQlkBWzHB IJL62OKEEFYmlEuqwVS8VCvgm8o6DT5sZv4vsKKg3H16f9M9QgHeuMlX2rKWd4VWd5ej/dfCb 0kz03941jnKs6A2RDBEmlcvGvWblnvY9qzh0W5NHPf7Zjx49mh9Ngr/W8Crl7P57B3hukURyN 6YWX1ZUxESc9HbEYTs5S1n9Q8QFNUybSF1JJkgrr6x3C+RJN4MO2xbAka+kIqtrtYA0vEqNDb +KQeXk6NaIqJ0TOWFkOqcgcP3OCFolFNB7lolOC8MEujPnfK/9yggk86dV/4g6GFAsTZ8IQre fIcHMLIyAaWfe6cPgbTQcmPF9FUlCTs8vN785MVPKwnMiaoXzeYcq0KVeKhXQA+7yBEppYRJR M7VDtU2Ll0lrqnXz/koP0le6sSIzGHhRxIV6bDWlnypQZIIFbrkrE1RZvHqy8e870RlY54959 B1pE5qONd7M2Hgv2TnDgsQVvRXBcGQ4VvbG160nQBuXHE5jUbMZzEEWml/1k6PkKr1IYXccli bhD3EHRjq0YdICWvVnVqnEiOsJbo+EIjx2aoBM8Yty3ByZKjkxDSSFFLUyYtrhcp52lCDasRf 6UDDyCRTuaNCnVnxNrb+TpOx0J57hLt0avYAcdnwtmDm9zFWE7f4orE1HXKznJXSStbx8= X-Spam-Status: No, score=-6.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, FREEMAIL_ENVFROM_END_DIGIT, FREEMAIL_FROM, RCVD_IN_BARRACUDACENTRAL, RCVD_IN_DNSWL_LOW, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 24 Apr 2020 09:16:56 -0000 This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --sezUzAWvbR2Yi5FLiNnGUVILWj31Gb46K Content-Type: multipart/mixed; boundary="bB7hTxRYtjvLnnFeNGvuQBRbIyKT8YyPx"; protected-headers="v1" From: Kamil Rytarowski To: Tom Tromey Cc: gdb-patches@sourceware.org Message-ID: Subject: Re: [PATCH] Move OpenBSD-only functions from inf-ptrace to obsd-nat References: <20200416165859.10785-1-n54@gmx.com> <877dyf19fw.fsf@tromey.com> <80fc0274-e8cd-069c-55ee-900a18f134c9@gmx.com> <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> In-Reply-To: <80b9fe68-872c-b57c-4eef-31ef2af077ff@gmx.com> --bB7hTxRYtjvLnnFeNGvuQBRbIyKT8YyPx Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable Ping? On 20.04.2020 12:30, Kamil Rytarowski wrote: > Ping? >=20 > I rely on this patch with my other to be submitted code. >=20 > On 16.04.2020 23:32, Kamil Rytarowski wrote: >> On 16.04.2020 22:07, Tom Tromey wrote: >>>>>>>> ">" =3D=3D Kamil Rytarowski writes: >>> >>>>> All major BSDs implement PT_GET_PROCESS_STATE, but they differ in >>>>> details and want to implement follow-fork functionality differently= =2E >>> >> >> Actually I was wrong in this detail. FreeBSD implements >> PT_SET_EVENT_MASK, but not PT_GET_PROCESS_STATE. >> >>>>> gdb/ChangeLog: >>> >>>>> * inf-ptrace.h (follow_fork, insert_fork_catchpoint) >>>>> (remove_fork_catchpoint, post_startup_inferior) >>>>> (post_attach): Move... >>> >>> I guess these aren't used on Linux, but what about rs6000-nat.c? Tho= se >>> are the only non-BSD users of inf_ptrace_target that I can see. >>> >>> I'm not a big fan of the current code, because makes methods conditio= nal >>> on this define. It would be better I guess to have an intermediate >>> subclass for this situation. That would make it clear what code does= or >>> does not rely on this. >>> >> >> Personally, I would like to see more separation of OS specific feature= s >> into OS-private files. >> >>> You don't have to do that, but I don't think we can put this in witho= ut >>> knowing about the rs6000-nat case. >>> >>> Tom >>> >> >> IBM RS/6000 is AIX and it does not support PT_GET_PROCESS_STATE. At >> least not in the versions I could check. >> >> There was however support for PT_GET_PROCESS_STATE in HPUX, but HPUX >> handling was removed from GDB in 2015. >> >=20 >=20 --bB7hTxRYtjvLnnFeNGvuQBRbIyKT8YyPx-- --sezUzAWvbR2Yi5FLiNnGUVILWj31Gb46K Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEELaxVpweEzw+lMDwuS7MI6bAudmwFAl6iriMACgkQS7MI6bAu dmwvFxAAucux6y0W+P0HoJUeyXw3W8KpYyS5EiKR6YzejDKTIZnTGhQ8KfE0VroH jd+ZSROdlRiOBVlvU1eX0OwuG35zsKRxd0n9vAda6+1DbfCIrC7/uHZkxsQ13BNZ P6SZTVAh+BPWAibOJ56XFnlI9C2uDAaZaADGUOGvS2I2I6vUAnfv1rpKL9fJfqen jp87xe8ofefhw9bPplXDDKC6vXoIzdFAUYjdEWB6vDGmJutRqMUjMG9udoA8XlkY XUErUv4i3Jgfus59zEcAjkTnqCrFRbo3nWEbo6YIOS/fzq9bQX/+HmwWZ8y7vAHa kdzRJ69IC6sogAjckQ80mNdSjRp9D/kXbgGDNDu5GJ8NjILYCPvJBAVwVHRSGFDt 2k5a/ohFXpBzctxR0DlbGDfBeoBKPYLtZDcERKfNLXtEY0noQKJnlo5vZnUYSL3u woMJqS/u/maM1wmvoi7bYWp6k/Gk623FK9je2OJdRayWf+RoORghNISn1oWzLECY W19kvWYD7dNlmarEbVH7g1ic164/LpkPp7g3TInBttRMH11QENYN8Z7JZr5gaY2+ 9LsK1TOPwl7KZrqIr7MAaHX1yH9H7Ab+M8nH+6TeUVCLhq0Gw6NQs/BowCx3Vcam xvrrsI5MBSNJMWs1/UZd69A7r/+rijITybed5fdgQPkvvJmfoCE= =LekE -----END PGP SIGNATURE----- --sezUzAWvbR2Yi5FLiNnGUVILWj31Gb46K--