From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 52102 invoked by alias); 31 Aug 2018 11:21:37 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 52091 invoked by uid 89); 31 Aug 2018 11:21:36 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy=automate, updategnulibsh, update-gnulib.sh, UD:update-gnulib.sh X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 31 Aug 2018 11:21:35 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id D214040241DE; Fri, 31 Aug 2018 11:21:33 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2FD7110D16BA; Fri, 31 Aug 2018 11:21:30 +0000 (UTC) Subject: Re: [PATCH] Update gnulib/Makefile.in:aclocal_m4_deps To: Sergio Durigan Junior , Simon Marchi References: <20180830155724.20000-1-sergiodj@redhat.com> <72e6edf3ddf2c9994c5e5d3ebfbfb171@polymtl.ca> <87bm9jiq05.fsf@redhat.com> Cc: GDB Patches , Tom Tromey From: Pedro Alves Message-ID: Date: Fri, 31 Aug 2018 11:21:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <87bm9jiq05.fsf@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00850.txt.bz2 On 08/30/2018 09:00 PM, Sergio Durigan Junior wrote: > On Thursday, August 30 2018, Simon Marchi wrote: > >> On 2018-08-30 11:57, Sergio Durigan Junior wrote: >>> $(srcdir)/aclocal.m4: @MAINTAINER_MODE_TRUE@ $(aclocal_m4_deps) >>> cd $(srcdir) && $(ACLOCAL) $(ACLOCAL_AMFLAGS) >> >> This looks good to me, the set of m4 files listed here matches the >> list of actual m4 files in import/m4. Follow-up question, could we >> use $(wildcard ...) instead of listing them by hand? > > Yeah, I think that could work. That's basically what I did to generate > this list: "ls *.m4". If you want, I can edit the patch and make it use > $(wildcard) before pushing it. > Really not sure that's a good idea. We don't use $wildcard for listing .c files either, for example, and I think for good reason. It makes the set of files to build dependent of what you happen to have or not have locally, instead of determined statically. That in general affects development, changing git branches, etc. Consider that GDB even links successfully if you miss including/linking some .c file in the build, given the _initialize_foo registration mechanism. Maybe not so much an issue with the m4 files, but I'd think a more principle approach to automate this would be to make the update-gnulib.sh script generate/update a Makefile fragment file that contained the aclocal_m4_deps m4 files list, check that file into the tree, and then gdb/gnulib/Makefile.in would source/include that fragment file. Thanks, Pedro Alves