RE: [PATCH v4 2/2] gdb/breakpoint: add flags to 'condition' and 'break' commands to force condition

Aktemur, Tankut Baris via Gdb-patches
2020-12-15T11:20:52Z

On Thursday, December 10, 2020 9:30 PM, Tom Tromey wrote:
> >>>>> "Pedro" == Pedro Alves <pedro@palves.net> writes:
>
> Pedro> Also, I find it hard to justify that this works:
>
> Pedro> (gdb) break main -force-condition if foo
>
> Pedro> while this doesn't:
>
> Pedro> (gdb) break main -qualified
>
> I wasn't really paying attention to this, but adding suffixes to
> linespecs is generally a problem. For example this will also mis-parse,
> I think, if one uses the '*' form:
>
> break *whatever -force-condition
>
> since this will parse as subtraction operators.
>
> That is, adding a suffix ordinarily requires updating all the parsers
> (really the lexers). Option-style prefixes are better for this reason.
>
> Pedro> Anyhow, the patch is in, and I'm not going to ask to revert it. Onward.
>
> IMO it should be fixed for the future.

I'll investigate how this can be fixed, but please expect delays.

Thanks
-Baris

Intel Deutschland GmbH
Registered Address: Am Campeon 10-12, 85579 Neubiberg, Germany
Tel: +49 89 99 8853-0, www.intel.de
Managing Directors: Christin Eisenschmid, Gary Kershaw
Chairperson of the Supervisory Board: Nicole Lau
Registered Office: Munich
Commercial Register: Amtsgericht Muenchen HRB 186928