From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25811 invoked by alias); 5 Sep 2017 10:19:30 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 25798 invoked by uid 89); 5 Sep 2017 10:19:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 05 Sep 2017 10:19:25 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 254B13680F; Tue, 5 Sep 2017 10:19:24 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 254B13680F Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 7A57E7B25B; Tue, 5 Sep 2017 10:19:23 +0000 (UTC) Subject: Re: [PATCH] eval.c:evaluate_subexp_standard: Factor out function call handling To: Yao Qi References: <1504563210-2521-1-git-send-email-palves@redhat.com> <20170905094312.GC8425@1170ee0b50d5> Cc: gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Tue, 05 Sep 2017 10:19:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20170905094312.GC8425@1170ee0b50d5> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-09/txt/msg00082.txt.bz2 On 09/05/2017 10:43 AM, Yao Qi wrote: > On 17-09-04 23:13:30, Pedro Alves wrote: >> While working on the no-debug-info debugging improvements, I found >> evaluate_subexp_standard's function call code unnecessarily long and >> hard to navigate and debug. The use of goto doesn't help either. > > It is good to shorten the long function. Patch looks good to me. > >> +/* Evaluate a function call. The function to be called is in >> + argvec[0]. FUNCTION_NAME is the name of the function, if known. > > s/argvec/ARGVEC/ ? > and better to document that argvec[1] - argvec[nargs] are arguments > passed to the function. > Indeed. I'll push it in with this comment: /* Evaluate a function call. The function to be called is in ARGVEC[0] and the arguments passed to the function are in ARGVEC[1..NARGS]. FUNCTION_NAME is the name of the function, if known. DEFAULT_RETURN_TYPE is used as the function's return type if the return type is unknown. */ Thanks, Pedro Alves