From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-134302-listarch-gdb-patches=sources.redhat.com@sourceware.org>
Received: (qmail 26287 invoked by alias); 25 Oct 2016 19:50:52 -0000
Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm
Precedence: bulk
List-Id: <gdb-patches.sourceware.org>
List-Subscribe: <mailto:gdb-patches-subscribe@sourceware.org>
List-Archive: <http://sourceware.org/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sourceware.org>
List-Help: <mailto:gdb-patches-help@sourceware.org>, <http://sourceware.org/ml/#faqs>
Sender: gdb-patches-owner@sourceware.org
Received: (qmail 26277 invoked by uid 89); 25 Oct 2016 19:50:51 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,RCVD_IN_DNSWL_NONE,SPF_PASS autolearn=ham version=3.3.2 spammy=1138, yours
X-HELO: relay1.mentorg.com
Received: from relay1.mentorg.com (HELO relay1.mentorg.com) (192.94.38.131) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 25 Oct 2016 19:50:50 +0000
Received: from svr-orw-mbx-03.mgc.mentorg.com ([147.34.90.203])	by relay1.mentorg.com with esmtp 	id 1bz7kG-0000NX-IS from Luis_Gustavo@mentor.com ; Tue, 25 Oct 2016 12:50:48 -0700
Received: from [172.30.1.187] (147.34.91.1) by svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203) with Microsoft SMTP Server (TLS) id 15.0.1210.3; Tue, 25 Oct 2016 12:50:45 -0700
Reply-To: Luis Machado <lgustavo@codesourcery.com>
Subject: Re: [PATCH, v4] PR 20569, segv in follow_exec
References: <1477415521-22010-1-git-send-email-lgustavo@codesourcery.com> <645baeb5-e813-d97d-fcd0-d0c7ea7bf5ba@redhat.com> <3f775c2e-6519-40c3-78da-7da06a940bce@codesourcery.com> <90c686ab-090e-fead-5a72-a5d507b50ab7@redhat.com> <3ecde577-fd7b-78ed-3d41-2777301cd390@codesourcery.com> <87c593b9-b811-d104-65fc-4225d46d5581@codesourcery.com> <5b758a61-90ec-19c3-d2db-7d88aec272f5@palves.net>
To: Pedro Alves <pedro@palves.net>, <gdb-patches@sourceware.org>
CC: <sandra@codesourcery.com>
From: Luis Machado <lgustavo@codesourcery.com>
Message-ID: <a2999518-0a57-7261-ac09-93cc143efa2b@codesourcery.com>
Date: Tue, 25 Oct 2016 19:50:00 -0000
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0
MIME-Version: 1.0
In-Reply-To: <5b758a61-90ec-19c3-d2db-7d88aec272f5@palves.net>
Content-Type: text/plain; charset="windows-1252"; format=flowed
Content-Transfer-Encoding: 8bit
X-ClientProxiedBy: svr-orw-mbx-04.mgc.mentorg.com (147.34.90.204) To svr-orw-mbx-03.mgc.mentorg.com (147.34.90.203)
X-IsSubscribed: yes
X-SW-Source: 2016-10/txt/msg00713.txt.bz2

On 10/25/2016 02:46 PM, Pedro Alves wrote:
> On 10/25/2016 08:41 PM, Luis Machado wrote:
>
>> Going back to the flags problem, maybe adding "add_flags" as argument to
>> symbol_file_add_main_1, just like symbol_file_add, and appending those
>> flags to the existing flag variable there would make things work?
>
> I've now cleaned up that patch, and simply rebasing yours on top
> shows what I meant:
>
>  src/gdb/exec.c:184:59: error: could not convert ‘flags’ from
> ‘symfile_add_flags {aka enum_flags<symfile_add_flag>}’ to
> ‘objfile_flags {aka enum_flags<objfile_flag>}’
>      symbol_file_add_main_1 (exec_file_host, from_tty, flags);
>                                                            ^

Ah yes. Confusing names in those functions.

>  Makefile:1138: recipe for target 'exec.o' failed
>
> I.e., the existing flags parameter to symbol_file_add_main_1
> is _not_ a symfile_add_flags.  We can't just use it as is.
>
> So yes, I think so.  I was just doing that here, this minute.
> But I was replacing the from_tty parameter symbol_file_add_main
> with a symfile_add_flags instead.  Let me do that and send
> both patches.
>

Oki!

Thanks.