From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by sourceware.org (Postfix) with ESMTPS id 6C7CE3851C3A for ; Wed, 16 Sep 2020 11:01:19 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 6C7CE3851C3A Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=alves.ped@gmail.com Received: by mail-wr1-f53.google.com with SMTP id c18so6407151wrm.9 for ; Wed, 16 Sep 2020 04:01:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=UWYnPIgl1jDpDPnaCmNkSYzS9TFpi7Ks96CSR39Q6Cs=; b=OeWeG3HvopqMir2EYstq0Ie3ErHsrXs/63xWWj3uV0N2TKKGQUPGznWKd5vWZ6i+13 MNFYfTkjPHXOQxVctbmfm7w/4GIreQeIn2OOa1iaHnB81Am7JtWVQg0veXpvwazZ+qCN kYZdTfDBd47vmAUno/79cWUcE5WtMeXkM3ktepKwvhb8jO9o/Ss2zlQqhA5gu98VUCWe 9M935NR3tmU68+R4oP6A7TB2x+izxYzdToe+C5VRCEukTqG+JvwWKnf7yHAzyFd1A95p PfXy2jS2DrAVUcv3klt2vvuNfyEyZXl+wtp5q1d+dslLZSGK4Ox0W3GREPYIFWDabw34 yD9g== X-Gm-Message-State: AOAM530tjy8FeXeCo1XE1vuOME0fm1Z4XIOS/AnHcoJUk0T6lg6NeAn8 sOulzn56IIWnm2LbS7Yk3a+938Lur0Irqg== X-Google-Smtp-Source: ABdhPJy3aWSCFSLIkAIPCmN5Hayz1NzmVWYFpomOwueJEHWqJebto9pi0LASWEY/4x28wumxNNCEJg== X-Received: by 2002:a5d:4ccb:: with SMTP id c11mr25993203wrt.159.1600254077873; Wed, 16 Sep 2020 04:01:17 -0700 (PDT) Received: from ?IPv6:2001:8a0:f905:5600:eefd:c63:53e0:3e8a? ([2001:8a0:f905:5600:eefd:c63:53e0:3e8a]) by smtp.gmail.com with ESMTPSA id y6sm32673727wrn.41.2020.09.16.04.01.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 16 Sep 2020 04:01:16 -0700 (PDT) Subject: Re: [pushed] gdb: remove TYPE_INSTANCE_FLAGS To: Simon Marchi , Luis Machado , gdb-patches@sourceware.org References: <20200914213112.19593-1-pedro@palves.net> <20200914213112.19593-2-pedro@palves.net> <3db19da5-af04-2f7f-52ed-c496c5b3e791@linaro.org> <696a7481-60f0-859c-c0d0-590c6ae69689@simark.ca> From: Pedro Alves Message-ID: Date: Wed, 16 Sep 2020 12:01:15 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <696a7481-60f0-859c-c0d0-590c6ae69689@simark.ca> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, FREEMAIL_FORGED_FROMDOMAIN, FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS, KAM_DMARC_STATUS, NICE_REPLY_A, RCVD_IN_DNSWL_NONE, RCVD_IN_MSPIKE_H2, SPF_HELO_NONE, SPF_PASS, TXREP autolearn=no autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Sep 2020 11:01:20 -0000 On 9/16/20 3:50 AM, Simon Marchi wrote: > On 2020-09-15 5:28 p.m., Luis Machado wrote: >> I think you missed adjusting the stale references in gdb/gdb-gdb.py.in. > > I wasn't sure what you meant, but I suppose it is: > > 115 fields.append("instance_flags = %s" > 116 % TypeFlagsPrinter(self.val['instance_flags'])) > > ? Indeed, instance_flags there should be changed to m_instance_flags. My fault then, sorry about that. > Does the > patch below look good? Looks fine to me. Thanks for fixing it. Pedro Alves