From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 3N8EA00s0V/VHgAAWB0awg (envelope-from ) for ; Wed, 09 Dec 2020 14:58:05 -0500 Received: by simark.ca (Postfix, from userid 112) id F38561F0A9; Wed, 9 Dec 2020 14:58:04 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 67C1C1E590 for ; Wed, 9 Dec 2020 14:58:04 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id BB7653850409; Wed, 9 Dec 2020 19:58:03 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org BB7653850409 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1607543883; bh=PdzE3Laf6I+qU6wShOpiL4uSYFBr0PeboNsJMv9pnYg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=jLJKYCSJuUE4pEXUGhtbY4TMbU9/WwDWihs/7EdZrLoKorjDyMXzyvGfHE/PsA6Ih vh3iJrnElEFKNSVMjuCiVWO5gdM7KqR/6dDoKoXMn2sExewQpbJHv2W/3CjCSlnjoK 0Gtxk7Kc9M2xDLVBrjAZQHnPTEYEjMA2ZkJMRu90= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id D9A5F3850409 for ; Wed, 9 Dec 2020 19:58:00 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org D9A5F3850409 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 0B9Jvs0M022718 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Wed, 9 Dec 2020 14:57:59 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 0B9Jvs0M022718 Received: from [10.0.0.11] (173-246-6-90.qc.cable.ebox.net [173.246.6.90]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id F06351E590; Wed, 9 Dec 2020 14:57:53 -0500 (EST) Subject: Re: [PATCH 4/4] gdb: fix value_subscript when array upper bound is not known To: Joel Brobecker , Simon Marchi via Gdb-patches References: <20201123162120.3778679-1-simon.marchi@efficios.com> <20201123162120.3778679-5-simon.marchi@efficios.com> <20201206075437.GC327270@adacore.com> Message-ID: Date: Wed, 9 Dec 2020 14:57:53 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.3 MIME-Version: 1.0 In-Reply-To: <20201206075437.GC327270@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Wed, 9 Dec 2020 19:57:54 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: Simon Marchi Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2020-12-06 2:54 a.m., Joel Brobecker wrote: > Other than that, the change looks OK to me. > > I believe, between the impact of the fix, the fact that it is > a recent regression, and the relatively straightforward nature > of your patch series, I believe it will be safe to backport to > the gdb-10-branch. FYI, I pushed this to the master branch, and I am in the process of backporting it to the gdb-10-branch. There are a few conflicts, so I'll give it a test run before pushing it there. Simon