From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69142 invoked by alias); 12 Apr 2017 02:25:35 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 68321 invoked by uid 89); 12 Apr 2017 02:25:30 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.4 required=5.0 tests=AWL,BAYES_00,SPF_HELO_PASS,SPF_SOFTFAIL autolearn=no version=3.3.2 spammy= X-HELO: simark.ca Received: from simark.ca (HELO simark.ca) (158.69.221.121) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 12 Apr 2017 02:25:29 +0000 Received: by simark.ca (Postfix, from userid 33) id 747A51E48D; Tue, 11 Apr 2017 22:25:29 -0400 (EDT) To: Tom Tromey Subject: Re: [RFA v2 16/17] Add a constructor and destructor to linespec_result X-PHP-Originating-Script: 33:rcube.php MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII; format=flowed Content-Transfer-Encoding: 7bit Date: Wed, 12 Apr 2017 02:25:00 -0000 From: Simon Marchi Cc: gdb-patches@sourceware.org In-Reply-To: <20170411150112.23207-17-tom@tromey.com> References: <20170411150112.23207-1-tom@tromey.com> <20170411150112.23207-17-tom@tromey.com> Message-ID: X-Sender: simon.marchi@polymtl.ca User-Agent: Roundcube Webmail/1.2.4 X-IsSubscribed: yes X-SW-Source: 2017-04/txt/msg00307.txt.bz2 On 2017-04-11 11:01, Tom Tromey wrote: > linespec_result is only ever allocated on the stack, so it's > relatively easy to convert to having a constructor and a destructor. > This patch makes this change. This removes some cleanups. LGTM, though there are still some references in comments to destroy_linespec_result that could be cleaned up. Simon