From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 63184 invoked by alias); 8 Nov 2017 16:10:26 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 61909 invoked by uid 89); 8 Nov 2017 16:10:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=convince, central, me, our X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 08 Nov 2017 16:10:20 +0000 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 719D62CE95E; Wed, 8 Nov 2017 16:10:19 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 719D62CE95E Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=fail smtp.mailfrom=palves@redhat.com Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id 195FB5FFEF; Wed, 8 Nov 2017 16:10:17 +0000 (UTC) Subject: Re: [PATCH 25/40] Introduce lookup_name_info and generalize Ada's FULL/WILD name matching To: Joel Brobecker References: <1496406158-12663-1-git-send-email-palves@redhat.com> <1496406158-12663-26-git-send-email-palves@redhat.com> <596E6C31.1060908@redhat.com> <918c8d65-4c5d-7c04-c2a3-736b7a20d454@redhat.com> <1fa29e48-cbcd-0b88-41ad-f2bd05650b00@redhat.com> <16094f7b-9416-5cda-78fb-7a8d48043e66@redhat.com> <9ab010e3-5873-494b-4296-2c46f847f080@redhat.com> <2b13a06f-d6d5-45d1-c0a0-0efb289a9131@redhat.com> <20171101153810.dc5r27oen5edfwbe@adacore.com> Cc: Keith Seitz , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Wed, 08 Nov 2017 16:10:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.4.0 MIME-Version: 1.0 In-Reply-To: <20171101153810.dc5r27oen5edfwbe@adacore.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2017-11/txt/msg00176.txt.bz2 On 11/01/2017 03:38 PM, Joel Brobecker wrote: > Hi Pedro, > >> This patch touches the Ada code a good deal. It's main goal is >> to generalize Ada's FULL/WILD name matching, so that C++ can do >> something very similar. Let me know if you'd like to review it. >> I've been holding on moving forward with this >> series because this is a central patch on top of which the >> rest of the series sits on. > > Thanks for drawing my attention to this patch. Overall, it looks > pretty neat :) and it starts a nice simplification of some of > the code in ada-lang. Thank you! I admit I didn't read the patch > in complete details, but enough to understand how it works and > convince myself that it should actually work. I've also run it > through our testsuites and found no regressions, neither with > this patch, nor the series as a whole. > > So, to summarize, this looks good to me! Phew! I admit that I was worried about your internal testsuites. :-) Thanks much, I've pushed this one in now (along with a few of the follow ups, but not the whole series yet). Thanks, Pedro Alves