From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id OAEIGcvxcGSN4xQAWB0awg (envelope-from ) for ; Fri, 26 May 2023 13:52:11 -0400 Received: by simark.ca (Postfix, from userid 112) id 6371A1E11E; Fri, 26 May 2023 13:52:11 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (2048-bit key; secure) header.d=freebsd.org header.i=@freebsd.org header.a=rsa-sha256 header.s=dkim header.b=bztwPp73; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-10.0 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_HI autolearn=unavailable autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ECA261E111 for ; Fri, 26 May 2023 13:52:10 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 8894A3856DD5 for ; Fri, 26 May 2023 17:52:09 +0000 (GMT) Received: from mx2.freebsd.org (mx2.freebsd.org [96.47.72.81]) by sourceware.org (Postfix) with ESMTPS id EE22E3858C2C for ; Fri, 26 May 2023 17:51:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EE22E3858C2C Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=FreeBSD.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=FreeBSD.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (4096 bits)) (Client CN "mx1.freebsd.org", Issuer "R3" (verified OK)) by mx2.freebsd.org (Postfix) with ESMTPS id 4QSXYS0Q1Nz46pk; Fri, 26 May 2023 17:51:56 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R3" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4QSXYR6mvQz4DYH; Fri, 26 May 2023 17:51:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685123516; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/aBS33x7o8fuQIbngcCk2FJHzg2mKd+MfPW6nsJ+5yM=; b=bztwPp73zR2geiK0hz+xGdLMPhBl4nOWGkncYc63/y0WNPcA/iR6edeahX8bgwkRTmCy67 eCjf8HCh4c1If4XwLMOp36IHyOhrQFnQGKeMKqGHNPPNmsxiRm9lwZoi6KVuZ4EtnYb06A TKThjUbBniIlbyc6/yntT2rf1GIv9L6UNEf0/VnTx4oL3h32chF5tVUMaNbkNeD9jwkKu4 0X29p4S0YmR8bnb9RDc10H8/75vb5/CKyPy3nQIgvWGNxQOgu7xMcvW+aSD+CM3WP21QOp k2miCFzq/g/tK5bVS5oGiOLzbm8lN/7BoXQ/9awahG0TqyddCpSypAeUsKe+Tg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1685123515; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/aBS33x7o8fuQIbngcCk2FJHzg2mKd+MfPW6nsJ+5yM=; b=VjKZllXommcGBd6kDHSSgKxGRScEUp2vEwBx/O/Ex+ChKR7nwe9TcMw1gIWygapTbAUIjo 3AMH9Yj/Ny65E53AneUVLtGqEqJJS57noatWUHmpl2kzIBwng9TY/NS+PE0YxcDXYamx68 qLYgQq/OjnqPBIeFgHJ8JqwAmWLZqWdhFSKToetic8qr6frjWEkBtsUrkepVYdXk0ndZo0 B6gk5cWqfgAoZJqRKeKm1OfeD8wbLnBt+FSrRXubhxDnmK/pzSsWbpFb00oN4ISeF64YH5 0ndQ7cDAx5/RJ9Iq457FBrbp1iqPxg/dOyWspE8q7tdHhA9RKiMOkAs7RtwipQ== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1685123516; a=rsa-sha256; cv=none; b=tXEGAjjJ4dtnZLJe/MP7CvudNWV6svoFvlIg9xKOZ0A33rXlUuL01Rlc1Fi3gYnspFIPyZ t9HJX/TeqHSQff+yaYLcmSm8tQnYkiTjp0VyYDzS8hfOYwYl18or8zFYNMXMuWlJ93gJOZ 0QSTkAvwEYCGKP9Dkgcn/Qq4AUpBbyIhydZphBjJj1k0WOQo2+VyyDRZZWCvoYHPxhGZlO o0on0vqQ/BmOyobAPGrRQawYRC1mUKC5fVAAhGU4RF8kgwHHU5mPQEcqAtGqCeFAPTDSwZ jkrAebYRAyffUmm/lhgJ6mv7AX94IfKSzIIfIggjUfApekOtyAKkkBHPJCXb3A== Received: from [IPV6:2601:648:8680:16b0:28bd:79fa:758b:79b7] (unknown [IPv6:2601:648:8680:16b0:28bd:79fa:758b:79b7]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (Client did not present a certificate) (Authenticated sender: jhb) by smtp.freebsd.org (Postfix) with ESMTPSA id 4QSXYR3y2zz15vt; Fri, 26 May 2023 17:51:55 +0000 (UTC) (envelope-from jhb@FreeBSD.org) Message-ID: Date: Fri, 26 May 2023 10:51:53 -0700 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v3] gdb tests: Allow for "LWP" in thread IDs from info threads. Content-Language: en-US From: John Baldwin To: Simon Marchi , gdb-patches@sourceware.org References: <20230418201305.61272-1-jhb@FreeBSD.org> <10ba4b3e-19e0-2889-47de-67667db21af1@simark.ca> In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/12/23 7:15 AM, John Baldwin wrote: > On 5/9/23 1:56 PM, John Baldwin wrote: >> On 5/9/23 12:01 PM, Simon Marchi wrote: >>> On 4/18/23 16:13, John Baldwin wrote: >>>> Several tests assume that the first word after a thread ID in 'info >>>> threads' output is "Thread". However, several targets use "LWP" >>>> instead such as the FreeBSD and NetBSD native targets. The Linux >>>> native target also uses "LWP" if libthread_db is not being used. >>>> >>>> Add a tdlabel_re global variable as a regular-expression for a thread >>>> label in `info threads' that matches either "thread" or "LWP". >>>> >>>> Some other tests in the tree don't require a specific word, and >>>> some targets may use other first words (e.g. OpenBSD uses "thread" >>>> and Ravenscar threads use "Ravenscar Thread"). >>> >>> That LGTM, I don't really see another way: >>> >>> Approved-By: Simon Marchi >>> >>> One nit is that I prefer to use the ${::tdlabel_re} notation instead of >>> the global keyword, but it's not a dealbreaker. >>> >>> And just one question: >>> >>>> diff --git a/gdb/testsuite/gdb.trace/report.exp b/gdb/testsuite/gdb.trace/report.exp >>>> index 14db2511d40..a5b7ccf4ba5 100644 >>>> --- a/gdb/testsuite/gdb.trace/report.exp >>>> +++ b/gdb/testsuite/gdb.trace/report.exp >>>> @@ -380,7 +380,7 @@ proc use_collected_data { data_source } { >>>> >>>> # There is always a thread of an inferior, either a live one or >>>> # a faked one. >>>> - gdb_test "info threads" "\\* ${decimal} (process|Thread) \[0-9\.\]+\[ \t\].*" >>>> + gdb_test "info threads" "\\* ${decimal} ${tdlabel_re} \[0-9\.\]+\[ \t\].*" >>> >>> This one said "process" as well, I guess it's not important? >> >> Hummm, it didn't regress on Linux, but on some other native target that >> doesn't support threads it might regress I guess. normal_pid_to_str >> uses "process " and is the defalt for target::pid_to_str. >> >> Probably tdlabel_re should permit "process" as a word as well: >> >> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp >> index 527c84599ca..6ded65e31c4 100644 >> --- a/gdb/testsuite/lib/gdb.exp >> +++ b/gdb/testsuite/lib/gdb.exp >> @@ -283,7 +283,7 @@ set inferior_exited_re "(?:\\\[Inferior \[0-9\]+ \\(\[^\n\r\]*\\) exited)" >> >> # A regular expression that matches the first word of a thread >> # description after the thread number info 'info threads' >> -set tdlabel_re "(Thread|LWP)" >> +set tdlabel_re "(process|Thread|LWP)" >> >> # A regular expression that matches a value history number. >> # E.g., $1, $2, etc. >> >> (I'd also have to reword the commit log a bit to mention this case if so.) > > Just to be sure, are you still ok with this patch with this tweak? Ping, here's the updated log message to match: gdb tests: Allow for "LWP" in thread IDs from info threads. Several tests assume that the first word after a thread ID in 'info threads' output is "Thread". However, several targets use "LWP" instead such as the FreeBSD and NetBSD native targets. The Linux native target also uses "LWP" if libthread_db is not being used. Targets that do not support threads use "process" as the first word via normal_pid_to_str. Add a tdlabel_re global variable as a regular-expression for a thread label in `info threads' that matches either "process", "Thread", or "LWP". Some other tests in the tree don't require a specific word, and some targets may use other first words (e.g. OpenBSD uses "thread" and Ravenscar threads use "Ravenscar Thread"). -- John Baldwin