From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id hprCAYuQzmAIdQAAWB0awg (envelope-from ) for ; Sat, 19 Jun 2021 20:49:15 -0400 Received: by simark.ca (Postfix, from userid 112) id ED1281F163; Sat, 19 Jun 2021 20:49:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-0.7 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 25EBB1E54D for ; Sat, 19 Jun 2021 20:49:14 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id A5E0D386FC08 for ; Sun, 20 Jun 2021 00:49:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org A5E0D386FC08 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1624150153; bh=t4CNcCUwceE2rCW4sgXdgAapBA13aiIbXAPF/Fm1iVI=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=cm5T3lo/nnL+tqV3aIoNJLt3fwavqqfIZb9Ts0ACuaIix61jB4/6r4dUlhWAKgxw2 8sRxP2c9ipsC3D0VoTwYpSZL8oNtDk50qCqDz5m9jGt3416VvTV11W+c1SnK/lKrUz QcG4BpV3/ZorUKzTggjNqVH+9URfjAE/oxNZgUV0= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id C77303858022 for ; Sun, 20 Jun 2021 00:48:54 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org C77303858022 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 15K0mlKi031065 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sat, 19 Jun 2021 20:48:52 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 15K0mlKi031065 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id 708391E54D; Sat, 19 Jun 2021 20:48:47 -0400 (EDT) Subject: Re: [PATCH v2] gdb/gdbserver: switch to AC_CONFIG_MACRO_DIRS To: Mike Frysinger , gdb-patches@sourceware.org References: <20210615054416.1232-1-vapier@gentoo.org> <20210618140342.16460-1-vapier@gentoo.org> Message-ID: Date: Sat, 19 Jun 2021 20:48:47 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210618140342.16460-1-vapier@gentoo.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 20 Jun 2021 00:48:47 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 2021-06-18 10:03 a.m., Mike Frysinger via Gdb-patches wrote: > These dirs don't use automake, so use AC_CONFIG_MACRO_DIRS to specify > ../config as a search dir for m4 macros. This allows removal of a lot > of hand-written m4_include's from acinclude.m4 files, and simplifies > use of `aclocal` or `autoreconf` as manual -I is not needed. > --- > v2: include comment in top of acinclude.m4 files. With this patch, I get: configure.ac:531: warning: AC_LIB_PREPARE_PREFIX is m4_require'd but not m4_defun'd ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... ../config/iconv.m4:104: AM_ICONV is expanded from... configure.ac:531: the top level configure.ac:531: warning: AC_LIB_RPATH is m4_require'd but not m4_defun'd ../config/iconv.m4:12: AM_ICONV_LINKFLAGS_BODY is expanded from... ../config/iconv.m4:23: AM_ICONV_LINK is expanded from... ../config/iconv.m4:104: AM_ICONV is expanded from... configure.ac:531: the top level To fix this, we'd need to keep these three lines: m4_include(../config/lib-ld.m4) m4_include(../config/lib-prefix.m4) m4_include(../config/lib-link.m4) If I bring them back, it's all clean. Simon