From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 6YhEM17rcmD4bgAAWB0awg (envelope-from ) for ; Sun, 11 Apr 2021 08:28:14 -0400 Received: by simark.ca (Postfix, from userid 112) id C4E091EF4F; Sun, 11 Apr 2021 08:28:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E35D51E789 for ; Sun, 11 Apr 2021 08:28:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 217E93890422; Sun, 11 Apr 2021 12:28:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 217E93890422 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1618144093; bh=Xeecbf+fI+WF/VU8LyWj8r7MWNYe+LuLKpSJz9xIkgQ=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To:Cc: From; b=Y+fJJpLSliuVKZRHr4qYTB7DGN04rjOZKB4duQz7VxORu772avNOrFxXMKBiECOWM UQHzdAIroA/7BstVIrVaAhfXrYEkuLm5PMEoM4nXJNHLKbBwVVwh37YEj3wekIq4d3 tApgmLB/PSB47MzYS+XCdQniH28yNoCxrm9NM5WY= Received: from smtp.polymtl.ca (smtp.polymtl.ca [132.207.4.11]) by sourceware.org (Postfix) with ESMTPS id 5E97E3846411 for ; Sun, 11 Apr 2021 12:28:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5E97E3846411 Received: from simark.ca (simark.ca [158.69.221.121]) (authenticated bits=0) by smtp.polymtl.ca (8.14.7/8.14.7) with ESMTP id 13BCRuHf019455 (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Sun, 11 Apr 2021 08:28:00 -0400 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp.polymtl.ca 13BCRuHf019455 Received: from [10.0.0.11] (192-222-157-6.qc.cable.ebox.net [192.222.157.6]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPSA id C30541E789; Sun, 11 Apr 2021 08:27:55 -0400 (EDT) Subject: Re: Subtle problems with "info sharedlibrary" on MS-Windows To: Eli Zaretskii References: <83czw7p4nd.fsf@gnu.org> <777379173.1335754.1615393830518@mail.yahoo.com> <83mtvbne96.fsf@gnu.org> <259022839.1083386.1615397702855@mail.yahoo.com> <83y2dwbow6.fsf@gnu.org> <83lf9vbljw.fsf@gnu.org> <87sg3ygp1d.fsf@tromey.com> <834kge57z0.fsf@gnu.org> <91c6b291-f9f3-0ee9-1ef1-31ba6bb65326@polymtl.ca> <83v98t47po.fsf@gnu.org> Message-ID: Date: Sun, 11 Apr 2021 08:27:55 -0400 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 MIME-Version: 1.0 In-Reply-To: <83v98t47po.fsf@gnu.org> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-Poly-FromMTA: (simark.ca [158.69.221.121]) at Sun, 11 Apr 2021 12:27:56 +0000 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Simon Marchi via Gdb-patches Reply-To: Simon Marchi Cc: tom@tromey.com, gdb-patches@sourceware.org Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" On 2021-04-11 3:10 a.m., Eli Zaretskii wrote: >> Cc: gdb-patches@sourceware.org >> From: Simon Marchi >> Date: Sat, 10 Apr 2021 18:56:05 -0400 >> >>> --- gdbserver/win32-low.cc~ 2021-03-25 03:47:10.000000000 +0200 >>> +++ gdbserver/win32-low.cc 2021-04-10 21:05:48.677425000 +0300 >>> @@ -1165,11 +1165,13 @@ load_psapi (void) >>> >>> #ifndef _WIN32_WCE >> >> I see that this patch deals with _WIN32_WCE. We removed support for >> WinCE in 84b300de3666 ("gdbserver: remove support for ARM/WinCE"). It >> looks like I failed to remove the WinCE-related core from win32-low.cc >> (I guess I didn't know about the _WIN32_WCE macro then). Would you mind >> if we first removed that unncecessary code first? That would make your >> patch simpler. > > I'd actually prefer it the other way around, for 2 reasons: (a) the > patch for windows-nat.c is already in, so it would make sense to fix > gdbserver ASAP; (b) I built with the patch a recent snapshot of master > where these conditions are still present, and I would like to avoid > the need to build yet another snapshot just for this small change. Ok, now that I re-read the patch, I realize that the _WIN32_WCE macro doesn't add much complexity, I thought it was worst at first. So, the patch LGTM, with a proper commit message and ChangeLog entry of course. Simon