On 10/24/18 10:50 PM, Philippe Waroquiers wrote:
> On Wed, 2018-10-24 at 17:29 +0100, Pedro Alves wrote:
>> On 10/24/2018 12:13 PM, Tom de Vries wrote:
>>> Hi,
>>>
>>> When running valgrind-db-attach.exp with valgrind version 3.13.0, we get:
>>> ...
>>> PASS: gdb.base/valgrind-db-attach.exp: spawn valgrind
>>> valgrind: Unknown option: --db-attach=yes
>>> valgrind: Use --help for more information or consult the user manual.
>>> ERROR: Process no longer exists
>>> UNRESOLVED: gdb.base/valgrind-db-attach.exp: valgrind started
>>> ...
>>>
>>> The valgrind option --db-attach has been deprecated in version 3.10.0, and
>>> removed in version 3.11.0.
>>>
>>
>> But was it replaced with / renamed to something else equivalent,
>> or the functionality completely eliminated?
> --db-attach option functionality was removed, as it was not very
> reliable and had a bunch of limitations e.g. not supporting threads.
> 
> Instead, the gdbserver embedded in valgrind allows the user debug a process
> when valgrind reports an error.
> 
> I have put on my list of things to do to convert valgrind-attach
> test to use vgdb (but the conversion is probably not trivial).

The valgrind-db-attach.exp test-case is very similar to the
valgrind-infcall.exp test-case (using vgdb), so I gave it a try by
putting the two alongside, and doing a copy/paste/replace.

OK for trunk (perhaps with a rename to valgrind-bt.{exp,c})?

[ Or perhaps first factor out a vgdb_start/stop or some such from
valgrind-disp-step.exp and valgrind-infcall.exp, and then use those
procs in valgrind-db-attach.exp instead? ]

Thanks,
- Tom