From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id HiNnEllt0mgCGg8AWB0awg (envelope-from ) for ; Tue, 23 Sep 2025 05:50:17 -0400 Received: by simark.ca (Postfix, from userid 112) id 393E81E047; Tue, 23 Sep 2025 05:50:17 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.3 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED,RCVD_IN_VALIDITY_RPBL_BLOCKED, RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 297C01E047 for ; Tue, 23 Sep 2025 05:50:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 45A5E3858D26 for ; Tue, 23 Sep 2025 09:50:13 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 45A5E3858D26 Received: from mail-wm1-f42.google.com (mail-wm1-f42.google.com [209.85.128.42]) by sourceware.org (Postfix) with ESMTPS id AAA333858D33 for ; Tue, 23 Sep 2025 09:49:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org AAA333858D33 Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gmail.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org AAA333858D33 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=209.85.128.42 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758620944; cv=none; b=MZGBPuB0Xhn5n91HaxuMcVJnqn7X7O47Q/50XZNxmyvE9L6GwhtlymjnnXxjN0ndwHcjF1nYYIWJO9ia7pvAGnqTzLJNZffCdWFEUPqtb77IjD2KjotDrHhARjtzMgueIF+gNQM6KawUM1V/ra0ZyhDG7Fo7jGMxDiszl6SoIsU= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1758620944; c=relaxed/simple; bh=idMm4HJLcsWUYYl4j7sYpSPoEhxqmk2A6eXRCoi5yEQ=; h=Message-ID:Date:MIME-Version:Subject:To:From; b=M6iW6isLescSQsEym0i9zEe2Y+Fkm8qd7Rh/+fLpVxaC4X1FAul2eznR6wBj+XEv7iVQAa4Ee433VcK/LIqAc1yR+00RxIFUywstjj5ybaWD/wTW9+IoWRgUS4s3y8PUvodSWJPQQL37RPCArXstABMbfuUfVKYLRvVUoX5tI90= ARC-Authentication-Results: i=1; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org AAA333858D33 Received: by mail-wm1-f42.google.com with SMTP id 5b1f17b1804b1-45cb5e5e71eso33684155e9.2 for ; Tue, 23 Sep 2025 02:49:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1758620943; x=1759225743; h=content-transfer-encoding:in-reply-to:content-language:from :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=UkbGAduPJIgtlS0Vv4+vzZ3Swt9POp0iLbFi4mNMsvM=; b=qa2Sm27hY0pS1M0iHolH/7pffQHazjeJlRutPV7Emi9SKerCq/ZIVygFW99dYc7CmK FNyAjc5nbPuHskqGNeHmWn7/PF/CxvgmPC2e71TYVqYpPabfxbzwp0Jb6v4JSBI4xwoy lXWQy1XltBLhVOxCAQzwNk1tpjYviwiQ7YWYAO9cDl8icymHlYQzve1Ptls9anV19sXw Uxv618yLCuHThWUILLdcBHq7yL0sAtuBHuDtFuCFJFladrhDotOQUCkMfN6Y6NEWeZdH Ba+0dStGGTvu2hZyRmCmzLLT1qs/1mefoX9qlf2EaEIQ0Pp7AFdlSjDGwzNUuXgeRwil g8wg== X-Gm-Message-State: AOJu0Ywkir8yGzUr9X8vvbGT0P2Fm6DpZo9g/OAYNOFqKBH37m5iilmF V4BI4hBwLlM6ArhiJ+n8SxRhsKAw8wHSndWOxA5UmkTx0HBK1XMkoblU X-Gm-Gg: ASbGncvdLIK8jpVL6AnLUre1rewpzcYy11vORWxULw9inJyJ6BODKUcov7AF70g1Far JmBVP/QHU8kWsFnYgM4im+e+QxVA2vXJQWdxEZuJLwl5MMvHPM0BqqHv7oHOxxsvgoHXIPWqsDs aicg8Jo+7va+1zg7rp5PT1+fiXzaRNHWvTEULLqkUul85oonJi9Cd16jU7pLhAgHgOGmHumMMJc O+JzmCYnxUdK1CpDSugMZBbWObOZ543kXjxZn4CoSrG4P98dCut1OwzppPQPgffKX+gq3Vuh5S5 z8hf7uS4eBGkLs934MiCze+HMHNs2jJqtiJ82Gk14IN70w2FPTldsGbAEUOjpoYd79nOiL5eChU 0hgoJs7cwUZp8SH5dY1KvOyxsYQ8XkxxISx2Pyn/d3T/VEQOHF+cIQUUl9un3aXhlKQ== X-Google-Smtp-Source: AGHT+IEzbs2P2xFr5QOAwnNI9wtvdjoq/+YbWOWDmgmabyZ5ryWtIkd417ZN7hY+n0cc1UuaF1hIOA== X-Received: by 2002:a05:600c:198c:b0:45f:2843:e76b with SMTP id 5b1f17b1804b1-46e1d9751c8mr13704075e9.2.1758620943233; Tue, 23 Sep 2025 02:49:03 -0700 (PDT) Received: from ?IPV6:2001:8a0:faca:8200:5949:fcfb:b769:4d6e? ([2001:8a0:faca:8200:5949:fcfb:b769:4d6e]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-46e2439a62fsm3625805e9.10.2025.09.23.02.48.59 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Sep 2025 02:49:02 -0700 (PDT) Message-ID: Date: Tue, 23 Sep 2025 10:48:56 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: [pushed v2] Skip gdb.base/libsegfault.exp on Cygwin To: Kevin Buettner Cc: gdb-patches@sourceware.org, Hannes Domani References: <20250606174648.982691-1-pedro@palves.net> <20250611104312.3ada6f06@f41-zbm-amd> From: Pedro Alves Content-Language: en-US In-Reply-To: <20250611104312.3ada6f06@f41-zbm-amd> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org Hi! On 2025-06-11 18:43, Kevin Buettner wrote: > LGTM. > > Approved-by: Kevin Buettner > Thanks Kevin. On IRC, Hannes mentioned he ran into this issue, which made me realize I forgot to push this patch. The version that I had posted only skipped the test on Cygwin, as that was all that I was testing back then) but we see the same when testing MinGW GDB with MSYS2, since MSYS2 is really a Cygwin fork. I've pushed this version of the patch now, which is the same as before but skips mingw too now. --- 8< --- Subject: [PATCH] Skip gdb.base/libsegfault.exp on Windows Running gdb.base/libsegfault.exp on Cygwin/MSYS2 causes badness. E.g. on Cygwin: $ make check-parallel TESTS="gdb.base/libsegfault.exp" ... Running /home/alves/gdb/src/gdb/testsuite/gdb.base/libsegfault.exp ... 0 [main] expect 6611 C:\cygwin64\bin\expect.exe: *** fatal error in forked process - error while loading shared libraries: libSegFault.so: cannot open shared object file: No such file or directory *** starting '"C:\cygwin64\bin\dumper.exe" -n "C:\cygwin64\bin\expect.exe" 8012' for pid 6611, tid 7992 *** continuing pid 6611 parent: sync byte write: broken pipe make[1]: *** [Makefile:320: check/gdb.base/libsegfault.exp] Error 255 make[1]: Target 'do-check-parallel' not remade because of errors. make[1]: Leaving directory '/home/alves/gdb/build-cygwin-testsuite' outputs/gdb.base/libsegfault/gdb.sum: no recognised summary line outputs/gdb.base/libsegfault/gdb.log: no recognised summary line make: *** [Makefile:260: check-parallel] Error 2 $ I.e., Expect's spawn fails, and that brings down the whole Expect process. The result is that in serial mode, the test run just stops. And in parallel mode we end up with incomplete gdb.sum/gdb.log files, which dg-extract-results.sh can't process. Since libSegFault.so is a glibc feature that doesn't exist on Cygwin/MSYS2, just skip the test there. Approved-by: Kevin Buettner Change-Id: I44bdbffa25a5d21c5019418b68776d334a57be26 --- gdb/testsuite/gdb.base/libsegfault.exp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/gdb/testsuite/gdb.base/libsegfault.exp b/gdb/testsuite/gdb.base/libsegfault.exp index eab12ff57e1..a3883e1e20d 100644 --- a/gdb/testsuite/gdb.base/libsegfault.exp +++ b/gdb/testsuite/gdb.base/libsegfault.exp @@ -24,6 +24,15 @@ # the local machine. require {!is_remote host} +# On Cygwin, the testcase would somehow end up trying to preload +# libSegFault.so into the Expect process, which would fail and crash +# it. Since libSegFault.so is a glibc feature that doesn't exist on +# Cygwin, just skip testing there. +require {!expr {[isbuild "*-*-cygwin*"] && [ishost "*-*-cygwin*"]}} +# Same when testing MinGW with MSYS2, as MSYS2 is really a Cygwin +# fork. +require {!expr {[isbuild "*-*-mingw*"] && [ishost "*-*-mingw*"]}} + # Spawn GDB with LIB preloaded with LD_PRELOAD. CMDLINE_OPTS are # command line options passed to GDB. base-commit: 9ca499644a21ceb3f946d1c179c38a83be084490 -- 2.51.0