From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EFIqHqI2iWCuHwAAWB0awg (envelope-from ) for ; Wed, 28 Apr 2021 06:19:14 -0400 Received: by simark.ca (Postfix, from userid 112) id 7987E1F11C; Wed, 28 Apr 2021 06:19:14 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-1.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,MSGID_FROM_MTA_HEADER,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.2 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 7514B1E783 for ; Wed, 28 Apr 2021 06:19:13 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id F0356397083A; Wed, 28 Apr 2021 10:19:12 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org F0356397083A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1619605153; bh=CndN4InjENzl6PCZqFoW4TvHWDOGPqjQCxztVIE+8Dg=; h=Subject:To:References:Date:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=yyqhVjtp/z+fKmwFjveZTRO4H6U4ykqsVW/l0sl4VKvSyaMiOzTRn6bkUg+Qi+oqE ili44IY0gectfGP86NJTRIU5E95REp6GZKenAwMaM3uPlVgVUACiti3FAdTT0kGF/s CDfaoMk0342X/4QfS/i6h0LnfUeJ0yiZDFpn6BiY= Received: from NAM11-DM6-obe.outbound.protection.outlook.com (mail-dm6nam11on2084.outbound.protection.outlook.com [40.107.223.84]) by sourceware.org (Postfix) with ESMTPS id 5F2DD388CC1E for ; Wed, 28 Apr 2021 10:19:10 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.3.2 sourceware.org 5F2DD388CC1E ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=TPZxLg1+tpkgcuT75vOl32u5UxXQlwPkTMdZX5l3grXBMaISU7XbXVV3FobhZ+qDRq7MvSgUdhki12tb3HYXbxUL57FxeoZwd7hGndRnhh5QCqDDONyZdqrdfEVoYaZxmj88fbmCQIRvjuD9IxZJxi/4URAUMi6NM/8nN1TfhjPJT81YF0AhkNvdfZio8WOnRJ/r2cerQ95ZbN6D3isio8PLizW3g0moTqw+R1yOo9vhKm6BIfOdPyeAdAX7paNooVc6TOigDoQ4X8ShA3COSz8UWmDHu3UBfeeMVOY0rP94NqTObBAzQM9E9uGs37zF5+deF+aucUmLRIQk9JZG7g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=CndN4InjENzl6PCZqFoW4TvHWDOGPqjQCxztVIE+8Dg=; b=O0Bh0SjYehedsH7dX/xMK0qsuHNyoTNOT455D8dM267F+s/8n6qunaCdY3e5e4ONV6axCeALHxefil7Dwaedx1RyFWVPR5Hj4vT9gRoO9LslXUXuENQJPJCMg67AkaPg4htZsEsB6pgBiiw8A+JX1xRYzNJoowMKYgWHiil4GRpVj9+5ao+fz090/WMPrXPYVZxV14W7vylXtpYezEOeKfpr2tTi72CGGCTyQ3iXF7a6mDsBoqdnLP4N0g9Mjy3ay7TevGkyOQgL8EINgmPrr+BqnL3B7ibctRKmVy7QLNZHRQcjXmgCeZzKovg1n4Ld0t3401szY+LZgawA3HZOyw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none Received: from DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) by DM5PR12MB1369.namprd12.prod.outlook.com (2603:10b6:3:6f::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4065.20; Wed, 28 Apr 2021 10:19:08 +0000 Received: from DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5]) by DM6PR12MB2762.namprd12.prod.outlook.com ([fe80::49d0:1ee5:47ef:e0e5%7]) with mapi id 15.20.4065.023; Wed, 28 Apr 2021 10:19:07 +0000 Subject: Re: [PATCH 02/43] Cleanup of the dwarf_expr_context constructor To: Simon Marchi , gdb-patches@sourceware.org References: <20210301144620.103016-1-Zoran.Zaric@amd.com> <20210301144620.103016-3-Zoran.Zaric@amd.com> <9a9febd0-e44c-bbe5-488f-871a3bbc486f@polymtl.ca> Message-ID: Date: Wed, 28 Apr 2021 11:19:02 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 In-Reply-To: <9a9febd0-e44c-bbe5-488f-871a3bbc486f@polymtl.ca> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] X-ClientProxiedBy: AM3PR07CA0124.eurprd07.prod.outlook.com (2603:10a6:207:7::34) To DM6PR12MB2762.namprd12.prod.outlook.com (2603:10b6:5:45::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [IPv6:2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1] (2a00:23c7:5a85:6801:f5b0:44e8:2b3e:76c1) by AM3PR07CA0124.eurprd07.prod.outlook.com (2603:10a6:207:7::34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4108.8 via Frontend Transport; Wed, 28 Apr 2021 10:19:07 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 255c950e-e9e8-4c45-58fe-08d90a2f0ebb X-MS-TrafficTypeDiagnostic: DM5PR12MB1369: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:6790; X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: rqSlhGk8nP4Vk5CvBpGMfue+SiqOayWKQ8Hlauo5fKWcFKrrk2t41wq6Oci8AoMvlxUWEAg5kMeuI8+vZnyQZemZbdLG8h7bS06QS4pKqAEuFdl2jLB4G5ygdtZh/DiI2VfFyWaUSWKjFPuAcoOpzGJSiCmq7Fr80BXqNQecwHDNbVB434J/GjWMEGcb4YtVbxs0Zmf++16yMavkaYyX8HsnplEDJdp+aYwSAmkGCNoF2fG27OCHWlxkzGFDln1Ls9S+n4cszHFLfm9S5wpEW1wwcRgUt6nUnFYOb6JoMDpcTGFIkxdChe0YQOLQEttgfYv2v0BtEOSAKiA2bfTlE4g/Xck2Cot0iWJ6OlIFeD6oce2AOFkBHhw7Bk0sS0aK71rkg/W70Rrfu3gvuMBv0QTjdJhVRqFkUdesyG3gHAOeUChAg3iVA/ySnEYwV7ZOni8/PV4fPBlgbplWaRoGrNrzCPFvILKj1BfsmG32WdQNlJvoM+bC4O3ciE9RQ3d/D1jF729lS5LwNf7H1DNOKoVA6QQfKaaUHoyzCys3I6aBkN3wkumoGLBNq8EX4xJLuAD5xFgU10MIjf4crSxrh/kePcifv70u6E/+AvEmpGCeTA9B3YjPkHzbKMw734dc09tgQXpQh6j7eir20i0cA1nhu+s1ltdgRkykHT8WoUnJlAJrVMftwgVQ5VTXlG0X X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:DM6PR12MB2762.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(39860400002)(396003)(376002)(346002)(136003)(366004)(5660300002)(38100700002)(8676002)(6486002)(8936002)(2616005)(4744005)(16526019)(186003)(36756003)(86362001)(52116002)(6666004)(31696002)(66946007)(316002)(66556008)(31686004)(2906002)(66476007)(53546011)(478600001)(45980500001)(43740500002); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData: =?utf-8?B?ZzhxQ0FpbGRpOEtDdFN6R0J0bWhHVE5zWDBnaDlHYkpQSjI0RjhPc3o0SXdT?= =?utf-8?B?TUJSVVN4TGhuZ1FVYzNhai9KR0pNcEJWQ0hKREdCcDZvc1FBM0N6dm9aQitr?= =?utf-8?B?NStTdGllaU9WdnJtQnUxUmh6dUZlVnErZXp5RFQ3ZzVsZUhMSDJNRGhsanlj?= =?utf-8?B?c3M2OU9sWk84bWhOcU5HekZyOHFRNER5eC9EN3FDcVo4NjdBM1p1Zm9KMjJt?= =?utf-8?B?VHN2MEFhZ0ljYXBsYlpDUHNhVS9wV0haaHFNMXdVcXpSazEwQkVSeURQRzZx?= =?utf-8?B?Qjd2NTRTUTFXQms4eHVzYjVUZ1E1dW5kUU1qa0NNbUVQNjNFUUJPWUlWRzZB?= =?utf-8?B?bzRSYlU5bUEyUld3RVluTjUrTEFURGhUNTBaQUdkazJJSW01UHVYSUlvOFFW?= =?utf-8?B?VnU0ZGgrQ3RheXF4MGxqdFVwUTg0VWI0TENIRGVDODRuUkpSNUZReGwzWWZB?= =?utf-8?B?dlViaE5mUVFoMkxQS2ZVL09wY3VTbHQvZk5jOGhxNWlpUThYZ3hxd0tYSDBH?= =?utf-8?B?OXdmZC9wTlBJQlBtUW55cDVRcjR3eVVhN3hmVUJGbHFsOTlXOXROTG0yQWFP?= =?utf-8?B?MGFxVVVrNDh1Wk00OC9rK0JEUk5TRjlXeTl4TmZPRkcxWGJ4SkZ3Z1NtSjVk?= =?utf-8?B?NjNSODNqcWhLNGx5dmpUbEZ1K1drRTdKdGJSSVpnREdrRUpEWGd4a25sSU9L?= =?utf-8?B?UldGVWxJeFh6aFdiczFNdnRSbDFISFhGTnBPK04wZU81U2xVaHZGdDhEdjNC?= =?utf-8?B?MzdFTDZ5a3hBRXRNVGIxNmM1N1dhcFRMYmxBWGpOZmN1UDBpQ1RSL0xTT2JS?= =?utf-8?B?ekM5bS9ZTFpJSXVobTUyK1Z6REpKYmhTcHdKaEJkNEV1RjJZcGdRUlVvR3kz?= =?utf-8?B?eEV1MEg5ZHZQTDE3USt6a1NObEVUZ1ZESlVzYnhERFFDMHZ4TjNHR2drKzZI?= =?utf-8?B?ZW5hZ0Q2bTF4aW0wUHYwZytZc2NDeGRiMytBYWEyUGd3ZkhZUzhUS0RJTmJn?= =?utf-8?B?Z2wvbCtLWHRvMkNIZENKZkk5WHNHdzlCdzV3c0I4MmhESHlDNnpBTkNYZ3k4?= =?utf-8?B?MFRzRDMwZlJWaGNEdWI5a1hGQmJpNnBnV1ovTzE5dkw1eTZ1R2JyUGlZQTNX?= =?utf-8?B?VG1vRVlOMXNIYjZaUGhrT3FvWGdHZnVNTDQzV3FkT1Q1NDJWNnFQdEl2b2tV?= =?utf-8?B?K1U3SmtNbTJ5cklsYzhPWVNZQUJSakJXVzJRSlRSTWFuVVNRd3lTODhXUWVJ?= =?utf-8?B?dDRhLzJIcFJsaGo0bk9haDErVi85RytiZTJnK1hOdUVubDBuYzNiYkV3V01w?= =?utf-8?B?NkVseGRZRHkwRmRQT09MNkdlTjk2Z1MrWmtDdnVvaSsxa2VpNHY4T1pGVlpC?= =?utf-8?B?eTViUFNNZG9oaUZoUWJwZ1lJV1FzMkJXRDY1ZzJnb2NiUk5yUFpzakVPUXV3?= =?utf-8?B?NjNZcHdneTRSV0NialpKdlNOK2szNlVTWEcxK0g2cnE1QWVXNEd4Y1QwWWlw?= =?utf-8?B?c1QzS2pPRjl2ZlNiWFhFZE9xVVJKTmkzZWZYR0N3d3UreGVPYnQ3L2hsMXpa?= =?utf-8?B?dENwbWdJbitqN3c2R2ZVdmNWeWljU2hrbHo2NUwrNjdsOERabTVEdzVLcVly?= =?utf-8?B?eFRMTGlScVI4YnNPTUliZm40Qi9jWklRVUdFaWRpQ0lYS2tpM2NrZytnZjVP?= =?utf-8?B?aWN4dDJTUWZOZXhrdnhFaDhnOGZjdnluZkZSL2hyTm5ldjNiODc1SkJZbERH?= =?utf-8?B?MUlBdy9tT2R0eVV3d2pYNzZZNXRJRlphQWI0U3B6N3RXSnVFZWtBZklZSEI1?= =?utf-8?B?dE03WHNNbHFscHRBK1U2RVcxbjczRVhRSElPVVY1T0ZhMzlnWERheGpOekpM?= =?utf-8?Q?ynu5Ib3GRsL5P?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 255c950e-e9e8-4c45-58fe-08d90a2f0ebb X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2762.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Apr 2021 10:19:07.8064 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: i3l2PBy9C8oZ54QgskuV4hGEkVD8Z2uA2Jtbzo9ius845UQZbES42Dxsoax7OF04+NR7EEnAr5l5CQUJCdH58g== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR12MB1369 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Zoran Zaric via Gdb-patches Reply-To: Zoran Zaric Errors-To: gdb-patches-bounces@sourceware.org Sender: "Gdb-patches" > > On 2021-03-01 9:45 a.m., Zoran Zaric via Gdb-patches wrote: >> Move the initial values for dwarf_expr_context class data members >> to the class declaration in expr.h. >> >> gdb/ChangeLog: >> >> * dwarf2/expr.c (dwarf_expr_context::dwarf_expr_context): >> Remove initial data members values. >> * dwarf2/expr.h (dwarf_expr_context): Add initial values >> to the class data members. > > LGTM. I suggest you push this right away, it's a good cleanup and it > will be one less patch to carry. > > Simon > Fair point. Zoran