From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id iJEMMgpOhmmLqiwAWB0awg (envelope-from ) for ; Fri, 06 Feb 2026 15:24:42 -0500 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=g4HJnx/K; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id AAF6E1E0BA; Fri, 06 Feb 2026 15:24:42 -0500 (EST) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 95C271E08D for ; Fri, 06 Feb 2026 15:24:41 -0500 (EST) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 1BC0F4BAE7CE for ; Fri, 6 Feb 2026 20:24:41 +0000 (GMT) Received: from YT3PR01CU008.outbound.protection.outlook.com (mail-canadacentralazon11020124.outbound.protection.outlook.com [52.101.189.124]) by sourceware.org (Postfix) with ESMTPS id 0F0D34BAD16F for ; Fri, 6 Feb 2026 20:24:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 0F0D34BAD16F Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 0F0D34BAD16F Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=52.101.189.124 ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770409471; cv=pass; b=IdbWxlPEGSN1zBO8Dmwir70xzqBQZNEWqnOMRJ0K2onCLCMjbmZ56xnr3fONv1RnSZtnNuY12UcroAZJA96CJHsC//Gd8P26OlaOKSxFZjGSNKV65YlgoZjEldlwyz8QL52YPjp71aEd1QHNTPbOO7O6NlcPEhNzdmEfro7viZE= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1770409471; c=relaxed/simple; bh=nxVQ8ToyV4fWJXpny5QEjqljgpLkFsXgph/Yehu96jc=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=sJMqcEa9s2e24LLujwI6Cz+fpT0pV26f/iRIBiogqv2nga5EqWLOqhHyz7u8sWkB6z52RO4pVdDBkEhdQsd6XX77sHHltOdU8MeBkWoOUn93lIEpwNV8VVzDHyaH/BkfR6xnAyFXx6VXBBmuHTbgJ2AY1+7J5kXpMogejLZnGio= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0F0D34BAD16F Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=g4HJnx/K ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=AqkIo6ONnXXiMSJhLK6fpkWM4WMce3OP4tZnbV7RJ/EOnqB17tIwrJetbU+eLN4rinD/X7CjsMZ2iyFHL4fFq9Hm6ylcG10q0GCRWfIJqrWtF0i5n9yzKcIjUfdhJVIlpPDCD2tOUtgKO6MTRCucbbgxTSkW/tLm2aHDnYXgGSIwdRcjEVr2scBgR9OSqHCIyJOqQllSFwrLXZl1/Wjs+eTElHESr8kI3MMKJ0MpAN+6+kVROfN1ZdmCaEG3EMGy3pVKX0hyoPO4ausScrSKK3xiz4ElN9vhQ3FbgTG9XXdpR0d2fhx5PC1qF7tg5SJuSWbfTLLUu8iQDKPlaUzS/w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=kycxxyTcN2QI16naey22aqtZqyEcYCzm+84AdRLsKE4=; b=cFLKMgoqL+hGAfM6e+cx8uy0mjiDu7pjTLfEwNvfW8fNKlXV7wAh4RDIDLlcBi6xs8eIZkcBp9rLh8WYEvR1b464UkglJ41F1bcohKZHcsLoeBBvTTQFfvx5LK0YLdcyD8HvelbRXD49v6IdhzJGk1R6+eJn63JdlwjYhWwcHcM2YAtP3/CuLXjdibIFy25uRWIweepGa8XmQketHj1vQXwhng5SlgO6RSflMSaa+A0vZ3Etdfsx6bncikv/9E5DPwikoJKCUpkoluPUHrYXkH2129BrZUD762A2PBZ7z/tNGEC9WTl8oTouElBPAj/jm+wxIcj22YAL6I9C1nmV0Q== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=kycxxyTcN2QI16naey22aqtZqyEcYCzm+84AdRLsKE4=; b=g4HJnx/KgYdaiQV5sP8vfEwEdOzX5vleYm1VUo4DRBV/BaeFLaMb9Zldr8mK7f8sixsdax4nTr3PCBTviYYrVU7BLotf/4MrZVZHQjGu+c3lOaTZjauGEx39OD2WxvAmZwhXwpRbxsSuJZJvHoxNxofZdrgQRjkPaIJ0rEGR4irzgVJsuCL6/mZSDrD1krznmVf3Kmg0KvU9rn4ZXnz+qRSYXEdAXG3Z7iJooH1P+94poicSiqLsHGwTDqsgZK88JqYovu2W9/jDijJz7O2IKCek4xAR0wvKD7xmGMB5eQduU1trdJ4i4CKndnkOgZvjLnrIdiQjoRbTby/f0zf5Rg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by TO1PPF2DE746D48.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b08::62b) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9587.15; Fri, 6 Feb 2026 20:24:27 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9587.013; Fri, 6 Feb 2026 20:24:27 +0000 Message-ID: Date: Fri, 6 Feb 2026 15:23:36 -0500 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/2] gdb/block: remove block_iterator::d::block, remove union To: Tom Tromey , simon.marchi@polymtl.ca Cc: gdb-patches@sourceware.org References: <20260206025238.3467043-1-simon.marchi@polymtl.ca> <87v7g94yd2.fsf@tromey.com> Content-Language: en-US From: Simon Marchi In-Reply-To: <87v7g94yd2.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YQZPR01CA0053.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:88::10) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|TO1PPF2DE746D48:EE_ X-MS-Office365-Filtering-Correlation-Id: 1fcafa10-1d2d-4ed0-98bf-08de65bdb93c X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|376014|1800799024; X-Microsoft-Antispam-Message-Info: =?utf-8?B?by8rY1NsVXFJZ2ZKelFpUTc2UExwcm9jSC9SY0VUdTcxOTVkdVRDeUFUWU85?= =?utf-8?B?NGFKczJEcitmbTh1L2NEOEVsQUgzclVzVzI0Znlvck1YVXlQa3M3MGVLazJD?= =?utf-8?B?Z0x0L3QwbUJpT21CZVBHL1VLL3ZnZWJNdm9iUVRMME9oV3B1clBqUnZGZVpm?= =?utf-8?B?bTlBaWNCdDkrczE5bTUxa25MeEVZY1I5cHNHWDdjL3llUkVqOGhMUEYwcmox?= =?utf-8?B?emFrbXI4MDJ2ZUcreEFpM3pzTkZSdVNiSktLYzRJcExKa2Q1OE9KYU9ROGgv?= =?utf-8?B?TTNyWm9KNmVXdTdmMUVCay9jRWVudHNwSDhrYnFnNEszRnpKRjZQVmxRRnVD?= =?utf-8?B?U0g1VjZyR29ydThoZW0vUWRMUjRIeWRReXNEN1k5SkhkSjVLeE9nL2VxRXU2?= =?utf-8?B?bUdOZkRKU0ppR0d3T2dLZFJyKzlocnB6NmRIRUtaMm5pdHR0VzlZVXh1Mncw?= =?utf-8?B?L2hwb3RNZXA5QkVZUTNHOVhIYmZvMS9vdk5mcUdYMTBYeU93RFBsMWFQb2hO?= =?utf-8?B?aDdqWEpnWmxiWElqNGF4TGtpQzZsbkdRcE9YM2JmdUJaYUZEaTI2YnJETWw1?= =?utf-8?B?L1hWbXVuamJKd0YvbHpDd3N1TUdtRTJVZnN3U2ZLZU5tR3NDdnBOYnlVVitB?= =?utf-8?B?dG0velhaeHd2T09nRkxjbWFLUUMrc2FhbTRWUWp0MkZHaE9oNmNySzh1TTdm?= =?utf-8?B?TlV4R0dMV0tkR3RCemhDVkxsWG9wV1NUeUNJL3k5WEsyQ1ZIRnZhZ3VoL3B4?= =?utf-8?B?ZkRseDBvRFNuSDB3L3J5ZjF5L3F6d0s5T2QvSUpXV1VFeGg4U2hyZW5GSU40?= =?utf-8?B?d0xLbmRrOWhoSFZmbXRYeStDZ3pYMmcxY1dzOE9Nb01iMk1lUE9Vd2lEd0Vo?= =?utf-8?B?WlQzOU5waDlhbkoxc1l2K3hnRWdHYVQ2d1NldXZCV3IvNUZWdGQ4bVdhQ0hB?= =?utf-8?B?bmRrOHNybE5NaEVKRlZzTk4rTGNCRzZJbDFKMWlzT1Y4RWptUjNLYitrakhI?= =?utf-8?B?WEZFZ1FmSEpTSjg1L3ZUOVpxTThVQ1ZacVk4bi9VbHA2cytYYVloNGk3OEZ3?= =?utf-8?B?WFc1c25JZEE4Q0hySzVrdkdKalZMcERNVDZPOWpMQ0MyYURDOE5EWUNzc3B3?= =?utf-8?B?ajJYZUplNmdSbTVzMnllemZ3MEp2UlRMbG9mdUlZNEpMUGhuUGhkWnVocElC?= =?utf-8?B?TDhCSXZJdjJ5SXBOUDhHa1RaSXlZOVdmTDBWQzdiM3N5dkNPMy9CY3NzaThm?= =?utf-8?B?eVpweXRISXU1ditmTTFNOEZocFJiNTdaUklkM2Q2ckRnSTYzeWtUYS9nMHJl?= =?utf-8?B?cWpsdDhLV0FXZUt4enI2WGJyV0JjdEdMZWFPUXVvcFB6K3g4QlpiK0tKV05q?= =?utf-8?B?U0ltUGtZY0xsbGtNQ0c4Q0t2S0dXRGFRanpiL3RjTVkzUURPdjU2RkI4QnFs?= =?utf-8?B?WnByTFB4azI4NDByRHgrZGI1bXN1NUllSHNyajFtQUpaTHBhYXdwRnh5ODlU?= =?utf-8?B?WnN0VldjY1lGOUhWTU8rdkl0N3djbHRsRGNSMzZsc2h0SjJIbzJDUm9pc1RL?= =?utf-8?B?OXh1MTRzNHlCdmU5aUMxbDQ4N2tkd3ZsWHRwcTkzbm0zcHdoK0x5aHhXK3k5?= =?utf-8?B?MUxER1VzY25LRjVCVmtiTWFsYVVBcGdEL09uRy9URWpJSFhyWVZ2RVg0c2pM?= =?utf-8?B?NERJODBXTG1WQ0ZyOEtOZ293QitSVHZVKy9YVWNCVWpFa1FnSmZBSHpCNUFT?= =?utf-8?B?Q1ZHY1dROTZQVjdjcmlkWXNDbDdxZ0RlRi8wVDFXWDRZZnVMemRzV0thOG9v?= =?utf-8?B?QTRReUFaQTdZQ01PaHErOWsyaTZWamowTmRHN3hDeHVtUXZmYU9RdkJ4ZXFV?= =?utf-8?B?MVBrUnhIc21neXhwK1Fudlp3N09POVd6S0xFbitjaEJhSW5xM2MvVDZwbnZY?= =?utf-8?B?eU9jZDJWdll5ckJpTU1PMWw2TnRDaFpGdkVXbU05Y29PUTlOS09vbmNEc2lD?= =?utf-8?B?MTFJYWFmSk1nell6cHFYVndsZHZZbEpFdUIzdGx4bXEvN0d2MGdWRk96WUdj?= =?utf-8?B?a0Mvei83WE1mTEU1K25idStBWjdFWFFwSzVHcksremVEdE1VZmVqZUhFMzVB?= =?utf-8?Q?v1WA=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(366016)(376014)(1800799024); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZlViaEtaSWdkSy90QzZ2OUNXMkVocUt4S1ZWQVFpQ2NUQTZ4V1Q0RXUzTlNj?= =?utf-8?B?dGF0VXJMVTVpUEROYVpRcUhBcFVoUTU3akt5Yjh1bm5DSTMxTVlRK0srQitv?= =?utf-8?B?bDJqZXdBRDF4em1idEdXNmdSWkhraUxxa3I5dmxzT1N1eDlYRWg0eTNxaXp5?= =?utf-8?B?QUVhTFdxMEl4c2QrcnMyTGF1UDhmcng1bW4yZDRZVkFlN1R2THJ5TENDcHUy?= =?utf-8?B?VEFzT2FpVHlWck5vVkJMbGhpRnJvT0RLcFBMNHdmNlZ1YjdRVGNwS1NtTlJW?= =?utf-8?B?WHd5ZjdHMWFSendEb0JtZU9nWE5yOWJTTWNtMVJwRHNXeWdvUzhFNnBwaXNY?= =?utf-8?B?UjkwNXRETUplREtkQU01NDAzd1FEZ2xpTnhtQ1IwRGRqRm5SZDl5czV0bXdN?= =?utf-8?B?Ri91Z0xXZWVEc3BiZnA1RUpjbVJKUEc1WnFmWGZtVGtKQ0ZJUXJ3Nk8xYjBR?= =?utf-8?B?a0FNWkdoLzdwTWRGY0hwb0crdDF5ZGxYTndnaVIyWisrdmNyMStDb3Bnekw1?= =?utf-8?B?ZWIxWEp1U1d1QXNDRU5ROFNhc09BdGViNW9hRGdxbUM2UnE2bUxYQzBNd0ZM?= =?utf-8?B?RHZhSVJXQiszUkZ6SDAxdkd5VnlsZVQ0dzRWOUFSdDNHN0VrYXVUOVhpdEtD?= =?utf-8?B?ekRxbkc0VHdwU3E2LzFlMm9wZnpkSXE0SUNaeUx2WUMxTlRBMEM4NlR1SmNv?= =?utf-8?B?bVRkQnpkVXNESTM1RUt2NndsTmI1WVl2cEpkS2lPUVRBVFRYaFN0bjArOXBw?= =?utf-8?B?TUlVbnBCcmRxbjRCWWQvWkRONUZNeVZ1dzJyaVlOUmg2RnMwd21CUXJ5M0ZL?= =?utf-8?B?ZEFUMFFtalhSQTB2bW1uSDVaOUJSbkdIWGN4Mjh5STQydS9pa1N3akYxV2FM?= =?utf-8?B?UnA5eDJhc3lINk5mSitYeVR4V21DemY4SlVLaWpzQmoxM2VrdHNQZElwQ0xX?= =?utf-8?B?eXVIa2dzWGhCbVNnOGpLRHVSQ2ZTeC83amtyM3VSR3J1UlJEYU14TFh4dVZu?= =?utf-8?B?aXFFYmFGb1hCZGVkWHFMbFoxNVRSU25pcWJ2TDFwd0w3aTAvNDY1WTQ4aENk?= =?utf-8?B?STNnQmZFdXpmSVNlMHJYenRCcTBFSmxkSW42MDUrNjdDWmxqWjdaZkV2b3Bi?= =?utf-8?B?N0dXZk44RWZrbXB5TTdnSzRQcTdBNVZNdTl2c1YzUzZsTG9VeWFnaS9ZMk5n?= =?utf-8?B?a0V1UU1TS0N6SmIwdEZaMnVMYnEwSDMrZ2tacElqM3RNdHh2MFFrZk1Eam56?= =?utf-8?B?L2VPOXd6UTBrc25NS052bEcxYVFQRGRHWnJoUUVtcUY3cXRiV0FOK21hc1Fn?= =?utf-8?B?MWxaZzFDaVVTdWk5NFpzY1l4QzQ2VEtrc0pqc1owelNvN1FGUXAvMVAvZ0Ur?= =?utf-8?B?blVyeElyaWJEbnF0SXFhMmd4RjNRZXRPeTJIVjk2NTB0SGhEL2xFazRrblps?= =?utf-8?B?WkxtcElkY1V5UmdJRnJ3S1FJa2NqdWpjWGVvMW4waFZnRzdCMldoOTFsM0pD?= =?utf-8?B?VlJ3OW4wbU0ybldOTTRFeFo4TTFPSDBJOXRtZ2pJZDVKRlMvQnZoSEtjbFhB?= =?utf-8?B?Yk1LOWs2eXgwL0NZN2RBZjJkRGdqcnFwYzUzdE5lTHYzWFhJNDB3Y1FiYnVV?= =?utf-8?B?bldkYmFEZVBFejlSRDJBME9GMmZseXluVmlpcFBUVmRWdnljTFZzUnAwMytp?= =?utf-8?B?Wk5va3pzUThqQ0lyV1VGTThPSWx3TUQyNStPVUxUOEd0RXgvNmhpNllQL2ZR?= =?utf-8?B?VnVBRHNNbXVDblEyZ3BwYUNLb2RrTGRaYWJ3QjAvV0ZKcVFRK3lJeisveUIv?= =?utf-8?B?RmZhMzJkTExsZUIxblV0ZGNzd0xLeUxHU1JtOFQ2OER4eFV1bmd6aVNFOHVl?= =?utf-8?B?dk9JVE41eG1wU1ZuWjFUSEVxTXBzVHFEMTV3WFduUmpiQWRnbmI3RDgrb2xR?= =?utf-8?B?ZUpkWFhvMVNvTURvYzFwU1FmWWt5YmlBQ0t0RDFvdUlwRlJVem1QN0hlNnV6?= =?utf-8?B?VXo0cXlQSmJlWUxVbCs1N3JGcURUdE4welpaZDZ1L1lqaVlJa0RrWlFVOE8y?= =?utf-8?B?V2hSMmwwYlR3dGVwLytqbzRyK2NyTXZzZEhxR0hBaEtOMDMwMEpKMnZZOHRS?= =?utf-8?B?bmkybzltNFNzYlpUaS9VWHp3UUduZE95V29LVXNlZkd0UTA3TDUzczlrRnRw?= =?utf-8?B?QlNCMHphTVZzSVh3R3Noa0s0SFIxa0FlV0tJZ08raDV0TEJxQjE4YTlQeWE1?= =?utf-8?B?cnNGN1VHdHJUdnJwZ2R2RlBwS3RNbmFSNWN5NDgzeS9sN3BvWWNjemRSTHp6?= =?utf-8?B?YXRqWFl0UHVXYXg0TTEwRWlGbktxNnA1clZzYnYyU2N5ZGdFMUErQT09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1fcafa10-1d2d-4ed0-98bf-08de65bdb93c X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2026 20:24:27.2879 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: BZMNpf2BqZdsrizL9RomdxBuVMpRfM2VC5NNF9NjJ2PsYpNXK1YG8eLcHzIrTj8YCPy4inbeHE280v0yRGgSJA== X-MS-Exchange-Transport-CrossTenantHeadersStamped: TO1PPF2DE746D48 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-02-06 11:42, Tom Tromey wrote: >>>>>> "Simon" == simon marchi writes: > > Simon> From: Simon Marchi > Simon> The block field is never used. The block is only used to grab a > Simon> reference to the mdict, which is stored in the mdict_iterator. > > Simon> Remove it and remove the union. Leave the compunit_symtab field, whose > Simon> name unfortunately conflicts with the method. > > Seems reasonable to me. > Forgot to reply about this: > Using an m_ name wouldn't be remiss, we have other cases where we've > done this but where the field is still "public". That is what I did at first, but then I thought that I should also rename the other fields, which are also "internal", otherwise it's not consistent... meh. I thought that it could wait until someone C++ifies this code properly. Simon