Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Luis Machado via Gdb-patches <gdb-patches@sourceware.org>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Don't inherit range-type signed-ness from underlying type
Date: Mon, 19 Oct 2020 18:28:24 -0300	[thread overview]
Message-ID: <a0fe5654-05ae-091d-8818-7e4de29331b7@linaro.org> (raw)
In-Reply-To: <20201019193330.3242805-1-tromey@adacore.com>

Hi,

On 10/19/20 4:33 PM, Tom Tromey wrote:
> A recent commit changed gdb to inherit the signed-ness of a range type
> from its underlying type:
> 
>      commit cfabbd351a174406fd5aa063303f5c8bf9266bbc
>      Author: Tom Tromey <tom@tromey.com>
>      Date:   Sat Oct 17 11:41:59 2020 -0600
> 
>        Make range types inherit signed-ness from base type
> 
> This passed testing -- but unfortunately, additional testing at
> AdaCore showed that this change was incorrect.  GNAT, at least, can
> emit an unsigned range type whose underlying type is signed.

Is this correct compiler behavior though? It sounds inconsistent. If the 
compiler wants an unsigned type for a range, intuitively it should use 
an unsigned base type, no?

Otherwise this may lead to confusion.

  reply	other threads:[~2020-10-19 21:28 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-19 19:33 Tom Tromey
2020-10-19 21:28 ` Luis Machado via Gdb-patches [this message]
2020-10-20 13:55   ` Tom Tromey
2020-10-26 18:53 ` Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=a0fe5654-05ae-091d-8818-7e4de29331b7@linaro.org \
    --to=gdb-patches@sourceware.org \
    --cc=luis.machado@linaro.org \
    --cc=tromey@adacore.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox