From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 2ljLFMhpe2JEmAUAWB0awg (envelope-from ) for ; Wed, 11 May 2022 03:46:16 -0400 Received: by simark.ca (Postfix, from userid 112) id 47D301E21F; Wed, 11 May 2022 03:46:16 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=llnOw86a; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-4.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id C7E551E01D for ; Wed, 11 May 2022 03:46:15 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 63E3B383F408 for ; Wed, 11 May 2022 07:46:15 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 63E3B383F408 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1652255175; bh=Hs+8M3lrVUXmuMGnFtPlZqTECmw6hHYpEx3whwKKCmQ=; h=Date:Subject:To:References:In-Reply-To:List-Id:List-Unsubscribe: List-Archive:List-Post:List-Help:List-Subscribe:From:Reply-To: From; b=llnOw86atZpu58rB0NBhn3WwjXZXHHRWxIVG23oLnzIrOzoKimvIRrttMDYlLf+Kq 0n/8QMxgPhROfamQXj8uBzAlAne9U0Var/2Nnhgr0hlC+KXX5cXtjIj7dJnOEC49SB gFOyQ0SBFEvAWbYMXmqwKBEeh+xDcXyScb4HVEy0= Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.220.28]) by sourceware.org (Postfix) with ESMTPS id 5BFC13860C08 for ; Wed, 11 May 2022 07:45:41 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 5BFC13860C08 Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 8585B21B19; Wed, 11 May 2022 07:45:40 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 6AB2A13A76; Wed, 11 May 2022 07:45:40 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id DpnfGKRpe2KhWQAAMHmgww (envelope-from ); Wed, 11 May 2022 07:45:40 +0000 Message-ID: Date: Wed, 11 May 2022 09:45:40 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 Subject: Re: PATCH] Update syscalls/{ppc64,ppc}-linux.xml Content-Language: en-US To: Carl Love , gdb-patches@sourceware.org References: <20220509154832.GA22531@delia> <58d5119f8edf4cff1fb7b1d23d419553251f510d.camel@us.ibm.com> In-Reply-To: <58d5119f8edf4cff1fb7b1d23d419553251f510d.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 5/10/22 22:18, Carl Love wrote: > Tom: > > On Tue, 2022-05-10 at 11:01 +0200, Tom de Vries via Gdb-patches >> wrote: >>> On 5/9/22 17:48, Tom de Vries wrote: >>>> Hi, >>>> >>>> Regenerate syscalls/{ppc64,ppc}-linux.xml on a system with 5.14 >>>> kernel. >>>> >>>> Note btw that it does not only add, but also renumbers, f.i.: >>>> ... >>>> - >>>> + >>>> ... >>>> >>>> Currently testing. >>>> >>> >>> Here's a v2, with a gdb.base/catch-syscall.exp test-case fix >>> included. >>> >>> Testing on ppc64le revealed: >>> ... >>> (gdb) catch syscall 286^M >>> Catchpoint 2 (syscall 'openat' [286])^M >>> (gdb) FAIL: gdb.base/catch-syscall.exp: multiple targets: insert >>> catch >>> syscall on syscall 286\ >>> -- unlinkat on powerpc:common64 >>> ... >>> >>> FWIW, I've wrote a patch that exposes the same problem on x86_64- >>> linux ( >>> https://sourceware.org/pipermail/gdb-patches/2022-May/188881.html ). >>> >>> Any comments? >> >> I have looked at the patch. I don't see anything that is an >> issue/problem on PowerPC. > > Per Will's comment, to the extent that I can tell the syscall numbers > are consistent with what I saw last year. I did note that you add > syscall 359 getrandom. In other unrelated work on gdb record I get > messages from gdb record about a couple of system calls that are not > supported. Number 359 was one of them, I don't recall the other one > off the top of my head. I had yet to run down what the name of the > syscall is for 359 but hopefully it is getrandom. Not sure if your > patch will fix the gdb record issue or not. I need to get back to > digging into that more to find out. Hi Carl, AFAICT, there are two different gdb bits dealing with syscalls: - catch syscall - recording . The xml stuff seems to be used only for the catch syscall part, so I expect that this won't fix the recording issue. Thanks, - Tom