From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 15445 invoked by alias); 30 Aug 2016 14:44:55 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 15434 invoked by uid 89); 30 Aug 2016 14:44:54 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Alves, alves X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 30 Aug 2016 14:44:53 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 5745BC04B315; Tue, 30 Aug 2016 14:44:52 +0000 (UTC) Received: from [127.0.0.1] (ovpn01.gateway.prod.ext.ams2.redhat.com [10.39.146.11]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7UEioFm018400; Tue, 30 Aug 2016 10:44:51 -0400 Subject: Re: [PATCH] Fix order of inferiors in "thread apply all" To: Andreas Arnez , gdb-patches@sourceware.org References: Cc: Philipp Rudo From: Pedro Alves Message-ID: Date: Tue, 30 Aug 2016 14:44:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit X-SW-Source: 2016-08/txt/msg00300.txt.bz2 On 08/30/2016 03:36 PM, Andreas Arnez wrote: > This inserts missing parentheses in the calculation of the comparison > result between two different inferior numbers. The problem was found by > Philipp Rudo. Whoops. > > gdb/ChangeLog: > > * thread.c (tp_array_compar): Insert missing parentheses. > > gdb/testsuite/ChangeLog: > > * gdb.multi/tids.exp: Test "thread apply all". OK. Thanks, Pedro Alves