From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 58332 invoked by alias); 9 Aug 2018 14:46:07 -0000 Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org Received: (qmail 57587 invoked by uid 89); 9 Aug 2018 14:45:43 -0000 Authentication-Results: sourceware.org; auth=none X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,SPF_HELO_PASS autolearn=no version=3.3.2 spammy= X-HELO: mx1.redhat.com Received: from mx3-rdu2.redhat.com (HELO mx1.redhat.com) (66.187.233.73) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 09 Aug 2018 14:45:35 +0000 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.rdu2.redhat.com [10.11.54.3]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 9E4727A7EB; Thu, 9 Aug 2018 14:45:32 +0000 (UTC) Received: from [127.0.0.1] (ovpn04.gateway.prod.ext.ams2.redhat.com [10.39.146.4]) by smtp.corp.redhat.com (Postfix) with ESMTP id AD7BD10CD792; Thu, 9 Aug 2018 14:45:31 +0000 (UTC) Subject: Re: New ARI warning Wed Aug 8 01:55:57 UTC 2018 To: Joel Brobecker , Simon Marchi References: <20180808015557.GA64451@sourceware.org> <20180809143249.GA2452@adacore.com> Cc: GDB Administrator , gdb-patches@sourceware.org From: Pedro Alves Message-ID: Date: Thu, 09 Aug 2018 14:46:00 -0000 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.8.0 MIME-Version: 1.0 In-Reply-To: <20180809143249.GA2452@adacore.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-SW-Source: 2018-08/txt/msg00214.txt.bz2 On 08/09/2018 03:32 PM, Joel Brobecker wrote: >>> gdb/dwarf-index-write.c:1625: perror_with_name ("rename"); >>>> gdb/dwarf-index-write.c:1640: gettext: _ markup: All messages should >>>> be marked up with _. >>> gdb/dwarf-index-write.c:1640: perror_with_name ("rename"); >> >> I think these can be ignored, since these messages can't be translated. > > Let's add an ARI marker to document this, and silence the ARI? > Otherwise, someone looking at the ARI report for some easy things > to improve might come upon this one and waste time figuring out > that these cannot be translated. And also, it would prevent the > report from containing too many false positive... The way we've been quieting the ARI in these cases is this is the wrap in extra parens, without the "_": $ grep perror * | grep "((" event-loop.c: perror_with_name (("poll")); event-loop.c: perror_with_name (("select")); fbsd-nat.c: perror_with_name (("ptrace")); fbsd-nat.c: perror_with_name (("ptrace")); fbsd-nat.c: perror_with_name (("ptrace")); .... Thanks, Pedro Alves