From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id VqZrBeCad2Oa6BkAWB0awg (envelope-from ) for ; Fri, 18 Nov 2022 09:46:56 -0500 Received: by simark.ca (Postfix, from userid 112) id 077E81E124; Fri, 18 Nov 2022 09:46:56 -0500 (EST) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=aGKhQUcx; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,NICE_REPLY_A, RCVD_IN_DNSWL_MED,RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id B08901E11E for ; Fri, 18 Nov 2022 09:46:55 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 0B2F73852C4E for ; Fri, 18 Nov 2022 14:46:55 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 0B2F73852C4E DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1668782815; bh=Wjv1fFJFpXAhrNeVPKjfQsBzfYk9FZDdfeYrTqtOSdo=; h=Date:Subject:To:Cc:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=aGKhQUcxRxQsgdhjv6TwQ61XOjF1kNnEEn6PFAwiR74X8YVocDQH19S5qx3cVL2h5 OKm/sjvy4HDrurv8Kgx8iCB5mhFHYu+vSvJKMw46IUA83SbOD64rNdw0jk8DNN01Cx G8udpLCuVsJz726oXqATRtiF+4D5Ll/S+X6OeU+Y= Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by sourceware.org (Postfix) with ESMTPS id 6E58D3857C4F for ; Fri, 18 Nov 2022 14:46:35 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.1 sourceware.org 6E58D3857C4F Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id 5210C229E5; Fri, 18 Nov 2022 14:46:34 +0000 (UTC) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id F02AD1345B; Fri, 18 Nov 2022 14:46:33 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id XgDbNsmad2PwUgAAMHmgww (envelope-from ); Fri, 18 Nov 2022 14:46:33 +0000 Message-ID: Date: Fri, 18 Nov 2022 15:46:33 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH] PowerPC, fix gdb.base/retval-large-struct.exp Content-Language: en-US To: Carl Love , "gdb-patches@sourceware.org" Cc: Ulrich Weigand , Will Schmidt References: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com> In-Reply-To: <71926c391f43cee2051ea0c9b449ec0aecc847ec.camel@us.ibm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Tom de Vries via Gdb-patches Reply-To: Tom de Vries Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On 11/16/22 23:11, Carl Love via Gdb-patches wrote: > -if {[prepare_for_testing "failed to prepare" $testfile $srcfile debug]} { > +set additional_flags "" > + > +if {[have_fvar_tracking]} { > + set additional_flags "additional_flags= -fvar-tracking" > +} > + > +if {[prepare_for_testing "failed to prepare" $testfile $srcfile [list debug $additional_flags]]} { > return -1 > } > AFAIU, needing -fvar-tracking is specific to powerpc, so we should limit it's impact to that target. And it's a gcc compiler flag, so perhaps we should limit it's impact to that as well. And if we indeed need it but it's not available, we should skip the test (or xfail the failing bit), because we cannot expect it to succeed. So how about something like this: ... set flags {} lappend flags debug if { [istarget powerpc*-*-*] && [is_c_compiler_gcc] } { if { [have_fvar_tracking] } { lappend flags -fvar-tracking } else { unsupported "gcc used, -fvar-tracking needed" return -1 } } if {[prepare_for_testing "failed to prepare" $testfile $srcfile $flags]} { return -1 } ... Thanks, - Tom