Re: [PATCH v2 4/7] Adds support for recording system call instructions

Pedro Alves
2014-01-06T19:52:10Z

On 01/03/2014 07:15 PM, Omair Javaid wrote:
> +
> + ret = record_linux_system_call (syscall_gdb, regcache,
> + &arm_linux_record_tdep);

This new call must mean this patch breaks the build until
patch 6 is applied:

2014-01-03 Omair Javaid <omair.javaid@linaro.org>

* configure.tgt: Add linux-record.o to gdb_target_obs.

as record_linux_system_call is defined in linux-record.c.

Please split that hunk from patch 6, and merge it into
this one instead. The series (and therefore the resulting
gdb history) should build and remain functional at each
incremental step, to avoid bisecting problems.

> +/* ARM process record-replay constructs; syscall, signal etc. */

Should be ':' instead of ';'.

> +
> +struct linux_record_tdep arm_linux_record_tdep;

Other than that, the patch looks fine to me.

--
Pedro Alves