Re: [PATCH] gdb/testsuite: fix gdb.base/ui-redirect.exp pattern (gdb/26532)

[Tom de Vries <tdevries@suse.de>]

On 8/25/20 3:27 PM, Simon Marchi wrote:
> Commit 1eb8556f5a8b ("gdb: add infrun_debug_printf macro") changed the
> debug output format for `set debug infrun 1`.  It broke test
> gdb.base/ui-redirect.exp, which I missed:
> 
>     FAIL: gdb.base/ui-redirect.exp: debugging: continue
> 

How about the other fail:
...
FAIL: gdb.threads/stepi-random-signal.exp: stepi (no random signal)
...

?

Thanks,
- Tom

> Fix it by adjusting the pattern in the test to the new reality.
> 
> gdb/testsuite/ChangeLog:
> 
> 	PR gdb/26532
> 	* gdb.base/ui-redirect.exp: Update pattern.
> 
> Change-Id: Ie8a8f6675e35a0cab55109b1534b44eb51baec9d
> ---
>  gdb/testsuite/gdb.base/ui-redirect.exp | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/gdb/testsuite/gdb.base/ui-redirect.exp b/gdb/testsuite/gdb.base/ui-redirect.exp
> index e1e6a7b0a08..ef0a79178c7 100644
> --- a/gdb/testsuite/gdb.base/ui-redirect.exp
> +++ b/gdb/testsuite/gdb.base/ui-redirect.exp
> @@ -117,7 +117,7 @@ with_test_prefix "debugging" {
>      gdb_test "set debug infrun 1"
>      gdb_test "set logging on" \
>      "Copying output to /dev/null.*Copying debug output to /dev/null\\."
> -    gdb_test "continue" "Continuing.*infrun:.*infrun:.*Breakpoint \[0-9\]+, foo.*"
> +    gdb_test "continue" {Continuing.*\[infrun\] .*\[infrun\] .*Breakpoint [0-9]+, foo.*}
>      gdb_test "set debug infrun 0"
>      gdb_test "set logging off" "Done logging to /dev/null\\."
>      gdb_test "help" "List of classes of commands:.*"
>