From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id 33jOMh4Yr2mFlyAAWB0awg (envelope-from ) for ; Mon, 09 Mar 2026 14:57:34 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=dWxm5W8p; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id A57431E089; Mon, 09 Mar 2026 14:57:34 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-2.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED,RCVD_IN_VALIDITY_CERTIFIED_BLOCKED, RCVD_IN_VALIDITY_RPBL_BLOCKED,RCVD_IN_VALIDITY_SAFE_BLOCKED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [38.145.34.32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E372A1E089 for ; Mon, 09 Mar 2026 14:57:33 -0400 (EDT) Received: from vm01.sourceware.org (localhost [127.0.0.1]) by sourceware.org (Postfix) with ESMTP id 7003B4BA23F8 for ; Mon, 9 Mar 2026 18:57:32 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 7003B4BA23F8 Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=efficios.com header.i=@efficios.com header.a=rsa-sha256 header.s=selector1 header.b=dWxm5W8p Received: from YQZPR01CU011.outbound.protection.outlook.com (mail-canadaeastazlp170100000.outbound.protection.outlook.com [IPv6:2a01:111:f403:c104::]) by sourceware.org (Postfix) with ESMTPS id 042AD4BA2E10 for ; Mon, 9 Mar 2026 18:57:05 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 042AD4BA2E10 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=efficios.com Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=efficios.com ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 042AD4BA2E10 Authentication-Results: server2.sourceware.org; arc=pass smtp.remote-ip=2a01:111:f403:c104:: ARC-Seal: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773082625; cv=pass; b=WK+oeeCpYC8CIit1alViREWmTUujlt2DKTvcJGE9NEimj95W+rgpNjNwWGL+k1FfCLdDAqsDD7BgEVV7qmrsJQLAejDPqqUc/Irw8ngGzf2n3uUJJRzSjSGwfGOJEA6mZDTywS9e8m1/iqmf7mUUIhzk2iQUf9arE45N1a0F8C4= ARC-Message-Signature: i=2; a=rsa-sha256; d=sourceware.org; s=key; t=1773082625; c=relaxed/simple; bh=7l+jhWcWupboGVcWFibIm4Rx7OTtYRMEP87OTt05OWA=; h=DKIM-Signature:Message-ID:Date:Subject:To:From:MIME-Version; b=kN4G5uSaA4QVJrzB4B+MVstU49UkE++Ph/YWo7QdSMGjSLgM1Uex3dCNPYlHyTr+QPU8ityHTFoBJOLs5g1YqIPF463gedPKG4US7iXkCRgiICAaZriEstZTMsu/ImMH51N/zJM65AdlQUS525cz51fE6V1NNMzOeeN31d6DoN0= ARC-Authentication-Results: i=2; server2.sourceware.org DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 042AD4BA2E10 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=mtOefn2v0X2vqS8NuD70pSMZs0omZ40xrddHeqygsSzbtA9Rk22RBSLx0YCxZ9VkGtTXlTIehGGn8rS4ZKj43L8sCmpVXM4kZqyXONU57hBkKZGnhM2lPSe47O5g2V//KnV1UNa3lqmqC1TPfc5t+41ywEnVHgoaH0kVbpfitow3JArD/6Cssdq/w7vOsSQBZuddy07GQVJS2KmKSzJIHMHOugbgvK5HR6MzTWNRAVIOfxAp+sfeTqHmYV15UIxgbntSLUI4xlRowYaSUOsHGv+mKZmw4R0l7L8pnKW6JNFAluO9Xa4MkycT30Yj4/pnSdMjc1UmOnEVnn64TB13Iw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=Sr0sBz7bJPObXIXnaWYNxR8Vp42JJjMg24sWMO6hxxE=; b=p5beg97r8KLjGZbzuQg9CdzCRkuzqKv7S94vAzUkFHGLJvjSyjNHR87ujNjg6nbKfqPGdWmV3DC+VTdT3wX863+8UA7FmxVKBEBDezIjldDiqtUjNJMhhtN2JOQlcTyk9sU7HCTvSheuQA4jLf5wT4FWdOVr/eqw/XA4FYzvw/9yIhHaZAvuDENLW4QwE4FmXOOTirVQGvQciHjvlWzlSKWoMnjLqoCqUgTJGMMXZYxfJXplOZwUoGxTviSAvd03LWFfd+yXNmvlzIhKFZD6JtIEyFm+sgcO/xVtBv019hTFa2I0lYAGHHVfqZulbz0Ii7u6x66uPSIPYdsizyywgw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=efficios.com; dmarc=pass action=none header.from=efficios.com; dkim=pass header.d=efficios.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=Sr0sBz7bJPObXIXnaWYNxR8Vp42JJjMg24sWMO6hxxE=; b=dWxm5W8pIEZmdDVmn7OKXCGcqXAkJPmif/FMwS5FNCr9WIbLre4pjpK/IC7D52WZK+O5YRKHSjEmSPRobZAIKg3O+EOAC0yiFEmr8OvmvsWUNLVAp2yP3CiRIO86XRY9WIGTfO6wDgEAfAEi/CY2saDiRegPgKnzjl1jVRBF/wZ5UbW5yrTCdZik8KefLOSMTBz7kmPFcm6IXqEAcECYluDQmWwQenCa7WW9zIYcw4DL8iZb8Eps7MuV4NJKFwb8hcmjy4oG15Ztf2al6cm0vVadfXSuoAt1huKjr15vAsgPDT3XsZcwH9DsXcgAcyCP5NSB0dCp5ahw+gepRTMvxQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=efficios.com; Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) by YQXPR01MB6573.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:4d::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9678.25; Mon, 9 Mar 2026 18:56:58 +0000 Received: from YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d]) by YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM ([fe80::bbfa:179f:fdc8:b15d%5]) with mapi id 15.20.9678.024; Mon, 9 Mar 2026 18:56:58 +0000 Message-ID: Date: Mon, 9 Mar 2026 14:56:56 -0400 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 7/9] gdb: make expanded_symbols_functions hold compunit symtabs To: Tom Tromey Cc: gdb-patches@sourceware.org, Simon Marchi References: <20260217195329.3833518-1-simon.marchi@polymtl.ca> <20260228035425.422765-1-simon.marchi@efficios.com> <20260228035425.422765-8-simon.marchi@efficios.com> <87seafo0xu.fsf@tromey.com> <87jyvro0fc.fsf@tromey.com> Content-Language: fr From: Simon Marchi In-Reply-To: <87jyvro0fc.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: YT3PR01CA0126.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:b01:83::22) To YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM (2603:10b6:c01:2c::6) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: YQXPR01MB5418:EE_|YQXPR01MB6573:EE_ X-MS-Office365-Filtering-Correlation-Id: 95c90d6b-1196-46c9-c306-08de7e0da36d X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: HZitFpwHAgai6CLCFB+xQE4eVOc3aYwxdM6Zh5HJgXp1Gi4ZQzUt7u2dQ+TlK68tnLyFrlfhwzJgd/9vT8AQ2/pUntzGK5aPcXli6SN8CfN0e/uda6hJNaJgGOa4YTcvFtM7JFjCzbeL1qfGQ6tMum4G7+5vbAs6No0EnHd9+NptOdd88DO+DXO5MMAxvZzGzBdHTslfHc6HJY7gyf9do4IacRAEqNyUBt4LClAlkt+0nJShOYQdlO4LbNK7J3KWWG2GxXzlLDUWYXI9uB9WUMboTAPQgJuGCJxatfARTKze2E0ONLwCEejSUFrL6/Q3cXbtqwLv6i0vU8m8eI1haczvPAYMrr3ubN4t+GGNUuareJSwXH4Y2EmIBHnqdu0jPGLrg5DERm8F8Ofy4jLmLRhSXOwvGqnCOQZ3XzLgjQcrc/PkaBrWpNmwFDvHt0nYMQWDZItTfY6HVKG7BLQ1OmUIA3pKFm9/2rn6JIGClIb1PsltipYS+NkBk+9LbFcd4bGUHFD2V64TmCKRYc/SvxLH3CnWu8UFqC5Kgw+zpdSIyImH77o20T0ItvVGC0Qq5iMLIxWf35wE49iU7b0WDo+YBjEmTvn9C0FgOdjfYbqasp/ulHVicXlvsK0eysthqkl6xqurnMpXJWaHMejAjmpfha5Dub3o0fpr99Nl3s9E+LgwkrrRO985ZXpDxvBi205BDAaG5fkQIz7KMJSqEA== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?UVBGOXBvaEhjQXBaclhlc0diQVVwYlF1YjZZeDdHTWpzWFpLQ0RJWTdWYm16?= =?utf-8?B?eHU2bmh3bGMvYzVSZThGSGxqZ2ZaWC9ENlRnNE54aytPY29SYmVxREtBWFpW?= =?utf-8?B?dzJDOURlUGR6NGI4TitGZ3BVdTVvK0RxWHpUS3QvLzQyK2NCc0s2SlRDYkhz?= =?utf-8?B?eWFYcXdQYlBBV29XdGZNcWRmZXlPQXVJb1JTd05TQVl2Vzdub1YwSUlSb0lV?= =?utf-8?B?RklXeWlMSmlrb09pcEw2YlBrbVdBaHZoMVBTT0tabUhoc3FoSXIrT1h5ZGVY?= =?utf-8?B?UGhOZlBhdk9HVkdWTlE2WW82THlaOVA1ZFdGY2toamMyRjQvM3Vpb0xwdUpv?= =?utf-8?B?RVRMNTJweGFEbWh6KzZlemhJTDRWMmQ5NTZZS1F2Q052czhrcGo2cHZRWFBn?= =?utf-8?B?cUptYlB1Q3J1NWRIaCtGUTRxeVQ3Ymt5VnJTUm82cHhjaHE3SzRjWld0c3ov?= =?utf-8?B?aDQ0akdBOVZ5TFpkVVhzbTFiZkpiYTErR2d0Q1BVaUVZR0JQZTRNM29jK094?= =?utf-8?B?Vm5iL2NsenlUeXpSajNPNlUyMGFMU2NjVnZza0NBZmt4M3htcXBhL3owUVpT?= =?utf-8?B?alBmNVVEZk91WmRPZjNvNzN3Sit3ZXNsSG9TSURwNzdMUFlXdkFiTUFwVG00?= =?utf-8?B?aW40THBZam9uczFYQmZzekV1aXdtMmlSUTRiRGxzTWd1NlI0YXNjcXFiKzJw?= =?utf-8?B?WCtZeWJhNzJTdnloQ2ZKSWpQSnhicTYzaW02a1p2Y1FmUVk4aHdSVTVzTjZw?= =?utf-8?B?L0J3aFlDWkIybTRaa21rYjY0enRINkhuREpFcmRlUGxGbzE3c0dDdVVKK1FZ?= =?utf-8?B?ek9vWkIzYkdCeGN0dDc3OVdsZTZVMDJKY0FrK2RHMEltYTYxSDlnN2JjdDVr?= =?utf-8?B?UTFiMkF6cmVTUTlUQmNVRlRET3h1ZXVaTjg1WlMzVFdUV1JUVG5yT05WQzIz?= =?utf-8?B?Y2dEOUJFb0dmRGxxZWd2dFJhSnUzaWNvdFllcTFsd1hSSU9mRWlOSGFWdnBG?= =?utf-8?B?bExGSS9mWXh1cityY0Vic1V6QWk4eTB4ZUdnL2hEeFhyVDNvZHVFVUFmSXV1?= =?utf-8?B?aWdnNytEc3o1Vzh4UTV0a0Q1NEh3NFp5UnJvZlhjdjlpU1poZDRkWklUbXl5?= =?utf-8?B?MzI2b2V3SkZzakFJR0VBMnJucEFlMUtndVJ5ZWV5dHhvOGZGbFNaNWN5Ujg3?= =?utf-8?B?emRqR2JTNTFCS2N4OTVQbDJldXBYQlYxVlRaSCtkcGdFbDZMams4cHRNeldK?= =?utf-8?B?MkdHQjVOMFNvM2ZadzVQRnRUT2ljaU4rOXNPbnhBU3FCTHRtNmV1QzRiNks1?= =?utf-8?B?UmVvbEtQVHJBZXFFYUJrdjBIb1p5Y2ZHUWtCNVpObkRoZjhBTmZwVktFMDV5?= =?utf-8?B?WERlb0JRUStiazVlMkcybkVKSDVIcTlyU3JsVk9kWkQzNEswMU0wS2d2NWdR?= =?utf-8?B?Smc1NTBZMUNuRC91OTdsWlFjMkJWdnZDTXJMWHRmNytBN1RTb1Z1dHBSNHVk?= =?utf-8?B?VHMxSEhEOUE3aFptY1BnRXpsTklWNlE2b2M3VWdQZHZRNWNmZUo1WFRTdHJj?= =?utf-8?B?UzNrRGJMRi9nU3RjUUh4eGRpazJIc0FOTFlyK0toVG0vQUNCN29BbmNJSmhM?= =?utf-8?B?QjZPSVArNUNhM2EycVR2WHg1L3VIb2Q1UEdBVXVXYWNjTFFNbmdGdW9QaGU2?= =?utf-8?B?bEpoaU5tV3VYV0NvYmlBS3ZzNWh1M3pUbmF0bE5wcFZKWTV1R3BCUElSUVpG?= =?utf-8?B?KzIyMXpJZ0xEWHZ5MW5Oajh1ZVJ6b0FvOFFEWmNkMXEzditFRXRmMVlUeGNW?= =?utf-8?B?cFBRaVplclFzR00xSUVYQnBIQ1lHVkMvMFJDZHI4Tzd2a2JMcGw4R25YWTRM?= =?utf-8?B?VU85YVJBQ2tuMHZBbmZqZjZJcENNU3pCTmJIOVM0ZDdwUlBpb3VyaEsxdGFZ?= =?utf-8?B?SWhBNEVqQ2MwUk53ZDYvUkE2UjBpcUJvNkVYNG1KeHpKMWtwQVZac0JLOUM4?= =?utf-8?B?aUJ4WHZ0b0ZqcEtSSnhtd2pnOHZicUdEZTNQM0QwR0NsTFNPaXp3OWIzQnRO?= =?utf-8?B?VHVpbGUvQUhhRGUwbGVJQkVkN1ArVWdORC9DUmRTNWo2aURadEJnbFUvc0V4?= =?utf-8?B?VjI4NjJnSlh1N1h1YXMzQmJsYXZkTWw2QkdaQ2EvM1dDZFpJV2x0WHMwNzZl?= =?utf-8?B?bVIrN1pMOWdsTUFBZkcyTWpwN2s0S3BCTy9WUVViUU9acEZXYVVCenVFT005?= =?utf-8?B?VUR3T2l1eDQ3cjJxVzF3SlRvVlNnczMrL2lNZTVZd2EwN0E4bkNjcWhWSEVx?= =?utf-8?B?RTdVbDlYU1ZURDNGbG9NUkZMM0FFN2pEdGp4Vk93MDlDNlZOQy9Wdz09?= X-OriginatorOrg: efficios.com X-MS-Exchange-CrossTenant-Network-Message-Id: 95c90d6b-1196-46c9-c306-08de7e0da36d X-MS-Exchange-CrossTenant-AuthSource: YQXPR01MB5418.CANPRD01.PROD.OUTLOOK.COM X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Mar 2026 18:56:57.9279 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 4f278736-4ab6-415c-957e-1f55336bd31e X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: vFpY7iIr5B/hXEHB8gvLxNk39zAcWHzZMrmQsyzzb7F1/E3aS1IIypJPaKBZpO/levp2t//vdmNHEHNlDeHp6A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: YQXPR01MB6573 X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 3/4/26 2:32 PM, Tom Tromey wrote: > Simon> Change the expanded_symbols_functions quick functions type to hold and > Simon> use a list of compunit symtab to search. > > Simon> Right now the sole user of expanded_symbols_functions is JIT. Update it > Simon> to keep a vector of compunits as they are finalized, and pass this > Simon> vector to the expanded_symbols_functions object. > > Tom> I think this is a good direction but this patch isn't quite complete. > Tom> The issue is that there are still a handful of spots in gdb that loop > Tom> over all compunits. But with this change, these spots will skip some > Tom> compunits. > > It took me a while but I finally realized that the new vector is in > addition to the objfile's compunits. > > This seems kind of ugly to me but OTOH it doesn't have the problems I > ascribed to it. I just saw this reponse after sending my other email. I don't really see how it could be less ugly, given that the expanded_symbols_functions needs to know which compunits it is responsible for. An alternative would be for compunit_symtabs to have a backlink to the quick_symbol_functions that is responsible for it, but it would make iterating on all the compunits for which a quick_symbol_functions is responsible for less efficient. Simon