From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id lnoWLRa4mWrVCyYAWB0awg (envelope-from ) for ; Thu, 03 Sep 2026 14:10:30 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=qIUL4BeI; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 990271E166; Thu, 03 Sep 2026 14:10:30 -0400 (EDT) X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-25) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-5.4 required=5.0 tests=ARC_SIGNED,ARC_VALID,BAYES_00, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI, RCVD_IN_DNSWL_MED autolearn=ham autolearn_force=no version=4.0.1 Received: from vm01.sourceware.org (vm01.sourceware.org [IPv6:2620:52:6:3111::32]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange x25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 85BD21E033 for ; Thu, 03 Sep 2026 14:10:29 -0400 (EDT) Received: from vm01.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 478D94BB1C0B for ; Thu, 3 Sep 2026 18:10:28 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 478D94BB1C0B Authentication-Results: sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=qIUL4BeI Received: from donkey.ash.relay.mailchannels.net (donkey.ash.relay.mailchannels.net [23.83.222.49]) by sourceware.org (Postfix) with ESMTPS id 514BF4B9DB5F for ; Thu, 3 Sep 2026 18:10:03 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 514BF4B9DB5F Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=palves.net Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=palves.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 514BF4B9DB5F Authentication-Results: sourceware.org; arc=none smtp.remote-ip=23.83.222.49 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788459003; cv=none; b=s9fmxy5f3fnQkH0AtUyTwphjRNmb5ENqsmACDraKkzMLQgkjqiqTTVdW57nrgmZOan5QptstThJA4Tcusd9HpBr/Q1Sqe5ru6hLgkWpfTaqXP14AbeCuBViSbndnsdfoAF6lrEmM/3Q1fWofYwxjExb4v7+PiZsN/nvjvhy5IcA= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1788459003; c=relaxed/simple; bh=CKWfL7v3cDClPvovwMMzOGF5glKDHwQtg5JhoPRx9cc=; h=DKIM-Signature:Message-ID:Date:MIME-Version:Subject:To:From; b=JTGSYgU6cMKO580oujXlSSt/Nu1f5sp1l1nh0819wUuMrq7bev6Qp9KbbZ5HGxk2X9f3LQtxvoJI4+dH04mm/+YIyBmXecwkZDcgDDrRTxaBLBczxXgR+V9M70CxHZxCloZqiMWPJGn9jaKIucV0Zs23rl8Nu3+/YY9kkJn3wyw= ARC-Authentication-Results: i=1; sourceware.org; dkim=pass (2048-bit key, unprotected) header.d=palves.net header.i=@palves.net header.a=rsa-sha256 header.s=dreamhost header.b=qIUL4BeI DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org 514BF4B9DB5F X-Sender-Id: dreamhost|x-authsender|pedro@palves.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id E419A721F1E; Thu, 03 Sep 2026 18:10:01 +0000 (UTC) Received: from pdx1-sub0-mail-a240.dreamhost.com (trex-green-3.trex.outbound.svc.cluster.local [100.97.107.227]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 8675B721DD1; Thu, 03 Sep 2026 18:10:01 +0000 (UTC) X-Sender-Id: dreamhost|x-authsender|pedro@palves.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|pedro@palves.net X-MailChannels-Auth-Id: dreamhost X-Blushing-Industry: 6a9abdf80b743356_1788459001752_3922547428 X-MC-Loop-Signature: 1788459001752:1024301695 X-MC-Ingress-Time: 1788459001751 Received: from pdx1-sub0-mail-a240.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.97.107.227 (trex/8.0.2); Thu, 03 Sep 2026 18:10:01 +0000 Received: from [192.168.0.201] (bl22-81-37.dsl.telepac.pt [2.83.81.37]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: pedro@palves.net) by pdx1-sub0-mail-a240.dreamhost.com (Postfix) with ESMTPSA id 4hbSLJ5wGFz1049; Thu, 3 Sep 2026 11:10:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=palves.net; s=dreamhost; t=1788459001; bh=hcRmaaogZVPLN3hxeT6AEEBcyVT7vdi1dsebeQWmvwk=; h=Date:Subject:To:Cc:From:Content-Type:Content-Transfer-Encoding; b=qIUL4BeIm9iL0Y94rbc3anjidFPYh9KA9IoIVaHuILChRyQC0TQ6BlpH8AeDDG4YK 3A8IFSoJVMgEp7Kk3xhxfuGthk/vzQQFbhGoLBvVTMm6RXGDT0vYTnlQCK8ZqUV013 0kpYsFmLhPjEVrT81rokH/F28ThNxGl6TBvKUw7x/1ma7X8jknO4MLU1j+mwdetz5+ hwRCSq3An4wOv0OhfNjkyi5cNdPHF06Mo16ZI0IhfPgDBItDUyDZqGTQTSXPa1gVZt 7KIH+j5vs4XHAE1P924IlH8m5/PTsOtsVGIKZOSh0QVMyzreTrsEV9DDvjpecUDpPt tKzFlVMU6BEVA== Message-ID: Date: Thu, 3 Sep 2026 19:09:51 +0100 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] gdb/Windows: Make windows-nat skip iterating GPU threads To: Tom Tromey Cc: gdb-patches@sourceware.org References: <20260619163813.815335-1-pedro@palves.net> <87a4qfqsge.fsf@tromey.com> From: Pedro Alves Content-Language: en-US In-Reply-To: <87a4qfqsge.fsf@tromey.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces~public-inbox=simark.ca@sourceware.org On 2026-08-21 18:44, Tom Tromey wrote: >>>>>> "Pedro" == Pedro Alves writes: > > Pedro> When the AMD GPU dbgapi target is pushed on the stack, the GPU threads > Pedro> are put in the same inferior thread list as the CPU threads. > > Pedro> all_windows_threads() returns an iterator that walks all threads that > Pedro> have an inferior whose process_target() returns the Windows target. > Pedro> So it ends up walking GPU threads as well, which is incorrect and > Pedro> leads to crashes inside gdb/windows-nat.c. E.g.: > > Seems reasonable to me. > Approved-By: Tom Tromey > Thank you, I've merged this, after rebasing on current master and doing some smoke testing. Pedro Alves