From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Xt4AIIjVOmZTMAoAWB0awg (envelope-from ) for ; Tue, 07 May 2024 21:29:44 -0400 Authentication-Results: simark.ca; dkim=pass (2048-bit key; unprotected) header.d=brasko-net.20230601.gappssmtp.com header.i=@brasko-net.20230601.gappssmtp.com header.a=rsa-sha256 header.s=20230601 header.b=ww1zpW83; dkim-atps=neutral Received: by simark.ca (Postfix, from userid 112) id 724261E0C1; Tue, 7 May 2024 21:29:44 -0400 (EDT) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 0DEAB1E092 for ; Tue, 7 May 2024 21:29:42 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 83B8C3858410 for ; Wed, 8 May 2024 01:29:41 +0000 (GMT) Received: from mail-qv1-xf33.google.com (mail-qv1-xf33.google.com [IPv6:2607:f8b0:4864:20::f33]) by sourceware.org (Postfix) with ESMTPS id E0EA73858D1E for ; Wed, 8 May 2024 01:29:22 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E0EA73858D1E Authentication-Results: sourceware.org; dmarc=none (p=none dis=none) header.from=brasko.net Authentication-Results: sourceware.org; spf=none smtp.mailfrom=brasko.net ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E0EA73858D1E Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2607:f8b0:4864:20::f33 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715131765; cv=none; b=QqSS8e6hl4u6QaYw1rFpmRyR/AD3p4FFGpOX9U4RrAwl+LlNajZgfKBQGuLduuiexEQzLRhBHcPXZzmUFeebDeJ28spX+4OuUE5kw/hze8JY1o2wPaDslZKolbEyCN8+D1X4c5dXu+3DJ/0h7DcgaPbQtqTlxbDL1asuUuvh2KI= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1715131765; c=relaxed/simple; bh=af3rgQXA/EqbazJrbDGQMvG3LJrUo5H/EjVlOCdpjA0=; h=DKIM-Signature:Date:From:To:Subject:Message-ID:MIME-Version; b=ojDdthKXfUPWkgJYTEVbasx1PJXetVMXRij0NiXafzz7KW1dbKiaUdN4I7BFaKfS9mKFbmUbMqOITbo40pkiIowY3nUWuZ8+e+zlCt3i50YO+Ugh3TdNndFO3rnyNeKSyzKIBAo413iRUNdeKPws08nqpG9ug345i7fEsNl/+pE= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by mail-qv1-xf33.google.com with SMTP id 6a1803df08f44-69b5a87505cso21248836d6.2 for ; Tue, 07 May 2024 18:29:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=brasko-net.20230601.gappssmtp.com; s=20230601; t=1715131762; x=1715736562; darn=sourceware.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=Newqfo+3YsTZI7MMxZuMi/HAxfcZqRwO/7ztFGrPbxg=; b=ww1zpW83dtoH+AZ4MxFpek8rDJNSrpCiLKFIXoJkUi0LS7fh2egG+4lyPRt2Knhlxb HGqPxoSYfWGnHbUimip1MD7g7i+RwF+IKAg9pjMAaXs8Yq5Yy+uU0PP2zGaO6WYRqx/c xmVWOfdhQK7t7c50VAXheN41SqMF05d14GJe9OwY9qzQBrfQ7r5DM7kf+ZPEPmxbmkuT zWotJbuPpyvutjSl2/sK52oJOpXFmBU+7hfS28WidEttE5vOtXYn+7x7QTRz9fC4h6L7 8sGzUiTWXzUIDeXUG4qySK2hn52zW3pVzvzcqQosyrSwlv3xEO6Xbjzkl2cZcBOS2RPu tUJA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715131762; x=1715736562; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Newqfo+3YsTZI7MMxZuMi/HAxfcZqRwO/7ztFGrPbxg=; b=ic0pzumoGj7cRZTGJhqW9k+mGquvXnDkXJ1JCGUxEwBbk5SjUKylUYMPnhW8Ry2jCL W3Mo54UTAl4UI5SgO+whIG37qbI1ahWdXCQEdGOWJhJGGCA1B4pM2NkjcLBnTJUJA4WX r1vcaSJ7a5JqO9DdE3+FqzUU/P2ZpTXiv8ZnqOT/vQMVOtKcy/u9eayJN7pZ2AllDg7g IZEvkZ3rnRI+CYiaoQ05OAGl6VcDEl861417zU31wH6Q7lbRJ9ygjybQSfV8giBl4RIY 40PzNyCJkMKgrM+HlmaA8KLjM5wcP6670GwnVoj7+N6Z3o15Qtn7EpBiR3F3m4Zz0Xhk BygA== X-Gm-Message-State: AOJu0YweOs3TKF8zAu0H/jmw41sinI6uCVPVhZ+MvRzBCCG0bqbqe7Zv WqdDnFLyMx5pGyFl21Ke5EEx9LgjQ4DEvbFRj9eCfLvpeTBbLOBn8LqcCpPdvnl6ogbSZZsve8z 0 X-Google-Smtp-Source: AGHT+IG3XroIYWmjTqQhZsR2KNPu0XgUIfDcKrAk5PFILWrNS0KAfEYyu7GG3gtavOpm9cAYZ5AijQ== X-Received: by 2002:ad4:5ae7:0:b0:6a0:a98a:487c with SMTP id 6a1803df08f44-6a151442144mr19025856d6.19.1715131762175; Tue, 07 May 2024 18:29:22 -0700 (PDT) Received: from zelda (pool-108-12-199-157.prvdri.fios.verizon.net. [108.12.199.157]) by smtp.gmail.com with ESMTPSA id s13-20020ad4438d000000b006a0e04887edsm5098547qvr.73.2024.05.07.18.29.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 07 May 2024 18:29:21 -0700 (PDT) Date: Tue, 7 May 2024 21:29:19 -0400 From: Bob Rossi To: Tom Tromey Cc: gdb-patches@sourceware.org Subject: Re: Optionally print source code to gdb console window Message-ID: References: <87ikzpa7k6.fsf@tromey.com> <87y18lunti.fsf@tromey.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87y18lunti.fsf@tromey.com> X-Spam-Status: No, score=-2.5 required=5.0 tests=BAYES_00, DKIM_SIGNED, DKIM_VALID, RCVD_IN_DNSWL_NONE, SPF_HELO_NONE, SPF_NONE, TXREP autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org On Tue, May 07, 2024 at 06:52:57PM -0600, Tom Tromey wrote: > > Can you give me some pointers on how the implementation should change? > > The new flag shouldn't be in value_print_options. That struct is only > for things affecting value-printing. That makes sense. > Perhaps 'set source open' could be extended to have a new value. Or > perhaps some other 'set source' sub-option could be made. I'm afraid > that normally we bikeshed option names a bit. I think it's this behavior of gdb i want to suppress, https://sourceware.org/gdb/current/onlinedocs/gdb#Source "When your program stops, GDB spontaneously prints the line where it stopped" I'm looking for a way to control printing source lines when printing frame information? (I'm modifying do_print_frame_info) Something like 'set frame print_source off' might make sense to me. Just a thought. Thanks, Bob Rossi