From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id Qax8BjZqrmUBFAQAWB0awg (envelope-from ) for ; Mon, 22 Jan 2024 08:14:30 -0500 Received: by simark.ca (Postfix, from userid 112) id 0FF371E0C3; Mon, 22 Jan 2024 08:14:30 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id EEB051E092 for ; Mon, 22 Jan 2024 08:14:27 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 1FA233858D20 for ; Mon, 22 Jan 2024 13:14:27 +0000 (GMT) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id EBDAB3858D20 for ; Mon, 22 Jan 2024 13:14:04 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org EBDAB3858D20 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org EBDAB3858D20 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705929246; cv=none; b=WFBvvkqXnjnioJvOh7y08h3SWVrq0MZ1DYafBMzSvvvAUMpU+kk5CtNro8rAXlczb8I5EffGGgFiTIdRaVh5//LsftPTwmRYlofoafsttmhYy75e85YXJRbJOOtjY0Dlm4xtB9XlJ3avb/mQFMiNAZC4f8gIuRJC5TVzihqmB7s= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705929246; c=relaxed/simple; bh=4IwRkgY7LCLg25oY7or38oCalA8e2p1nr/X2aJq9QZc=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=tCjhgile+SnypANBSgCs1z4nMW7uVdAudVVqnguktaZc0IIOvMIxG2xjrLDLYvSCcnNAtSOz93TBFGMbzZVBnQLIBe8HZlr4jYSmuGmDhkXxz8SHmCnWvHsBwkQHa3+7LdSDYQCN788iC8aBQyN8slxzthUqfoog3XSyq1Rtz28= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 665D5343282; Mon, 22 Jan 2024 13:14:04 +0000 (UTC) Date: Mon, 22 Jan 2024 08:14:04 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Fix -Werror=shadow=local by changing mem to addr in sim_{read,write} Message-ID: References: <20240122120534.232865-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="XIwgT08UcZhUc7Ji" Content-Disposition: inline In-Reply-To: <20240122120534.232865-1-mark@klomp.org> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --XIwgT08UcZhUc7Ji Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 22 Jan 2024 13:05, Mark Wielaard wrote: > m32c/cpu.h defines mem as enum value, which causes GCC 14 to emit >=20 > sim/m32c/gdb-if.c: In function =E2=80=98sim_read=E2=80=99: > sim/m32c/gdb-if.c:162:33: error: declaration of =E2=80=98mem=E2=80=99 sha= dows a previous local [-Werror=3Dshadow=3Dlocal] > 162 | sim_read (SIM_DESC sd, uint64_t mem, void *buf, uint64_t length) > | ~~~~~~~~~^~~ > In file included from ../../binutils-gdb/sim/m32c/gdb-if.c:38: > sim/m32c/cpu.h:83:3: note: shadowed declaration is here > 83 | mem, > | ^~~ >=20 > Fix this by renaming mem to addr in all sim_read and sim_write functions. > Most already used addr instead of mem. In one file, sim/rx/gdb-if.c, this > also meant renaming the local addr variable to vma. lgtm, although missing include/sim/sim.h update -mike --XIwgT08UcZhUc7Ji Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWuahsACgkQQWM7n+g3 9YHdNhAAuctaj05ECBkVIoK1kFtQsdW58L7t40y1vumIft341QtjmkIwRWcgBLbb TgSVxgs884NQICyNqU3LxwwItrVNAMS62+NwRk8BtufFGe5DghJhd90r8WDrkazP yUsW13zhRyUnZxqhZJIkIjDgxx1QGpxtsurLZP6q01fWECxZGOEFaYac/vC3ArO9 bXePVYb3rA2yHslZefjSvFP02KpChJBa0vmA9P0hNkABgZjJCpbUlIsIAwmCdE1A ekgch9jHMJtVzyPLnW2AEsQ7O8xVuENCy9ZMH8Ca9BtNXQ90myNkiCgkXIgDJxub qoZDFFEemJjIwACwiL6xZWdXv0Siyb3xU3ODju8ybt18CbWldQAi/wPRm2S7ETP2 2EbuQvc8YHP72CZAKZVs42GswqjCnx7cAVMx76Gm7LSIgNNb9sQooCVekdh0m3js 7oyC/BGUW+PluQLakC3/1Y23Jh6/uAAaWoX74NCqfggxzxeVRQ69fyRKMr9+rHgD prEec0s4JQDwGbmUDkDXMai4CpTJCjVepsgsIT5SEqdV/832jpAPRBWzDndQ9S8d nLceVjfNUDHqe/4nJXmP+eNJbCE8aRh+DtJ73R3GsH5IAqsxT9yGuXUBKXYVqsbB 4mvo1iy8kg9hzZ9bKzcL8PMo1MQw/yL8LXCoD/kseSXXhMIWzFI= =H4Y1 -----END PGP SIGNATURE----- --XIwgT08UcZhUc7Ji--