From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id J/UAB33krWU+lQMAWB0awg (envelope-from ) for ; Sun, 21 Jan 2024 22:43:57 -0500 Received: by simark.ca (Postfix, from userid 112) id 0B3671E0C3; Sun, 21 Jan 2024 22:43:57 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id ED2771E098 for ; Sun, 21 Jan 2024 22:43:54 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 66F5A3858410 for ; Mon, 22 Jan 2024 03:43:54 +0000 (GMT) Received: from smtp.gentoo.org (smtp.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id E16AC3858C50 for ; Mon, 22 Jan 2024 03:43:37 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E16AC3858C50 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E16AC3858C50 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705895019; cv=none; b=Fx1ImwEj/8oT/8DtkRcx4g5tC/Sy7MSjO+BYgk/EC/ZRbjTOZLsuwe3+aHaeLvPh8VEDa35HYCLjsUCzzepYSvVk+5QFqC9lMcpZOKFwanhqqEe5n/kDJ0vrE01GIe/x0sqXes7u4pGClZtACSEkD5c/MqXkqrbfnvKB/wHV3n0= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1705895019; c=relaxed/simple; bh=Dsm+jRg2V0VRos1i3rpaLw9o/Co+k3dtpRMQHMMKnbA=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=HLCeNOYjITD4EikfG9q/QsPV5ENONGq+F+G6cTMsuoWsuxpv/nPadHjM7n2k3HhaYatbF0ypHtCmLPt4OXni3bHHUrUaTJ+mLz9yLv21nyC201+EYOn0ieh9Ni+3vMkdYTd4svREMv2kG2WrTukwkP3HFrNMuDQvKbty8bmsVvk= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 7F39234324F; Mon, 22 Jan 2024 03:43:37 +0000 (UTC) Date: Sun, 21 Jan 2024 22:43:36 -0500 From: Mike Frysinger To: Mark Wielaard Cc: gdb-patches@sourceware.org Subject: Re: [PATCH] sim: Fix -Werror=shadow=local issue in m32c/gdb-if.c Message-ID: References: <20240121225709.575321-1-mark@klomp.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="zEArjVjLCYibueEQ" Content-Disposition: inline In-Reply-To: <20240121225709.575321-1-mark@klomp.org> X-Spam-Status: No, score=-5.3 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --zEArjVjLCYibueEQ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On 21 Jan 2024 23:57, Mark Wielaard wrote: > m32c/cpu.h defines mem as enum value, which causes GCC 14 to emit >=20 > sim/m32c/gdb-if.c: In function =E2=80=98sim_read=E2=80=99: > sim/m32c/gdb-if.c:162:33: error: declaration of =E2=80=98mem=E2=80=99 sha= dows a previous local [-Werror=3Dshadow=3Dlocal] > 162 | sim_read (SIM_DESC sd, uint64_t mem, void *buf, uint64_t length) > | ~~~~~~~~~^~~ > In file included from ../../binutils-gdb/sim/m32c/gdb-if.c:38: > sim/m32c/cpu.h:83:3: note: shadowed declaration is here > 83 | mem, > | ^~~ >=20 > Fix this by renaming mem to memory in m32c/gdb-if.c hmm, seems like we should change all sim_read/sim_write to use "addr" instead of "mem" to be more consistent with other core APIs. if you don't want to clean them all up, we should at least change the include/sim/sim.h header and adjust m32c to match to fix the warnings. -mike --zEArjVjLCYibueEQ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWt5GgACgkQQWM7n+g3 9YG2wxAA3bnqe8rgPEQeZ+OmOtQXeP3pEwn9pJwJdNlVsdiMYFkwh/0VtwmTRxZW ee0vpyWRGhl66B3+5P19DNafBrLC87ovPsw6U2RgFvIqZFIJ1gvNMCpq8jG1Fk2l vCTU0S21GtYaWdfkfBL749GBdGWZGmofGHiaveertQjEOA+3hteBRIVOjV6uRYll 9ljiUJCcY89CY3dGvN2wDUl6xZnuYEYlBL2JY+82HM+TcdCFzFmNXVgiJPW/zzpB B/kjX30fqr6vgY9ZnOBB9tJKFY6nV+IUuJUcIIf6rmjXFWYH8RpsnlLCyvqmdw4J GgWIUnA4aoY1yX9SK4ZOFlk7BfsJ6a2xZvuYf8reioZN4/L/K5oWPGaaYvBUHPcA 3jb0d4zBlzrInLs9+BHdo7gZ1y/QTFBlkRALWhEjaTBZo5j/uDycnE+M0GICpaL7 XSphq07Wcq7Oi9ITGnj6tuRRr+r71aEpE8Ys+tC+glGjrW+CzpS8x8DwiDHLEfu+ 5fLvIU12vujoeQEqXdoArPi4uRHFcYUCmETo74MC2EAOUF1lIpC8ykkzR5VdaqC2 Oxqnp7F1mBQJjL7iuncI8NNIvFYCiUg8miYd3vh/lta5SlkXov/MnYThDtebitGz dA5q5vIInhdypvm7bkVadOUadgwpUiFyJQSEQ4AjiSFN3UuCpIc= =YzK6 -----END PGP SIGNATURE----- --zEArjVjLCYibueEQ--