From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id IUq3K4Wwg2WqTSYAWB0awg (envelope-from ) for ; Wed, 20 Dec 2023 22:27:01 -0500 Received: by simark.ca (Postfix, from userid 112) id A1F521E0C3; Wed, 20 Dec 2023 22:27:01 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 8DB031E091 for ; Wed, 20 Dec 2023 22:26:59 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 638603861868 for ; Thu, 21 Dec 2023 03:26:57 +0000 (GMT) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id E5E023858286; Thu, 21 Dec 2023 03:26:14 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org E5E023858286 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org E5E023858286 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703129176; cv=none; b=WwSw+1xAtwY+7PBDpUhCJPQmCQH0cIKaPGthVgjx4/E72Rfsls6IL834uHy55nUGi/bKupvIe+4F/SDn3bTeTQ/KvJKxeN79I5CBMLZkOI/a8ohYOaLJfn7ExC68lgZ9GdtiQ49YTGYWJ2CsDynLvSTWo3rUrwywbc5M8+E/swk= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1703129176; c=relaxed/simple; bh=CFi3kmKJC2W+0dhbiso4CV19YPT25PoS8G7kE0d8A/g=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=G7wfQ98xEstvUdl/Oc9Fz/jxYfouWVvPoTuFPOdtO00jjoHezNJMuc64/Jrk4NF/7PneR3koMyRZh1OsxuFeE0054ZLOojHht1ORK1jkjWKw+LESUd3ToQQbwRsJW71sP+nFSyWofvaETqUIVrz8j5ePD2kST1EpwNXA2OoniW0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id 39BB6340DE6; Thu, 21 Dec 2023 03:26:14 +0000 (UTC) Date: Wed, 20 Dec 2023 22:26:13 -0500 From: Mike Frysinger To: binutils@sourceware.org Cc: gdb-patches@sourceware.org, shorne@gmail.com, blue@cmd.nu, stefan.kristiansson@saunalahti.fi Subject: Re: [PATCH] cpu: or1k: drop unused l.swa flag Message-ID: References: <20231219023003.13985-1-vapier@gentoo.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="ZBuI3KhNjwxdp85+" Content-Disposition: inline In-Reply-To: <20231219023003.13985-1-vapier@gentoo.org> X-Spam-Status: No, score=-11.2 required=5.0 tests=BAYES_00, GIT_PATCH_0, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --ZBuI3KhNjwxdp85+ Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable add some or1k maintainers ... -mike On 18 Dec 2023 21:30, Mike Frysinger wrote: > The "flag" argument isn't set/used in this insn, so drop it. > This fixes an unused variable warning in the generated sim. > --- > cpu/or1korbis.cpu | 2 +- > sim/or1k/sem-switch.c | 1 - > sim/or1k/sem.c | 1 - > 3 files changed, 1 insertion(+), 3 deletions(-) >=20 > diff --git a/cpu/or1korbis.cpu b/cpu/or1korbis.cpu > index a8002a371858..b4ecb84ab413 100644 > --- a/cpu/or1korbis.cpu > +++ b/cpu/or1korbis.cpu > @@ -717,7 +717,7 @@ > ((MACH ORBIS-MACHS)) > "l.swa ${simm16-split}($rA),$rB" > (+ OPC_SWA rA rB simm16) > - (sequence ((SI addr) (BI flag)) > + (sequence ((SI addr)) > (set addr (load-store-addr rA simm16-split 4)) > (set sys-sr-f (and atomic-reserve (eq addr atomic-address))) > (if sys-sr-f > diff --git a/sim/or1k/sem-switch.c b/sim/or1k/sem-switch.c > index b63add8817b7..dccc65a0ec14 100644 > --- a/sim/or1k/sem-switch.c > +++ b/sim/or1k/sem-switch.c > @@ -1056,7 +1056,6 @@ if (EQSI (ANDSI (tmp_addr, 268435452), CPU (h_atomi= c_address))) { > =20 > { > SI tmp_addr; > - BI tmp_flag; > tmp_addr =3D or1k32bf_make_load_store_addr (current_cpu, GET_H_GPR (FL= D (f_r2)), EXTSISI (FLD (f_simm16_split)), 4); > { > USI opval =3D ANDBI (CPU (h_atomic_reserve), EQSI (tmp_addr, CPU (h_= atomic_address))); > diff --git a/sim/or1k/sem.c b/sim/or1k/sem.c > index 95c474dc478b..973590d41154 100644 > --- a/sim/or1k/sem.c > +++ b/sim/or1k/sem.c > @@ -933,7 +933,6 @@ SEM_FN_NAME (or1k32bf,l_swa) (SIM_CPU *current_cpu, S= EM_ARG sem_arg) > =20 > { > SI tmp_addr; > - BI tmp_flag; > tmp_addr =3D or1k32bf_make_load_store_addr (current_cpu, GET_H_GPR (FL= D (f_r2)), EXTSISI (FLD (f_simm16_split)), 4); > { > USI opval =3D ANDBI (CPU (h_atomic_reserve), EQSI (tmp_addr, CPU (h_= atomic_address))); > --=20 > 2.43.0 >=20 --ZBuI3KhNjwxdp85+ Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmWDsFUACgkQQWM7n+g3 9YExzxAA1vVC7E9sZ6uMR4Xud6wrZPbalMLgZZ+lMd57y9G/Ek6F1fOZfnUazi0n d/ZdhVwWkS2e9FB554XY05/grIkA7GZNJFDUGeOuXwO15rLbCChphle6muZAinKC twy2LgIlvW7UEPAH9OC1Efg5YrPiiuH5mFDWZtpchTzhuTQlB3kEFC3g1VW5Bed4 tOEmelVWm1VABwMvdu6csL3E5kki2wm5TpbCU3iybJvHWka5k80cFhK+Y5KgfgNY 94WHUiLVgBw0dl628Qqfir7JVYNuV++r9Fa9pNJEWk3AcawFgNbFp8PrygPOeXLD sZylE+HassOux2KoVWVtk5Xku77Vj+D/pgOkvdQrcGji7/e1sj/NQukabeOGKPvL 0T0vM5zDV0n0qHRvzTNoD8X6S6H6RkceBMBxtK8Mzba8Sh3cfGS9RgYa9blnwguA CmU2BOjMOSInJezeE12mg2HZPeZFx6/4dkX4qpHJnWcC8gepdhbRVie/Q02KeCWG mkYMK7PZG8otNogcUEQX/z0kSQxSxeTQRpjAm6mGTR2Gqk65mkWmIpsJKboT2jti mQQ/jWbjs0jXgMSB15Oz2oQwsd54yFGzoVoum0tWtFiQXE6R1a8m+4UUPRqIhQmP xFqTXgJKpVu/cy2eXN4zNLZ7JKdNHHS0cY70+hpDOhfmUy9x62c= =UYnJ -----END PGP SIGNATURE----- --ZBuI3KhNjwxdp85+--