From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id QESdCxzvZmW9RhIAWB0awg (envelope-from ) for ; Wed, 29 Nov 2023 02:58:20 -0500 Received: by simark.ca (Postfix, from userid 112) id 2C1FF1E11B; Wed, 29 Nov 2023 02:58:20 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 1E9A01E00F for ; Wed, 29 Nov 2023 02:58:18 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id CC1173857BBC for ; Wed, 29 Nov 2023 07:58:17 +0000 (GMT) Received: from smtp.gentoo.org (woodpecker.gentoo.org [140.211.166.183]) by sourceware.org (Postfix) with ESMTP id 64F3E3858D3C for ; Wed, 29 Nov 2023 07:58:06 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 64F3E3858D3C Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 64F3E3858D3C Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=140.211.166.183 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701244687; cv=none; b=UxLkHXKTluJgY3e6iOW0tcV1S1xhlVqpcy5oroMVodA7BjsH265DfGYpQbYm++xewXu5ElLxQr5CTdYqab8x1+ReZSulf2n5lmN6DjS1mnYeK587qKvqQoYfK4C7Bvzc7lIHJGSaYzjje6Y3nToDbNu5sWCf8ApoM5J5b6DaIho= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701244687; c=relaxed/simple; bh=VLMDVFDpia6QGTj3/6Lo4O0FO9f9NMiy1emD9W8UY2o=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=vl3PXzilxQU/FJ2Dn+8b9slEAR49/6xayrkPt0PLjHYKkA7AS8mxYt5AT7MrnJgmsGoNFoo0FjuziiL8cruR9gytH9L54WTNQaOKgnQKcgzj+WwidvQOexJvzY+7ic+rzU8I20TuPzW8fVFI23qz43tu0YTGcdKVLbAliCwkcP0= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id B415F335D0E; Wed, 29 Nov 2023 07:58:05 +0000 (UTC) Date: Wed, 29 Nov 2023 02:58:05 -0500 From: Mike Frysinger To: jaydeep.patil@imgtec.com Cc: gdb-patches@sourceware.org, aburgess@redhat.com, joseph.faulls@imgtec.com, bhushan.attarde@imgtec.com Subject: Re: [PATCH v2 2/3] [sim/riscv] Add support for compressed integer instruction set Message-ID: References: <20231030130042.1472535-1-jaydeep.patil@imgtec.com> <20231030130042.1472535-3-jaydeep.patil@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="pirCecSPhrWUe43E" Content-Disposition: inline In-Reply-To: <20231030130042.1472535-3-jaydeep.patil@imgtec.com> X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, RCVD_IN_MSPIKE_H3, RCVD_IN_MSPIKE_WL, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --pirCecSPhrWUe43E Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 30 Oct 2023 13:00, jaydeep.patil@imgtec.com wrote: > Added support for compressed integer instruction set ("c"). i haven't been keeping up with riscv specs. is the compressed extension finalized ? so you're only implementing official insns in the spec ? i don't think it's appropriate for the sim to implement vendor-specific stuff at this point in time. > Added gdb.arch/riscv-insn-simulation.c to test it. > Added simulator tests in sim/testsuite/riscv/c-ext.s afaict, there is no relationship between the compression & semi-hosting work. these are just two things you're working on ? so they don't really need to be in the same patch series. > .../gdb.arch/riscv-insn-simulation.c | 1544 +++++++++++++++++ > .../gdb.arch/riscv-insn-simulation.exp | 31 + i'm missing something ... why does there need to be tests in gdb at all here ? -mike --pirCecSPhrWUe43E Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmVm7w0ACgkQQWM7n+g3 9YECKg//T8g32gtHHr6O5+wqye3ZCqZsIQzkyNUMzpg/1hbE+8ZHmd+2AgoEEq9R 7qbFZQUPmBVFjzvnrqwUxTl4WMq52NXTLalXyyj18oZwg7mctjii0XrY139totmg LQC4fK2fQzGM+jeMbCnsY0OfQZZ2d3uaAXn5XFikB32dgPj66IYidr2UcCr0XW+o JKOWr9n1z4R2/KiZJ6aLB40km4F4GvZ9jLxasJTK2weBWNLo3Akzc/+3GCyHENSR 4+eRFxTDOF7lidfn52hUYWsWVWZADnke3nNrHf9ENT+YXW9BPJqf89oiivmg2Y2s SKIKlTh1UH8QSltofx5221MJewsJbRQ43gu9YZk+qbmdIkhEcJLyat3UznBbPXz7 C43zi3sar2Eh/mSHNQwjtmOXD6U/9XZli6YwY6EfzTMXdCEe1OSqsP/8zJQyQnSy pv5fzAOF1HCZFYPN0Qjvo6SBB/upFRaNLvcnTREKYimKY8dqqExeywluLMgbU/6k 13SAd0R84LwEBdtqA1UWktHZ+3OBiJ/WlEOeHJQdLnbwtzplczivbJAyZprH7CrQ y0QrGiECOqI1TjaPc9jkiS2RTft1BvH98dy9fPhvhztv9kWuDCv2Rwry7IRHf+ck JoTrbxBRhrFYbMb00BHUDlRfb6TsIjTaQPem0l6ew1dymBepHz8= =mn7z -----END PGP SIGNATURE----- --pirCecSPhrWUe43E--