From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id yljDBPnuZmW9RhIAWB0awg (envelope-from ) for ; Wed, 29 Nov 2023 02:57:45 -0500 Received: by simark.ca (Postfix, from userid 112) id 020071E11B; Wed, 29 Nov 2023 02:57:45 -0500 (EST) Received: from server2.sourceware.org (server2.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id E51A11E00F for ; Wed, 29 Nov 2023 02:57:42 -0500 (EST) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id 5AB263857038 for ; Wed, 29 Nov 2023 07:57:42 +0000 (GMT) Received: from smtp.gentoo.org (woodpecker.gentoo.org [IPv6:2001:470:ea4a:1:5054:ff:fec7:86e4]) by sourceware.org (Postfix) with ESMTP id 779073858CD1 for ; Wed, 29 Nov 2023 07:57:31 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 779073858CD1 Authentication-Results: sourceware.org; dmarc=pass (p=none dis=none) header.from=gentoo.org Authentication-Results: sourceware.org; spf=pass smtp.mailfrom=gentoo.org ARC-Filter: OpenARC Filter v1.0.0 sourceware.org 779073858CD1 Authentication-Results: server2.sourceware.org; arc=none smtp.remote-ip=2001:470:ea4a:1:5054:ff:fec7:86e4 ARC-Seal: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701244652; cv=none; b=OduHDGOC8d+AlYRjrd8jpR/uY4p1p1uRxIbxGxagNgtsx9sc59LFNTUOVSuHKIuBT6OM8AuFvw7BIH7orWwrTSJJApMYJtfSt9f83UZG7iQIPolFTI193BZa3Bw1FFEgHslnAt63LrgftqolDS2tVxG6Y7d7yaSPp4QIOQfJreE= ARC-Message-Signature: i=1; a=rsa-sha256; d=sourceware.org; s=key; t=1701244652; c=relaxed/simple; bh=uSjTBXL5OAiLhoak1IzRFLbsOEnT2Ues6Vb4v6W7cAM=; h=Date:From:To:Subject:Message-ID:MIME-Version; b=qLWozv3tFPe41CuqLxWy0flQAsjeidj/bbzZTuaTzryDQz4OuWxv7W8K61MrdBEcR0RjXdYzyVW3Oyc46OUm5Uy4Tnx2VWymiNPecvL/7TlIW+JR8vHwdTReKH1gIXJph+LzGoxw2DBNUPax7VSOPyB24US1eeRi+bhJoQzZgoU= ARC-Authentication-Results: i=1; server2.sourceware.org Received: by smtp.gentoo.org (Postfix, from userid 559) id C020C335D0E; Wed, 29 Nov 2023 07:57:30 +0000 (UTC) Date: Wed, 29 Nov 2023 02:57:30 -0500 From: Mike Frysinger To: jaydeep.patil@imgtec.com Cc: gdb-patches@sourceware.org, aburgess@redhat.com, joseph.faulls@imgtec.com, bhushan.attarde@imgtec.com Subject: Re: [PATCH v2 1/3] [sim/riscv] Add basic semi-hosting support Message-ID: References: <20231030130042.1472535-1-jaydeep.patil@imgtec.com> <20231030130042.1472535-2-jaydeep.patil@imgtec.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="DB9lkEZDVpWSZ4YS" Content-Disposition: inline In-Reply-To: <20231030130042.1472535-2-jaydeep.patil@imgtec.com> X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, JMQ_SPF_NEUTRAL, KAM_DMARC_STATUS, SPF_HELO_PASS, SPF_PASS, TXREP, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on server2.sourceware.org X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.30 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org --DB9lkEZDVpWSZ4YS Content-Type: text/plain; charset=utf-8 Content-Disposition: inline On 30 Oct 2023 13:00, jaydeep.patil@imgtec.com wrote: > Added support for basic semi-hosting calls OPEN, EXIT and GET_CMDLINE. what host environment are you implementing ? none of the syscalls you've defined match what have long been in the riscv libgloss port. those are the only ones i'd really expect at this point to be wired up. > Added gdb.arch/riscv-exit-getcmd.c to test it. > --- > gdb/testsuite/gdb.arch/riscv-exit-getcmd.c | 26 +++ > gdb/testsuite/gdb.arch/riscv-exit-getcmd.exp | 27 +++ > sim/riscv/riscv-sim.h | 32 +++ > sim/riscv/sim-main.c | 230 ++++++++++++++++++- you're missing sim/ tests. gdb tests are great, but not sufficient. > @@ -990,6 +1209,7 @@ execute_one (SIM_CPU *cpu, unsigned_word iw, const struct riscv_opcode *op) > case INSN_CLASS_A: > return execute_a (cpu, iw, op); > case INSN_CLASS_I: > + case INSN_CLASS_ZICSR: > return execute_i (cpu, iw, op); seems unrelated to this patch -mike --DB9lkEZDVpWSZ4YS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEuQK1JxMl+JKsJRrUQWM7n+g39YEFAmVm7uQACgkQQWM7n+g3 9YEsXg//eVwsDAD4+QXXsXb7XCkPQb20NL/KFVZugqyKtSSz9KbTkI/t/dxIwSNq 15ZBfb/LwEmK7PCQDInN4q6l75tM99OeCmrq5EWr/NCdRVxPuPM9b5aaW/JgXZB3 tr7j+JHttl7E7m8dQqOKexzD7SUonm/6/dQee8BvZ7xZZJ0YS02XE8l9NaDBBf4N +kbNba/F9SfbaBEMtzOTHwzVX7vfuj8N0bGnLLwfzkUVhTSSYmuN79mfZUhOdLpK osgPE9OfVn/p+9SweTUV4MP5DpVoWs88ZKM7mtVEYNQ4n7GV76xP4rBA0UEUaNh0 1W3znCtJNFxqLbyhn4G55aSJouXowTWkOTPMZ9Ufa14E4Y+zOpLkaYhbIEzmNQA8 mXnTxZ+wPwe/8lX02QNMMjX2BxizeZ8q2FLhK2va/1BmBq5sNXRcfegf4t5MCFEL qBCqP7XF9yHxnNaYS89ROaCAXZOUhX8dXfhM0MOUYP/6/0jV4mjMc0ejDHMeplFm BU4wIxqMJHC14i5813qsmq9WvuzIyfE9zL/fIiCsWjF9KRjy88GSdYRH3rnDNegd DrwzeTjPIqMsv6a9nwXP5LZnqvX5nUI5VTn+mXNC0BNG9pqUd3EyexHwtoBVku0a DsNGNj9gVLIQrIqbuYQHymYMF14x5fxHIqYp4/HDzipkJDn0rps= =ZU4l -----END PGP SIGNATURE----- --DB9lkEZDVpWSZ4YS--