From: "YunQiang Su" <yunqiang.su@oss.cipunited.com>
To: "Pedro Alves" <pedro@palves.net>
Cc: "Ying Huang" <ying.huang@oss.cipunited.com>,
<gdb-patches@sourceware.org>
Subject: Re: [PATCH 0/2] Change all E_MIPS_* to EF_MIPS_*
Date: Thu, 16 Nov 2023 10:25:29 +0800 [thread overview]
Message-ID: <ZVV9mQBzcqzsDIVm@vm-1> (raw)
In-Reply-To: <5c52259b-f9af-4227-bc2e-addda3f50cf6@palves.net>
On Tue, Nov 14, 2023 at 11:43:27AM +0000, Pedro Alves wrote:
> On 2023-11-14 09:45, Ying Huang wrote:
> > According to we have changed all E_MIPS_* to EF_MIPS_* in binutils
> > and glibc, we also need to change it here to keep same style.
> > We can refer to this commit record:
> > https://sourceware.org/pipermail/binutils/2023-October/129904.html
>
> This is OK, but please put this information in the commit logs themselves, so that
> if someone in the future needs to "git blame" the touched lines isn't left with
> an empty rationale for the change.
>
> So, you can add my:
>
> Approved-By: Pedro Alves <pedro@palves.net>
>
> with that change.
>
Thank you. I have pushed Ying's v2 patchset.
next prev parent reply other threads:[~2023-11-16 2:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-14 9:45 Ying Huang
2023-11-14 9:45 ` [PATCH 1/2] gdb: mips: Change " Ying Huang
2023-11-14 9:45 ` [PATCH 2/2] sim: " Ying Huang
2023-11-14 11:43 ` [PATCH 0/2] Change all " Pedro Alves
2023-11-15 2:19 ` Ying Huang
2023-11-16 2:25 ` YunQiang Su [this message]
2023-11-15 2:30 Ying Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVV9mQBzcqzsDIVm@vm-1 \
--to=yunqiang.su@oss.cipunited.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=ying.huang@oss.cipunited.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox