From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from simark.ca by simark.ca with LMTP id EONVOSnsWmQt0gQAWB0awg (envelope-from ) for ; Tue, 09 May 2023 20:58:17 -0400 Received: by simark.ca (Postfix, from userid 112) id E699A1E11D; Tue, 9 May 2023 20:58:17 -0400 (EDT) Authentication-Results: simark.ca; dkim=pass (1024-bit key; secure) header.d=sourceware.org header.i=@sourceware.org header.a=rsa-sha256 header.s=default header.b=ihiolUQf; dkim-atps=neutral X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on simark.ca X-Spam-Level: X-Spam-Status: No, score=-7.0 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,RCVD_IN_DNSWL_HI, RDNS_DYNAMIC,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 Received: from sourceware.org (ip-8-43-85-97.sourceware.org [8.43.85.97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by simark.ca (Postfix) with ESMTPS id 6C3141E114 for ; Tue, 9 May 2023 20:58:17 -0400 (EDT) Received: from server2.sourceware.org (localhost [IPv6:::1]) by sourceware.org (Postfix) with ESMTP id B2AFF3857437 for ; Wed, 10 May 2023 00:58:16 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 sourceware.org B2AFF3857437 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sourceware.org; s=default; t=1683680296; bh=FY0mtxLOO4dldeKV4e8rGfaNZJh9YfHCvj4lqRFPa4E=; h=Date:To:Cc:Subject:References:In-Reply-To:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: From:Reply-To:From; b=ihiolUQfiU/WvMseCwEfmiJf0UrLTd8Fpd2G4fnIiX6dC3laKBQs/rOO/03mlfCpz vLYEt/48bEZJ9qu0XxDrkjvW0B+QOlGy5YKdoPOskm+41vddVyjVzyvC84aiq6y5QN GLFqJAtJxNCQeiRp/T0uay9t7gLOZQQqe+OK5kl8= Received: from mail-pl1-x630.google.com (mail-pl1-x630.google.com [IPv6:2607:f8b0:4864:20::630]) by sourceware.org (Postfix) with ESMTPS id 3303D3858C2B; Wed, 10 May 2023 00:56:56 +0000 (GMT) DMARC-Filter: OpenDMARC Filter v1.4.2 sourceware.org 3303D3858C2B Received: by mail-pl1-x630.google.com with SMTP id d9443c01a7336-1aaf7067647so45867765ad.0; Tue, 09 May 2023 17:56:56 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683680215; x=1686272215; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=FY0mtxLOO4dldeKV4e8rGfaNZJh9YfHCvj4lqRFPa4E=; b=L+sDDCtrQGUvi0rNMo+vC/vJX7rZktrqu8wfegFWUyMKwu+XULaTBoKLwp4sUmGXmD VJUCVCYvagHXs9VQTh2+wuAG/ZoCpC3gg93ruJxC6nN6nCtOCqdnxfzo4xRjn/QpciqB Y1DB5xANpfH6i92IZmTvHC7tm5I4d9eU4q3A+M/PtQEnB5rSz0E+SY1eUv5141p+AMoT oMV8cGr4Giy4j5oiAKvb3SqH+3iqJD4b1Z3p8K8zblSJL6glSdSoMrDlmVxxeMtihnfL mBdT6VlJ+1qbnM1NUHeYJyHxau8mvFfFI4rMaobcKQBbHanLzeem+JA0yI5khUBnVHDI 1Xfw== X-Gm-Message-State: AC+VfDzlCjhfS35yf8JedfiG6cT+9231YGSsKeXeg6xb1qqQIioLHmHb oCDuxowEY2VxZlKymMRJtcgogtsDv8w= X-Google-Smtp-Source: ACHHUZ648sUYOAXZ2kJkcTl8OGhbhU4Xfn1zIrvi4dQV3t2JUxeaZHnlfA2brhQtV/wWfMZIlc6uog== X-Received: by 2002:a17:902:e845:b0:1ac:63ac:109d with SMTP id t5-20020a170902e84500b001ac63ac109dmr14706483plg.15.1683680214989; Tue, 09 May 2023 17:56:54 -0700 (PDT) Received: from squeak.grove.modra.org (158.106.96.58.static.exetel.com.au. [58.96.106.158]) by smtp.gmail.com with ESMTPSA id 17-20020a170902ee5100b001a63ba28052sm2292749plo.69.2023.05.09.17.56.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 09 May 2023 17:56:54 -0700 (PDT) Received: by squeak.grove.modra.org (Postfix, from userid 1000) id C9C18114087E; Wed, 10 May 2023 10:26:51 +0930 (ACST) Date: Wed, 10 May 2023 10:26:51 +0930 To: Mark Harmstone Cc: binutils@sourceware.org, gdb-patches@sourceware.org Subject: Re: [PATCH 1/2] pdb: Allow loading by gdb Message-ID: References: <20230509003247.24156-1-mark@harmstone.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230509003247.24156-1-mark@harmstone.com> X-BeenThere: gdb-patches@sourceware.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Gdb-patches mailing list List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Alan Modra via Gdb-patches Reply-To: Alan Modra Errors-To: gdb-patches-bounces+public-inbox=simark.ca@sourceware.org Sender: "Gdb-patches" On Tue, May 09, 2023 at 01:32:46AM +0100, Mark Harmstone wrote: > Add a new bfd_flavour value, and expose PDB files as objects, so that > they get accepted by add-symbol-file. By equating object_p and archive_p you are going to get whichever of bfd_archive or bfd_object is tried first as the argument of bfd_check_format (or bfd_check_format_matches). This seems fragile to me. We have multiple binary utilities, ld, and gbd all calling bfd_check_format. Do they all work correctly with this change, and will they continue to work correctly with future changes? I think you'd be better off staying with just one format, and bfd_archive probably fits pdb files better than bfd_object. -- Alan Modra Australia Development Lab, IBM